Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Mon Sep 25, 2017 2:30 am

All times are UTC




Post new topic  Reply to topic  [ 15 posts ] 
Author Message
 Post subject: NFORenum 4.0.0
PostPosted: Mon Aug 09, 2010 12:31 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Thu Feb 09, 2006 7:15 pm
Posts: 3815
Note: NFORenum has been merged with the GRFCodec source package. As such new downloads can be found at the GRFCodec thread.
The information below is therefore of a historical nature.



Due to time constraints and loss of interest DaleStan could not work on GRFCodec and NFORenum anymore. This resulted in the slow decay of both GRFCodec and NFORenum.

This caused problems for people compiling it with recent compilers (it failed to compile), for the developement of the NewGRF specifications (new features wouldn't be supported) or for the people, such as the nice folks at OpenTTDcoop's developer zone, for using it to develop NewGRFs; many warnings about valid NFO, but just because NFORenum hasn't been updated.

With the release of NFORenum 4.0.0 we revive NFORenum in the hope to keep it useful and usable for as long as it's neeeded. In any case some things regarding the development have changed. The source repository and issue tracker can be found on http://dev.openttdcoop.org/projects/nforenum and as such bug reports and feature requests for NFORenum should go to there. Furthermore we will try to release at least two stable version of NFORenum per year, or more often if required.

Issues with NFORenum or feature requests can go here to determine whether it is actually a bug or whether the feature request is feasible, but ultimately we would like them to be reported at the tracker.

In any case, we would like to thank DaleStan for initially developing and maintaining NFORenum.


Last edited by Rubidium on Sun Oct 17, 2010 9:05 pm, edited 2 times in total.

Top
   
 Post subject: Re: NFORenum 4.0.0-RC1
PostPosted: Mon Aug 09, 2010 2:20 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Nov 27, 2004 3:05 pm
Posts: 4984
Location: Canada
This as well shall be given a good workout over the next few weeks. :D
Thank you for your work on this.

_________________
wallyweb on tt-forums: Screenshots - Projects - Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016


Top
   
 Post subject: Re: NFORenum 4.0.0-RC1
PostPosted: Wed Aug 11, 2010 2:19 am 
Offline
Tycoon
Tycoon

Joined: Fri Mar 04, 2005 1:07 am
Posts: 1491
A couple of issues not showing with previous version of NfoRenum :

Code:
//!!Warning (86): Offset 4: Testing nonexistant variable 25.
1376 * 30    02 00 00 89 25 20 FF FF FF FF ...


Code:
//!!Error (162): Offset 14: Text ID DC01 has not been defined.
//!!Error (162): Offset 17: Text ID DC02 has not been defined.
3988 * 57    00 0B 13 01 16 08 16 09 00 DC 0A 00 DC 0B 01 DC 0C 02 DC
                                                 0D 03 DC 0E DA 10 0F 10 10 07 11 FF 12 ...

surely defined; funny it doesn't complain about DC00 and DC03


Top
   
 Post subject: Re: NFORenum 4.0.0-RC1
PostPosted: Wed Aug 11, 2010 5:49 am 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Thu Feb 09, 2006 7:15 pm
Posts: 3815
OzTrans wrote:
A couple of issues not showing with previous version of NfoRenum :
Code:
//!!Warning (86): Offset 4: Testing nonexistant variable 25.
NFORenum (nightly) r2309 had the same complaint; probably you had a custom .dat file. In any case, thanks for the report and it's fixed in NFORenum r463.


OzTrans wrote:
Code:
//!!Error (162): Offset 14: Text ID DC01 has not been defined.
//!!Error (162): Offset 17: Text ID DC02 has not been defined.
For this I need a larger testcase, preferably the whole .nfo that is causing the problem (you can PM me the .nfo as well).


Top
   
 Post subject: Re: NFORenum 4.0.0-RC1
PostPosted: Thu Aug 12, 2010 2:33 am 
Offline
Tycoon
Tycoon

Joined: Fri Mar 04, 2005 1:07 am
Posts: 1491
Quote:
//!!Error (162): Offset 14: Text ID DC01 has not been defined.
This should help ... When NfoRenum passes the action 4's, it takes a note of the first and last string ID with multiple string definitions. DC00 through to DC03 were defined together in one action-4; that's why it didn't complain about DC00 and DC03.


Top
   
 Post subject: Re: NFORenum 4.0.0-RC1
PostPosted: Thu Aug 12, 2010 6:51 am 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Thu Feb 09, 2006 7:15 pm
Posts: 3815
OzTrans wrote:
This should help ...
Yes it did; could create a testcase and fix it (in r464).


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Tue Aug 17, 2010 4:12 am 
Offline
Tycoon
Tycoon

Joined: Fri Mar 04, 2005 1:07 am
Posts: 1491
Here is another one, deteced mistakenly by r465 ... it is valid for feature 0F (objects).

Code:
//!!Warning (86): Offset 4: Testing nonexistant variable 5F.
 5670 * 111    02 0F 20 85 5F 2C 0F 00 00 43 20 0F 00 ...


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Tue Aug 17, 2010 8:07 am 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Thu Feb 09, 2006 7:15 pm
Posts: 3815
OzTrans wrote:
Code:
//!!Warning (86): Offset 4: Testing nonexistant variable 5F.
Fixed in r470.


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Wed Aug 25, 2010 4:08 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Fri Sep 16, 2005 12:23 pm
Posts: 1517
Skype: the_gremnon
Location: /home
For those using Arch Linux, there are now packages in the AUR to install NFORenum, maintained by me.
You can find it here: http://aur.archlinux.org/packages.php?ID=40248


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Tue Aug 31, 2010 2:11 am 
Offline
Engineer
Engineer
User avatar

Joined: Fri Jul 16, 2010 1:09 pm
Posts: 65
Excellent work sirs!

_________________
Shanghai Maglev Inspired Track Set | OpenGFX+Trees | Flexible Tunnels | Monkey Bar Bridge | FS-Maglev Track


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Tue Aug 31, 2010 2:20 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Nov 27, 2004 3:05 pm
Posts: 4984
Location: Canada
Rubidium wrote:
Fixed in r470.
The changelog is still at r469. Has the download gone to r470 without an update to the changelog?
Ooops! :oops: I was looking at the release and not the nightly. All is well.

_________________
wallyweb on tt-forums: Screenshots - Projects - Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Wed Sep 01, 2010 6:16 pm 
Offline
TTDPatch Developer
TTDPatch Developer
User avatar

Joined: Wed May 26, 2004 4:37 pm
Posts: 1802
Location: Britain
Unless I'm mistaken object property 15 should be a word value. (using r482)
Code:
//!!Fatal Error (47): Offset 16: Invalid property 00.
    3 * 19    00 0F 06 01 04
        11  FF FF
        12  02
        13  03
        14  0A
        15  31 00
        16  01

I'm not really sure what's wrong here, the older versions of Renum never complained about this. (using r482)
Code:
//!!Warning (209): Offset 4: Found byte 1 of a 4-byte escape while reading byte 1 of a 1-byte field.
    7 * 17     02 0F 00
          00        // Number of sprites
          \d3924    // Ground Sprite
          00 80 00 80   00 00    00 00 00

~ Lakie

_________________
TTDpatch Developer 2005 - 2010 ~ It all started because of shortened vehicle not loading correctly, now look where I've gone with it!
Grfs coded ~ Finnish Train Set (Teaser) | Bm73 (Release 3) | Emu 680 (Release 3)| Glass Station (Release 1) | UK Roadset (Version 1.1a) | New Water Coasts (Version 7)
Pikka: "Lakie's a good coder, but before he'll add any feature to TTDP you have to convince him that you're not going to use it to destroy the world as we know it."


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Wed Sep 01, 2010 6:44 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Thu Feb 09, 2006 7:15 pm
Posts: 3815
Lakie wrote:
Unless I'm mistaken object property 15 should be a word value. (using r482)
Code:
//!!Fatal Error (47): Offset 16: Invalid property 00.
    3 * 19    00 0F 06 01 04
        11  FF FF
        12  02
        13  03
        14  0A
        15  31 00
        16  01

13 is a word. So 0A is interpreted as property, which is a word as well so 00 gets interpreted as a property. So the error is not property 15.

Testing this with (svn) r2309 reproduces the issue, so it's not recently introduced. Nevertheless it's fixed in r484.


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Thu Sep 02, 2010 12:13 am 
Offline
Tycoon
Tycoon

Joined: Wed Jan 17, 2007 12:14 am
Posts: 6918
Lakie wrote:
I'm not really sure what's wrong here, the older versions of Renum never complained about this. (using r482)
Code:
//!!Warning (209): Offset 4: Found byte 1 of a 4-byte escape while reading byte 1 of a 1-byte field.
    7 * 17     02 0F 00
          00        // Number of sprites
          \d3924    // Ground Sprite
          00 80 00 80   00 00    00 00 00

the point of warnings is not usually to say something is wrong, but more point out common pitfalls, in this situation it looks like you have an alignment problem, because the 4-byte-escape is distributed over several syntax elements after expanding. this means that you might have forgotten a byte somewhere or so.

_________________
You might not exactly be interested in Ferion, but if you are, have fun :)


Top
   
 Post subject: Re: NFORenum 4.0.0
PostPosted: Thu Sep 02, 2010 5:55 am 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon May 21, 2007 11:47 am
Posts: 6559
Location: The Netherlands
Eddi wrote:
the point of warnings is not usually to say something is wrong, but more point out common pitfalls

If there's nothing wrong, there shouldn't be warned. When I allowed this warning in FIRS, it filled my terminal to the point where the warnings didn't even fit into it any more[0]. Now that's not useful if you're looking for real bugs.
Apart from that, Lakie's code looks perfectly fine and the escape doesn't span multiple elements in this case.



[0]Why this wasn't reported earlier is a bit of a mystery. This particular warning has been disabled in FIRS for about a year, so there's no point arguing why we didn't report it back then: we have no idea. Anyways, it's fixed now.

_________________
FooBar's Tram Tracks | TransRapid Track Set | Metro Track Set | OpenGFX base graphics set | FIRS Industry Replacement Set
Dutch Tram Set | Dutch Trainset 2 | Dutch Road Furniture


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 15 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000-2017 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2017.
Hosted by Zernebok Hosting.