FIRS Industry Replacement Set - Development

[Radmir]

Updated translation file for r2700.

[Bob_Mackenzie]

Ive noticed FIRS builds petrol stations adjacent to tram lines which run cross country (ie no road) was this intended behaviour?

[planetmaker]

Ive noticed FIRS builds petrol stations adjacent to tram lines which run cross country (ie no road) was this intended behaviour?

Lol

No, it's not. But I know no way how we can avoid it. We can only check for the adjacent tile class (and we check for 'road' in this case), but we cannot query the road type (road or tram).

[Supercheese]

Solution: use Newobjects/station tiles to build a tram refueling depot around the petrol station.

[NekoMaster]

Solution: use Newobjects/station tiles to build a tram refueling depot around the petrol station.

But most trams run on Electricity, this might only be good for earlier trams that ran on steam

[planetmaker]

Updated translation file for r2700.

Thanks. You'll find it in 2701:a55c5727e849 and the upcoming nightly.

[MinchinWeb]

I love the set and so would like my AI to work with it. I'm trying to make it transport cargo from sea-based industries to make a little money. I try and find said industries by looking for those with a dock. However, with FIRS, I get the Fishing Grounds, but not the Dredging sites. Is the Dredging site somehow coded so it doesn't *really* have a dock? Or something stranger?

Anyway, the AI code I'm using to find them is:

Code: Select all

//	Actually this checks for industries that include docks
local MyIndustries = AIIndustryList();
MyIndustries.Valuate(AIIndustry.HasDock);
MyIndustries.KeepValue(true.tointeger());

[NekoMaster]

I love the set and so would like my AI to work with it. I'm trying to make it transport cargo from sea-based industries to make a little money. I try and find said industries by looking for those with a dock. However, with FIRS, I get the Fishing Grounds, but not the Dredging sites. Is the Dredging site somehow coded so it doesn't *really* have a dock? Or something stranger?

Anyway, the AI code I'm using to find them is:

Code: Select all

//	Actually this checks for industries that include docks
local MyIndustries = AIIndustryList();
MyIndustries.Valuate(AIIndustry.HasDock);
MyIndustries.KeepValue(true.tointeger());

I think the dredging sites are more like oil rigs.

[planetmaker]

Is the Dredging site somehow coded so it doesn't *really* have a dock?

The dredging site has docks, just like fishing grounds.

[andythenorth]

Dredging site, fishing grounds and oil rig all work identically; OpenTTD only provides one way to do this.

Water-based industries in FIRS (1) set an industry special flag that allows them to build on water (2) include a special tile that provides the station.

Does the map definitely have dredging sites available? Does the AI find oil rigs?

[MinchinWeb]

Dredging site, fishing grounds and oil rig all work identically; OpenTTD only provides one way to do this.

Water-based industries in FIRS (1) set an industry special flag that allows them to build on water (2) include a special tile that provides the station.

Does the map definitely have dredging sites available? Does the AI find oil rigs?

That's what I thought. My AI does indeed find Oil Rigs (on the standard map). And I am working with a map that has dredging sites.

If you want to see it in action, WmDOT v7 is on Bananas. In the AI settings, turn OperationDOT to "no go" and Debug Level to "5." At the beginning of Operation Hibernia, it will say "Kept xx Industries." which should include all sea-based industries.

Example of "Kept 1 Industry" on FIRS

FIRS_WmDOT Debugging, 5th Jan 1965.png (51.63 KiB) Viewed 3113 times

[ervin2]

Can I make a suggestion? How about a high-tech factory that accepts rare earth minerals and plastics, and produces computer chips?

[FooBar]

There's no space for additional cargos in FIRS.

[ervin2]

There's no space for additional cargos in FIRS.

Interesting, why is there a cargo limit?

Sorry, I know this must have already been explained repeatedly.

[FooBar]

Because the game has a limit to the number of cargos that can exist. Like there is a limit to the amount of industries, amount of vehicles, amount of objects. Everything is limited one way or the other. Some limits are higher than others.

[akasoft]

What does this code block in sheep_farm.pnml?

Code: Select all

switch(FEAT_INDUSTRYTILES, SELF, THIS_ID(tile1_layout), STORE_TEMP((var[0x7E, 0, 255, 161] + var[0x7E, 0, 255, 65]), 16)) {
  THIS_ID(layout);
}

What mean magic number 161 and 65?

It is sample of using procedure? What is the procedure? Can I use labels like "THIS_ID(tile1_layout)" or "THIS_ID(layout)" instead of the magic number?

[planetmaker]

What does this code block in sheep_farm.pnml?

Code: Select all

switch(FEAT_INDUSTRYTILES, SELF, THIS_ID(tile1_layout), STORE_TEMP((var[0x7E, 0, 255, 161] + var[0x7E, 0, 255, 65]), 16)) {
  THIS_ID(layout);
}

What mean magic number 161 and 65?

It is sample of using procedure? What is the procedure? Can I use labels like "THIS_ID(tile1_layout)" or "THIS_ID(layout)" instead of the magic number?

See http://newgrf-specs.tt-wiki.net/wiki/NM ... ted_syntax
Yes, it's a procedure call. But it's part of the auto-converted code which will not yet work (unless I missed something).

[akasoft]

How the var[] works, I know.
I was wondering why the code in NML so few procedure calls. There are practically no. And then the search found it in the FIRS.

[MinchinWeb]

(..) I try and find said industries by looking for those with a dock. However, with FIRS, I get the Fishing Grounds, but not the Dredging sites. Is the Dredging site somehow coded so it doesn't *really* have a dock? Or something stranger?

I reported this as a bug.

Another strange thing is I've noticed is if I query the station tile of either a Fishing Ground or a Dredging Site, it tells me it's an Oil Rig. Is this a limitation of OpenTTD or a bug in FIRS?

[andythenorth]

Another strange thing is I've noticed is if I query the station tile of either a Fishing Ground or a Dredging Site, it tells me it's an Oil Rig. Is this a limitation of OpenTTD or a bug in FIRS?

It's a limitation of OpenTTD.