roest's patch pack v9 (r13019)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

rbn2903
Engineer
Engineer
Posts: 122
Joined: 08 Dec 2007 18:04
Location: Aachen (Aken), Germany

Re: yet another...err...my patch pack (r13019)

Post by rbn2903 »

Hi. I think I found a problem that only occurs, if you put the "timetable based separation patch" and the "daylength patch" together. Actually there two Problems.

1) (minor problem): if you click on "automatically separate" with a daylength factor bigger than "1", the start dates of any vehicle in a shared order are way too much apart from each other (hope that's understandable, i usually speak German ;-) ). I can solve that problem by replacing of the variable "DAY_TICKS" into "DayLength()" (which is introduced in the daylength patch, so it's ok, that the separation-patch doesn't know it)
2) (major problem): the bigger the daylength factor is, the bigger is the chance that more and more vehicles (of a shared order) arrives at the first station at the SAME Day, so all their timetables will start at the same day, so they'll leave one after each other, and there isn't really separation anymore. Can please someone confirm that and has a solution for that problem, that doesn't involve rewriting most of the code to be based on ticks, not days? ;-) (I don't think I'd be able to do this) It's really sad, I can't enjoy using both patches. Thanks for your help.

btw: nice work putting all these patches together! :]

Greets, Rainer
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: yet another...err...my patch pack (r13019)

Post by Roest »

Well i think this cannot be avoided. Every single patch is written for an unpatched version of the trunk. Fixing them to work together will take an amount of time i simply don't have at the moment. Bringing the pack to current trunk, i.e. incorporate all updated patches and update the remaining ones myself will already take some hours.
rbn2903
Engineer
Engineer
Posts: 122
Joined: 08 Dec 2007 18:04
Location: Aachen (Aken), Germany

Re: yet another...err...my patch pack (r13019)

Post by rbn2903 »

I totally unterstand that. I didn't mean my post as an attack or something like that ;-)
I was able - against my own saying - to change the timetable based separation patch to be based on ticks, not days. But I'm not into "svn", so I'm not able to post a patch/diff... And it works :!: , but now the "Start Date" functionality shows random values, because i don't know how to change my "ticks" into "Date".
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: yet another...err...my patch pack (r13019)

Post by Roest »

updated to r13117

updated: YAPP v7
updated: Routing Restrictions

added: filter by cargo
added: close airports

edit: for some reason buildottd fails me on my xp machine, it compiles fine on linux, so i have no real clue whats going on right now. Can anyone compile it on windows?

There won't be a new version with pax dest unless someone brings it up to current trunk.
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: roest's patch pack v10 (r13117)

Post by Roujin »

BuildOTTD relies on mingw/gcc. gcc compilation was broken in r13117. MSVC compilation works though.

gcc compilation was fixed in r13122.
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: roest's patch pack v10 (r13117)

Post by Ammler »

Here is win roest pack compiled with svn r13116:
trunk_r13116_patchpack_v10_r13117.patch_17.05.08_00-09-19.exe (link removed)

Greets
Ammler
Last edited by Ammler on 17 May 2008 09:48, edited 1 time in total.
einKarl
Engineer
Engineer
Posts: 7
Joined: 01 Apr 2008 06:27
Location: Bavaria, Germany

Re: yet another...err...my patch pack (r13019)

Post by einKarl »

Roest wrote:updated to r13117

updated: YAPP v7
updated: Routing Restrictions
[...]
This Version does not work properly here.
(I compiled it from svn without errors an a standard OpenSuse 10.3)

Problems:
  • I cannot click on the last 2 items on the right side of the signal-Menu. That means: cannot place a YAPP-oneway-Signal; cannot change Signals.
  • Message "Trains got lost" (? - "haben sich verirrt") nearly daily. But they do their work.
  • I tried to build stations other that standard. All options are available, but always the standardstation is build. (The same combination of newgrf work fine with other OTTD-Versions, including your Version 13019)
Servus
KS
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: roest's patch pack v10 (r13117)

Post by Roest »

removed it for now, will post another one later

update: there won't be a new pack soon, too much stuff needs fixing first
trainguru
Engineer
Engineer
Posts: 1
Joined: 20 May 2008 17:29

Re: roest's patch pack v10 (r13117)

Post by trainguru »

Hi,

if you are compiling a new version of your really great patchpack, it would be amazing, if you could add that sharing-stuff from http://www.tt-forums.net/viewtopic.php?f=33&t=37455 to it.

Best regards
trainguru
User avatar
Two5Kid
Chief Executive
Chief Executive
Posts: 654
Joined: 26 Feb 2007 07:10
Location: Kota Bharu, Malaysia

Re: roest's patch pack v10 (r13117)

Post by Two5Kid »

A very big sorry for my 'outrageous' request for help.

Anyone able to compile this Patchpack for OSX?
If not, is there any other way I could play OpenTTD besides using vitualization? And also besides downloading OpenTTD for Mac, since it doesn't support this patchpack.
Any dream worth having,
Is a dream worth fighting for!
User avatar
Roest
Traffic Manager
Traffic Manager
Posts: 215
Joined: 03 Apr 2008 08:18

Re: roest's patch pack v10 (r13117)

Post by Roest »

Ok so i thought I'd give a status report. I'm still interested in bringing this up to date but it still won't happen soon. I'm pretty busy with my other project and it takes A LOT of time, just merging so many patches. Now as those who have little programming background might have noticed, there have been many code changes in trunk lately. In particular the whole window code was changed, so every patch that uses some kind of gui now needs work beyond fixing some simple conflicts. Doing this for 15+ patches I don't have the time nor will. So I'll wait for the patch authors or anyone else to update their patches while I procrastinate on updating the bettergraph patch which is kinda my own responsibility :)
User avatar
Toni Babelony
Tycoon
Tycoon
Posts: 1389
Joined: 07 Jul 2006 09:34
Skype: toni_babelony
Location: Sagamihara-shi, Japan
Contact:

Re: roest's patch pack v10 (r13117)

Post by Toni Babelony »

Two5Kid wrote:Anyone able to compile this Patchpack for OSX?
If not, is there any other way I could play OpenTTD besides using vitualization? And also besides downloading OpenTTD for Mac, since it doesn't support this patchpack.
I'll get on to it tomorrow! I'm trying to compile it together with the Track Sharing patch as this seems just too awesome to be true... (I have the feeling it won't work)
Retired JapanSet developer and creator of TIAS.
nonick37
Engineer
Engineer
Posts: 26
Joined: 25 Mar 2006 13:38
Contact:

Re: roest's patch pack v9 (r13019)

Post by nonick37 »

A little problem:
I downloaded the precompiled v9 windows binary with and without paxdest.
I have been playing with paxdest for a while single player, and wanted to tedt without paxdest in multiplayer.
There is two servers which runs this patchpack online, one password protected, and one open.. leaves me with little choice.. so..
http://www.openttd.org/server_detail.php?id=20358
Indiana's Game (roest's patch pack v9)
Last update: Friday, May 23rd 2008 12:36 GMT Clients: 0 / 10 (3 / 8 companies; 0 / 10 spectators)
Language: [German]
Map: Map name: "Random Map"
Landscape: Temperate
Map size: 1024 x 512

Server version: r13019M
Server address: 88.198.0.249:3979
Start date: 1921-01-01
Current date: 1921-06-09


NewGRFs in use
GRF Name GRF Identifier MD5 Checksum
Aviators Aircraft (av8) v1.331 44440A01 A7EA6FB6732157AEE44627A64EBCDAE6
City Stations 52455400 1600687C50C5AB1E72EDD487CAD50E2A
DB Set V0.82 (XL) 05.05.05 6D620401 C5ACB6D5536A464FD78871D91840A35F
Dutch Tram Set r15 4642FB31 A2FD21ADC90E63CA0237A9038E21BC8D
Generic buffer-stops v0.1 504E0002 6E6944E09CE6C3AC130DF72C542EE4B1
German Town Names Set 1.0 44550002 AF3E5FAC975E947C1CA19FAD48D66E68
GRVTS v1.0 52571201 15128ED01E1DBB8A71A01F1B3D975A38
Industrial Stations Renewal v0.6.0 4A430002 D4317461E1CFA117D5B64C74F7CBD9C5
New bridges v0.41 535A0501 44B7893026BB8599A79DFAB05C3149AB
NewShips 6D620004 70649F1AFC954942173B0AA89C1E8B14
NewStations V0.42 05.09.05 6D620601 44EB2F155862E4D4F0AB671D7021AF54
Pikka's Basic Industries v1.2 44440602 FA22D67ABD830A8E905025F946356E29
Stolen Trees 52453C00 C5B4EC240B33E2DB8D1EA64C97898B5E
Total Bridge Renewal Set test_version #3 74677462 CA227E8F4751F04509219ADB2D8DCB1F
Total Town Replacement Set v3.02a 56430001 AF3E0A1E6EF0B98DB966594578D1775B
Problem is. when trying to connect to this one, with the non-paxdest- version , I get "Game load failed, Broken savegame - invalid chunk size". No company created since i cannot connect.
As a test, I tried to connect to the same server with the synch-problem paxdest version. With this version I was able to connect, but was disconnected for out of synch reasons. Company was created before disconnected.

Anyone experience the same problem?
einKarl
Engineer
Engineer
Posts: 7
Joined: 01 Apr 2008 06:27
Location: Bavaria, Germany

Re: roest's patch pack v9 (r13019)

Post by einKarl »

nonick37 wrote:A little problem:
I downloaded the precompiled v9 windows binary with and without paxdest.
I have been playing with paxdest for a while single player, and wanted to tedt without paxdest in multiplayer.
There is two servers which runs this patchpack online, one password protected, and one open.. leaves me with little choice.. so..
http://www.openttd.org/server_detail.php?id=20358
Indiana's Game (roest's patch pack v9)
[...]
Anyone experience the same problem?
Same Problem with selfcompiled Linux-Version.
Indiana will try to recompile without PaxDest.

Servus
KS
Touqen
Engineer
Engineer
Posts: 21
Joined: 09 May 2007 13:50
Location: Boston, MA, US

Re: roest's patch pack v9 (r13019)

Post by Touqen »

Multiplayer paxdest doesn't currently work.
User avatar
Dave
Moderator
Moderator
Posts: 17249
Joined: 26 Dec 2005 20:19
Location: North London

Re: roest's patch pack v9 (r13019)

Post by Dave »

I might just fall in love with you. This is brilliant.
Official TT-Dave Fan Club

Dave's Screenshot Thread! - Albion: A fictional Britain
Flickr


Why be a song when you can be a symphony? r is a...
User avatar
Indiana
Engineer
Engineer
Posts: 36
Joined: 07 Feb 2008 09:15

Re: roest's patch pack v9 (r13019)

Post by Indiana »

While saving on my server I see the following Errors:

Code: Select all

Saving map...
dbg: [misc] Saving Criteria REF 0
dbg: [misc] Saving Criteria REF 0
dbg: [misc] Saving Criteria REF 1
dbg: [misc] Saving Criteria REF 1
dbg: [misc] Saving Criteria REF 2
dbg: [misc] Saving Criteria REF 2
dbg: [misc] Saving Criteria REF 3
dbg: [misc] Saving Criteria REF 3
Map sucessfully saved to o2.sav
Also the game often de-sync (but not for all player!) later it will switch to ontoher player to be desync :-(
Minimun once a day the game die and I have to restart it.

=> Even without PaxDest not 100% MP able.
But it is the best we have! And I won't give pack alle this nice new functions!

PS: Maybe you can add that the company passwords will be saved than it is not that bad because I write a script which will restart the server with the last autosave.
Have a N.I.C.E. day!
Indiana
nycom
Engineer
Engineer
Posts: 62
Joined: 14 Nov 2005 13:14
Location: Paris, France

Re: roest's patch pack v9 (r13019)

Post by nycom »

Indiana wrote:While saving on my server I see the following Errors:

Code: Select all

Saving map...
dbg: [misc] Saving Criteria REF 0
dbg: [misc] Saving Criteria REF 0
dbg: [misc] Saving Criteria REF 1
dbg: [misc] Saving Criteria REF 1
dbg: [misc] Saving Criteria REF 2
dbg: [misc] Saving Criteria REF 2
dbg: [misc] Saving Criteria REF 3
dbg: [misc] Saving Criteria REF 3
Map sucessfully saved to o2.sav
Also the game often de-sync (but not for all player!) later it will switc.....
It's a debug information from the routing restriction patch.
hans89
Engineer
Engineer
Posts: 2
Joined: 31 May 2008 20:35

Re: roest's patch pack v10 (r13117)

Post by hans89 »

Toni Babelony wrote:
Two5Kid wrote:Anyone able to compile this Patchpack for OSX?/.../
I'll get on to it tomorrow! I'm trying to compile it together with the Track Sharing patch as this seems just too awesome to be true... (I have the feeling it won't work)
How's it coming? I'm really looking forward to testing this patch pack (as I've never manually added patches), if someone could compile it for Mac. Looking forward to it!
User avatar
Toni Babelony
Tycoon
Tycoon
Posts: 1389
Joined: 07 Jul 2006 09:34
Skype: toni_babelony
Location: Sagamihara-shi, Japan
Contact:

Re: roest's patch pack v9 (r13019)

Post by Toni Babelony »

Beh, haven't been onto it. You can do it yourself if you want since it's damn easy and you don't have to download extra programs for it.

- Download the OTTD source and unzip it into a folder (rename it to 'OTTD' to make it easier) that's easy to find;
- Download the patchpack to the OTTD map and rename the patchpack to: "patchpack.patch";
- Download the "copypaste.grf" from the forums and put the unzipped file in the /data map;
- Open 'Terminal' (Find it in the Applications/Utilities map);
- Type in the location of the OTTD source folder. e.g.: "cd Users/name/Desktop/OTTD" -> Enter (don't forget the "cd " in this command!);
- Then type: "patch -p0 < patchpack.patch" -> Enter;
- Wait until finished, then: "./configure" -> Enter;
- Wait until finished, then: "make bundle" -> Enter;
- Wait until finished. This could take up to 20 minutes and PRESTO! You can find your version in the /bundle map.

Be sure to have a corresponding version of OTTD and the Patchpack! Else it won't work properly.

Good luck!
Retired JapanSet developer and creator of TIAS.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 8 guests