JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Auge
Transport Coordinator
Transport Coordinator
Posts: 362
Joined: 23 Oct 2006 02:07
Location: Berlin

Re: JGR's Patch Pack

Post by Auge » 20 May 2019 15:56

Hello
piratescooby wrote:Can not be opened because of a problem error , which version of Mac is required to open ?
I would expect the following to be the relevant information.
piratescooby wrote:Dyld Error Message:
Library not loaded: /usr/local/opt/xz/lib/liblzma.5.dylib
Referenced from: /Volumes/VOLUME/*/OpenTTD.app/Contents/MacOS/openttd
Reason: Incompatible library version: openttd requires version 8.0.0 or later, but liblzma.5.dylib provides version 6.0.0
Tschö, Auge

User avatar
Azusa257
Engineer
Engineer
Posts: 3
Joined: 03 Mar 2016 17:51

Re: JGR's Patch Pack

Post by Azusa257 » 20 May 2019 17:16

My game crashed while playing on a multiplayer server.

Please find attached, the crash.sav file and the error message that popped up when the game crashed.
Attachments
crash.sav
(18.46 MiB) Downloaded 22 times
crash message.png
(832.04 KiB) Not downloaded yet
crash.dmp
(19.84 MiB) Downloaded 19 times

User avatar
JGR
Tycoon
Tycoon
Posts: 1935
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 20 May 2019 19:07

Azusa257 wrote:My game crashed while playing on a multiplayer server.

Please find attached, the crash.sav file and the error message that popped up when the game crashed.
Thanks for reporting this, any chance that you could post the crash.log file as well?
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

User avatar
Azusa257
Engineer
Engineer
Posts: 3
Joined: 03 Mar 2016 17:51

Re: JGR's Patch Pack

Post by Azusa257 » 20 May 2019 20:02

Here's the Crash log:
crashlog20190520.txt
(60.92 KiB) Downloaded 21 times
JGR, Thank you so much for the amazing patch pack as always.

Azusa

User avatar
3iff
Tycoon
Tycoon
Posts: 982
Joined: 21 Oct 2005 09:26
Location: Birmingham, England

Re: JGR's Patch Pack

Post by 3iff » 21 May 2019 09:13

JGR, Thanks for the comments regarding the road vehicle problems.

jfs, Thanks for the bug report regarding the multiple road bays problem and general pathfinding. While their 'fix' might have improved game performance, it's a backward step when road vehicles suddenly have a degraded performance because they don't 'see' vacant bays. Hopefully they can do something to repair this.

nihues
Engineer
Engineer
Posts: 44
Joined: 13 Jan 2015 10:26

Re: JGR's Patch Pack

Post by nihues » 21 May 2019 11:40

3iff wrote:JGR, Thanks for the comments regarding the road vehicle problems.

jfs, Thanks for the bug report regarding the multiple road bays problem and general pathfinding. While their 'fix' might have improved game performance, it's a backward step when road vehicles suddenly have a degraded performance because they don't 'see' vacant bays. Hopefully they can do something to repair this.
I've changed to old pathfinder too and that way works without problems... hopefully they fix or rollback this performance fix because as I see, it's now a gameplay bug as vehicles don't use all avaliable slots.

User avatar
SciFurz
Engineer
Engineer
Posts: 53
Joined: 13 Oct 2018 16:33
Contact:

Re: JGR's Patch Pack

Post by SciFurz » 22 May 2019 00:19

nihues wrote:
3iff wrote:JGR, Thanks for the comments regarding the road vehicle problems.

jfs, Thanks for the bug report regarding the multiple road bays problem and general pathfinding. While their 'fix' might have improved game performance, it's a backward step when road vehicles suddenly have a degraded performance because they don't 'see' vacant bays. Hopefully they can do something to repair this.
I've changed to old pathfinder too and that way works without problems... hopefully they fix or rollback this performance fix because as I see, it's now a gameplay bug as vehicles don't use all avaliable slots.
I noticed the queueing behavior while testing my patch with increased industry production and alleviated it for the most part by placing a separate station in front of the real loading/unloading bays to act as a waypoint (with orders disabling loading and unloading and optionally a short wait time).
It seemed the short distance between waypoint and bays was enough to have the pathfinder switch to empty stations most of the time. At the time I had also set saturation of short paths to 30% but I don't think that made a real difference.
Tinkering in the code in between writing mostly naughty stuff.
See https://www.patreon.com/scifurz

McZapkie
Tycoon
Tycoon
Posts: 1175
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by McZapkie » 22 May 2019 10:50

Cargo-related distribution settings are accessible only in single-player mode,
these settings are absent in settings list before game launch, and grayed-out in multiplayer client.
Is there any command-line to adjust these settings for multiplayer server?
My experimental openTTD server: 149.156.194.203:3979 non-standard client, now testing: JGRPP http://tiny.pl/ggnch
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, preindustrial houses, wired, ECS industry extension, V4 CEE train set.
Addicted to freeciv longturn.

Eddi
Tycoon
Tycoon
Posts: 7368
Joined: 17 Jan 2007 00:14

Re: JGR's Patch Pack

Post by Eddi » 22 May 2019 20:45

SciFurz wrote:(with orders disabling loading and unloading and optionally a short wait time)
sounds like "go via" orders would be more appropriate here?
You might not exactly be interested in Ferion, but if you are, have fun :)

User avatar
JGR
Tycoon
Tycoon
Posts: 1935
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 23 May 2019 21:23

SciFurz wrote:I noticed the queueing behavior while testing my patch with increased industry production and alleviated it for the most part by placing a separate station in front of the real loading/unloading bays to act as a waypoint (with orders disabling loading and unloading and optionally a short wait time).
It seemed the short distance between waypoint and bays was enough to have the pathfinder switch to empty stations most of the time. At the time I had also set saturation of short paths to 30% but I don't think that made a real difference.
A few possible ideas:
  • Iff the target station has more than one usable road stop tile, don't use the path cache when within a certain radius of the station centre (spread setting + some constant).
  • Invalidate all road vehicle path caches when the road layout is changed in any way.
  • Or, a more targetted fix, invalidate all road vehicle caches when the road vehicle is changed in any way *except* changes which simply lengthen or shorten a dead-end/leaf node piece of road (this is mainly so that town growth doesn't constantly require invalidating all the path caches).
McZapkie wrote:Cargo-related distribution settings are accessible only in single-player mode,
these settings are absent in settings list before game launch, and grayed-out in multiplayer client.
Is there any command-line to adjust these settings for multiplayer server?
The settings are accessible by name using the console as linkgraph.distribution_per_cargo[0] to linkgraph.distribution_per_cargo[63].
They are not accessible outside of a game as the mapping of (NewGRF) cargoes to cargo IDs is not fixed.

Perhaps there needs to be a way for a particular client to be authorised to make general changes to the game settings (not just the server itself).
It seems like something that would be useful for admins of dedicated servers.
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

User avatar
SciFurz
Engineer
Engineer
Posts: 53
Joined: 13 Oct 2018 16:33
Contact:

Re: JGR's Patch Pack

Post by SciFurz » 26 May 2019 16:02

Eddi wrote:
SciFurz wrote:(with orders disabling loading and unloading and optionally a short wait time)
sounds like "go via" orders would be more appropriate here?
I hadn't even noticed the via options under the non-stop button. :-p
But, when the order is set to via, there's no option to set a wait time on it so then having a vehicle wait just long enough for previous vehicles to reach loading bays won't be possible. This needs more testing to see how effective it really is anyway.

This also makes me think about if it's possible to create a parking space for vehicles where they could wait until it's their turn. Traffic lights for vehicles, just like signals for trains might be an idea.
Tinkering in the code in between writing mostly naughty stuff.
See https://www.patreon.com/scifurz

User avatar
JGR
Tycoon
Tycoon
Posts: 1935
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR » 26 May 2019 17:37

SciFurz wrote:I hadn't even noticed the via options under the non-stop button. :-p
But, when the order is set to via, there's no option to set a wait time on it so then having a vehicle wait just long enough for previous vehicles to reach loading bays won't be possible. This needs more testing to see how effective it really is anyway.

This also makes me think about if it's possible to create a parking space for vehicles where they could wait until it's their turn. Traffic lights for vehicles, just like signals for trains might be an idea.
There is a traffic light patch which has been in a few patch packs over the years (not this one), but realistically it was decorative rather than useful.

In any case I've adjusted the caching of road vehicle paths such that pathfinding to multiple destination station tiles/entrances and road layout changes should be handled in a more useful manner. This will be in the next release.
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

User avatar
kamnet
Moderator
Moderator
Posts: 6606
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: JGR's Patch Pack

Post by kamnet » 26 May 2019 17:55

JGR wrote:
SciFurz wrote:I hadn't even noticed the via options under the non-stop button. :-p
But, when the order is set to via, there's no option to set a wait time on it so then having a vehicle wait just long enough for previous vehicles to reach loading bays won't be possible. This needs more testing to see how effective it really is anyway.

This also makes me think about if it's possible to create a parking space for vehicles where they could wait until it's their turn. Traffic lights for vehicles, just like signals for trains might be an idea.
There is a traffic light patch which has been in a few patch packs over the years (not this one), but realistically it was decorative rather than useful.

In any case I've adjusted the caching of road vehicle paths such that pathfinding to multiple destination station tiles/entrances and road layout changes should be handled in a more useful manner. This will be in the next release.
I'd love to see the day when somebody manages to create a patch that implements 2/3/4-way stop/yield intersection management on roads.

User avatar
SciFurz
Engineer
Engineer
Posts: 53
Joined: 13 Oct 2018 16:33
Contact:

Re: JGR's Patch Pack

Post by SciFurz » 28 May 2019 01:11

kamnet wrote:I'd love to see the day when somebody manages to create a patch that implements 2/3/4-way stop/yield intersection management on roads.
Can you wait until I've completed the last bits on my realtime patch? ;-)
Although I might be tempted to give diagonal roads a shot first. If it's possible with trains, maybe a lot of the code can be reused for roads?
Tinkering in the code in between writing mostly naughty stuff.
See https://www.patreon.com/scifurz

User avatar
SciFurz
Engineer
Engineer
Posts: 53
Joined: 13 Oct 2018 16:33
Contact:

Re: JGR's Patch Pack

Post by SciFurz » 28 May 2019 01:24

JGR wrote:There is a traffic light patch which has been in a few patch packs over the years (not this one), but realistically it was decorative rather than useful.

In any case I've adjusted the caching of road vehicle paths such that pathfinding to multiple destination station tiles/entrances and road layout changes should be handled in a more useful manner. This will be in the next release.
Decorative would save the graphics coding part already. I might just have a look for fun without actual coding since I'm not done tinkering with the realtime yet.

I suspect there's a lot that can be improved on the pathfinder. One thing I'd like to see is trains reverse automatically when a better direction is possible. Now they just keep going forward while they could stop at a side track, then reverse to continue into the coreect direction (no detection of a split junction behind the train). Think shunting on a parallel line with two exits instead of a perpendicular line with a left and right turn towards the main line. Tried to get something working with route restrictions but the trains behaved weird.
Tinkering in the code in between writing mostly naughty stuff.
See https://www.patreon.com/scifurz

User avatar
kamnet
Moderator
Moderator
Posts: 6606
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: JGR's Patch Pack

Post by kamnet » 28 May 2019 03:25

SciFurz wrote:
kamnet wrote:I'd love to see the day when somebody manages to create a patch that implements 2/3/4-way stop/yield intersection management on roads.
Can you wait until I've completed the last bits on my realtime patch? ;-)
Although I might be tempted to give diagonal roads a shot first. If it's possible with trains, maybe a lot of the code can be reused for roads?
As much as diagonal roads would be amazing, me personally, I'm okay with not having them quite yet. There are a TON of things that will need sorted out for that, especially since we just got support for up to 64 road/tram types. Set coders are going to be busy enough filling that demand before going back and revamping to cope with diagonal roadways.

Meanwhile, intersection signals and signs would be much more interesting to me. ;)

User avatar
einsteinyh
Engineer
Engineer
Posts: 34
Joined: 15 Feb 2016 01:22
Location: Bogotá

Re: JGR's Patch Pack

Post by einsteinyh » 01 Jun 2019 17:45

kamnet wrote:
SciFurz wrote:
kamnet wrote:I'd love to see the day when somebody manages to create a patch that implements 2/3/4-way stop/yield intersection management on roads.
Can you wait until I've completed the last bits on my realtime patch? ;-)
Although I might be tempted to give diagonal roads a shot first. If it's possible with trains, maybe a lot of the code can be reused for roads?
As much as diagonal roads would be amazing, me personally, I'm okay with not having them quite yet. There are a TON of things that will need sorted out for that, especially since we just got support for up to 64 road/tram types. Set coders are going to be busy enough filling that demand before going back and revamping to cope with diagonal roadways.

Meanwhile, intersection signals and signs would be much more interesting to me. ;)
Maybe those diagonal crossings could be implemented by forcing roundabouts or something similar?

McZapkie
Tycoon
Tycoon
Posts: 1175
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by McZapkie » 01 Jun 2019 22:05

Nice that articulated vehicles can overtake, but if their speeds are near the same, they block the road (well, it is realistic syndrome, but annoying).
Is it possible to check speed difference and allow overtake is it, at least let say, 25% ?
My experimental openTTD server: 149.156.194.203:3979 non-standard client, now testing: JGRPP http://tiny.pl/ggnch
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, preindustrial houses, wired, ECS industry extension, V4 CEE train set.
Addicted to freeciv longturn.

User avatar
romazoon
Tycoon
Tycoon
Posts: 1288
Joined: 20 Jun 2010 23:16

Re: JGR's Patch Pack

Post by romazoon » 02 Jun 2019 09:13

Mc zapkie, i would suggest you to use some speed limit in the timetable to avoid the overtake bloking the roads, that reduce a lot your problem in general as they stop trying to overtake each other then.

and 25% difference is just way more than needed, a truck driving 90km/h can be overtaken by another driving 100km/h, it takes a little time (and might even fail a couple attemps before managing it), but it s enough, and i definitly prefer a truck trying to overtake than staying behind a slower vehicle, cause this will for sure lead to a long queue of vehicle (because rvs can t overtake multiple rvs at once, well i ve seen it happen but it s exceptionnal)

McZapkie
Tycoon
Tycoon
Posts: 1175
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by McZapkie » 02 Jun 2019 13:58

The problem appears when two identical truck are trying to each other overtake (one is loaded an one empty, thus there is slightly speed difference).

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Google Adsense [Bot] and 8 guests