completely shore

[BigBB]

Thanks belugas .

New version (v1.7.1):
- added changes which belugas has mentioned.

[thgergo]

There is a critical problem with the Canyon-flooding. It breaks the nice "Canal on sea level"-feature:
In trunk this feature enables you to build things on see level without getting flooded.

I'm not sure if it is a featur or a bug , but is fixed. Your other points will I fix in a seperate patch, I think this one have enough.


-BigBB

What if the shores can be canal tiles too? It should fix the flooding problem... Also This should be useful for some canal building situlations, like building a nice canal into a canyon without having zigzag effect...

[BigBB]

What if the shores can be canal tiles too? It should fix the flooding problem... Also This should be useful for some canal building situlations, like building a nice canal into a canyon without having zigzag effect...

Nice idea, but not for this patch (it's a shore and not canal patch ).

[lepkka]

BigBB
I've have just noticed your patch, i've waited a long time for 05 0D support in OTTD!!
I really appreciate your work!
Thanks!!

[BigBB]

BigBB
I've have just noticed your patch, i've waited a long time for 05 0D support in OTTD!!
I really appreciate your work!
Thanks!!

Your beautiful NewGRF is the reason why I wrote this patch so all glory is yours . But OTTD supports already action 05-0D but ignore corner-shores, however I fixed it and a few other problems like the dock ground which (with my patch) will be changed into the NewGRF-shore one.

I thank you for your nice work (I know how hard it is to draw sprites, program is easy (relativ, for me) ).

[Ammler]

Hi BigBB and Lepkka

Nice work with water. BigBB, I am pretty sure you know the problem with halftile, but just to remember you I added the screen.

Greets
Ammler

[Aegir]

The same thing happens in TTDPatch. My guess is that it's just a limitation of the feature.

Also, has this hit OpenTTD trunk yet? Would be nice to see it included.

[osai]

Also, has this hit OpenTTD trunk yet? Would be nice to see it included.

Yep. Quite silently though.
Osai

[Aegir]

Also, has this hit OpenTTD trunk yet? Would be nice to see it included.

Yep. Quite silently though.
Osai

Odd, r11397 doesn't appear to have it, and I see no mention in the svn.openttd.org history.

[belugas]

It will hit trunk <Kinda> soon, before 0.6 release.
But let say that Real Life and other projects started before are in the way for the inclusion.
So, be patient and it will be in.

[Aegir]

It will hit trunk <Kinda> soon, before 0.6 release.
But let say that Real Life and other projects started before are in the way for the inclusion.
So, be patient and it will be in.

That's more than understandable, Belugas. I can sympathise entirely.

[BigBB]

BigBB, I am pretty sure you know the problem with halftile, but just to remember you I added the screen.

Yes I'm rembered it.
Will be fixed after intregation of my patch. This needs a modification of the existing halftile-code.
This two tiles won't be supported by action 05-0D and Oskar/lakie don't want to intregate it. I have a few ideas to intregate it anyway, but in an other patch, too.

The same thing happens in TTDPatch. My guess is that it's just a limitation of the feature.

That's right, because it isn't in NewGRF action 05-0D .

Also, has this hit OpenTTD trunk yet? Would be nice to see it included.
[...]
Odd, r11397 doesn't appear to have it, and I see no mention in the svn.openttd.org history.

As soon as Belugas have time (They have a life behind OTTD).

Regards,
BigBB

[frosch]

I found some time to code, what I had promised:

draw shore under tracks

halfshore.png (35.56 KiB) Viewed 4779 times

I'm not sure, what to do in the following situation (left or right). Currently it behaves like on the right hand side:

draw shore on top of anti-zig-zag foundation

floodantizigzag.png (8.47 KiB) Viewed 5395 times

The attached patch is meant to be applied on top of the completly_shore patch. It does not increase the save game version another time, but loading a game from this patch without this patch will cause assertions.

[Leviath.NL]

Very nice work! , how trunk ready do you think this patch is?
I'd prefer, the left situation, to not have shore on the foundations.

edit: oops

[Mchl]

You really might want to edit your last sentence

And to stay on topic: I prefer current (one on the right) behaviour.

[BigBB]

Nice work frosch, looks good.

I used atm your halftile code to solve the problem with shore on SLOPE_EW and SLOPE_NS :





I prefer the right one with shore, the left one looks ugly:

[athanasios]

Me too (right).

[Acerbus]

I'd also go for the right version,

Btw, good thinking with the SLOPE_EW and SLOPE_NS problem, BigBB!

[Digitalfox]

Right version, no doubt..
It looks a lot better IMHO

[Digitalfox]

Deleted by me