completely shore

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

completely shore

Post by BigBB »

Lepkka made a beautiful NewGRF to replace the water and shores link.

But OpenTTD don't support corner shores so the grf looks ugly (see pic.).

(temperate, sub-arctic, sub-tropical and toyland; without and with Lepkka's grf)
Image


So I decided to make a patch to solve this problem (full action 05 0D support). Without a water-NewGRF will be still normal grass-tiles shown, but with a grf the corner have shores (see pic.).

(temperate, sub-arctic, sub-tropical and toyland; without and with Lepkka's grf)
Image


- he docks have now with a NewWater NewGRF the shore spirit from this grf (see pic)
- and bridgeheads next to a shore tile have now shore ground tiles (see pic)
Image


- bridgeheads on shore can flood their neighbours too
- corner shores only floods if a NewWater grf loaded (but if you deactivate this grf, the corner shores will not removed)

- industry shore tiles change their spirit if a NewWater NewGRF loaded (see pic)
Image



Have fun,
BigBB
Attachments
completely_shore_v1.7.1_r11347.patch
(25.73 KiB) Downloaded 432 times
Last edited by BigBB on 26 Oct 2007 21:16, edited 18 times in total.
OpenTTD-patch(es) in development: missing shores (new version of: completely shore), road lamps for each position
Leviath.NL
Traffic Manager
Traffic Manager
Posts: 152
Joined: 28 Jan 2006 15:00

Re: completely shore

Post by Leviath.NL »

I think you have to post more information about how your patch works. Right now people can only guess what's going wrong.
User avatar
Digitalfox
Chief Executive
Chief Executive
Posts: 704
Joined: 28 Oct 2004 04:42
Location: Catch the Fox if you can... 15 years and counting!

Re: completely shore

Post by Digitalfox »

BigBB i just had to say, that what you are trying to fix, is something that annoys me a lot.. :(

Since i also use lepkka's NewWater NewGRF.. :wink:

Good luck :D
BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

Re: completely shore

Post by BigBB »

Leviath.NL wrote:I think you have to post more information about how your patch works. Right now people can only guess what's going wrong.
The patch isn't in a stadium to release it. However, I have found and fixed the problem and now lepkka's NewWater works errorless.


Edit: add pics, only for post one
Attachments
original OTTD
original OTTD
original.png (56.33 KiB) Viewed 24553 times
with my patch
with my patch
with_my_patch.png (54.77 KiB) Viewed 24536 times
flood fix
flood fix
flooding.png (12.01 KiB) Viewed 19351 times
Last edited by BigBB on 13 Oct 2007 17:48, edited 2 times in total.
User avatar
Digitalfox
Chief Executive
Chief Executive
Posts: 704
Joined: 28 Oct 2004 04:42
Location: Catch the Fox if you can... 15 years and counting!

Re: completely shore

Post by Digitalfox »

BigBB wrote:
Leviath.NL wrote:I think you have to post more information about how your patch works. Right now people can only guess what's going wrong.
I have found and fixed the problem and now lepkka's NewWater works errorless.
Great :shock: :D
BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

Re: completely shore

Post by BigBB »

I have one problem: if you build a railway on an upper part of a corner slope the coast will be removed.

Image

This is a problem for TTD-Patch too (tested with r1759). So I don't know if it is a NewGRF problem or not. Maybe anybody with NewGRF-experience can help?

Thanks,
BigBB
OpenTTD-patch(es) in development: missing shores (new version of: completely shore), road lamps for each position
User avatar
XeryusTC
Tycoon
Tycoon
Posts: 15415
Joined: 02 May 2005 11:05
Skype: XeryusTC
Location: localhost

Re: completely shore

Post by XeryusTC »

That is more a limitation in the sprite that is being used. There is a special sprite for these kinds of slopes with a rail on it IIRC, and the water set only adds (or replaces, but adds seems more likely) an extra sprite for the coast tile without the rail.
Don't panic - My YouTube channel - Follow me on twitter (@XeryusTC) - Play Tribes: Ascend - Tired of Dropbox? Try SpiderOak (use this link and we both get 1GB extra space)
Image
OpenTTD: manual #openttdcoop: blog | wiki | public server | NewGRF pack | DevZone
Image Image Image Image Image Image Image
BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

Re: completely shore

Post by BigBB »

Ah, thanks XeryusTC.
OpenTTD-patch(es) in development: missing shores (new version of: completely shore), road lamps for each position
BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

Re: completely shore

Post by BigBB »

It's now downloadable (see first post). Full action 05 0D support and a flood fix.

Have fun,
BigBB
OpenTTD-patch(es) in development: missing shores (new version of: completely shore), road lamps for each position
Loop
Engineer
Engineer
Posts: 72
Joined: 10 Apr 2006 21:05
Location: Poznan, Poland

Re: completely shore

Post by Loop »

Wow, this is great! Good job!
Last edited by Loop on 13 Oct 2007 19:31, edited 1 time in total.
User avatar
Digitalfox
Chief Executive
Chief Executive
Posts: 704
Joined: 28 Oct 2004 04:42
Location: Catch the Fox if you can... 15 years and counting!

Re: completely shore

Post by Digitalfox »

WOW great job BigBB :shock: :D

I really hope this get's in trunk :P
Snuk the Great
Engineer
Engineer
Posts: 63
Joined: 26 Aug 2005 15:12

Re: completely shore

Post by Snuk the Great »

Just simply awesome!
Snuk the Great
User avatar
belugas
OpenTTD Developer
OpenTTD Developer
Posts: 1507
Joined: 05 Apr 2005 01:48
Location: Deep down the deepest blue
Contact:

Re: completely shore

Post by belugas »

It's on my radar.
Lots of goodies (comments)
Nice work (again)
If you are not ready to work a bit for your ideas, it means they don't count much for you.
OpenTTD and Realism? Well... Here are a few thoughs on the matter.
He he he he
------------------------------------------------------------
Music from the Bloody Time Zones
BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

Re: completely shore

Post by BigBB »

New version (v1.1):
- replaced all TILE_ADD() with TileAddByDiagDir()
- removed all magic numbers
- many small changes

Thanks to skidd13 for his suggestions.

Edit: update to r11266
OpenTTD-patch(es) in development: missing shores (new version of: completely shore), road lamps for each position
boekabart
Transport Coordinator
Transport Coordinator
Posts: 333
Joined: 25 Aug 2005 09:44
Location: Eindhoven, Netherlands

Re: completely shore

Post by boekabart »

1) I personally don't like the fact that flooding also changes for games without newwater.
2) It's not turning completely into shore, see png
Attachments
NotTotallyFlooding.png
NotTotallyFlooding.png (43.15 KiB) Viewed 18454 times
BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

Re: completely shore

Post by BigBB »

boekabart wrote:It's not turning completely into shore, see png
Fixed (v1.2).

Todo list:
- Change ground tiles for bridges and docks
bug2and4.png
bug2and4.png (20.13 KiB) Viewed 18335 times
- fix railway on corner-shores
bug.png
bug.png (3.62 KiB) Viewed 19450 times
- BigBB
OpenTTD-patch(es) in development: missing shores (new version of: completely shore), road lamps for each position
boekabart
Transport Coordinator
Transport Coordinator
Posts: 333
Joined: 25 Aug 2005 09:44
Location: Eindhoven, Netherlands

Re: completely shore

Post by boekabart »

Very well, I hope you can get that done too!

About the 'canyon flooding': as long as it's not an option in the grf file - I'd definitely make it a patch option to change the flooding behavior like this - not everyone will like it (me! pick me!).....
User avatar
athanasios
Tycoon
Tycoon
Posts: 3138
Joined: 23 Jun 2005 00:09
Contact:

Re: completely shore

Post by athanasios »

No canyon flooding please. It will steal our money when landscaping. :mrgreen:
http://members.fortunecity.com/gamesart
"If no one is a fool I am also a fool." -The TTD maniac.


I prefer to be contacted through PMs. Thanks.
Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: completely shore

Post by Mchl »

Who said landscaping should be cheap?

But I also think ot should be an option, as it is diffirent from original TTD behaviour.
BigBB
Engineer
Engineer
Posts: 106
Joined: 07 Aug 2007 20:39

Re: completely shore

Post by BigBB »

New version (v1.3) uploaded:
  • forgot in the last version, that next to a bridge a second, third, ... bridge can be ... fixed
  • the docks have now with a NewWater NewGRF the shore spirit from this grf (see pic)
  • and bridgeheads next to a shore tile have now shore ground tiles (see pic)
dock_bridge-ground.png
dock_bridge-ground.png (38.71 KiB) Viewed 23090 times
The fix for the railway on corner-shore-tiles will be fix by frosch, to minimize the overlapping between my patch and his halftile foundations patch.

-BigBB
OpenTTD-patch(es) in development: missing shores (new version of: completely shore), road lamps for each position
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 9 guests