[Patch] Watch Other Companies GUI

[Muxy]

[..]

[Muxy]

[..]

[Yexo]

I got a lot of compile errors so it didn't even get to a linking stage. This might be because I applied it to r17734 though.

My best guess at the reason for that error is because you declare WatchWindow twice. Try declaring it once in a header file and then just implementing the functions in smallmap_gui.cpp instead of duplicating the definition.

[Muxy]

[..]

[Muxy]

[..]

[Muxy]

[..]

[Muxy]

[..]

[Muxy]

[..]

[petert]

I got these errors (against 0.7.4) when making.

[Muxy]

[..]

[Muxy]

[..]

[petert]

Hello,

Just updated the diff file.

The two files watch_gui.h & watch_gui.cpp were missing.

Is this for the new release, OpenTTD 1.0.0-beta1?

[WWTBAM]

If this was updated for nightly versions, I could see a potential pthe use for this patch if combined with an older patch that allows OpenTTD to be run as a windows screensaver.

[Muxy]

[..]

[petert]

I got an error when trying to compile your patch against 1.0.0-beta3:

Code: Select all

3>command.obj : error LNK2001: unresolved external symbol "public: void __thiscall WatchCompany::OnDoCommand(struct TinyEnumT<enum Owner>,unsigned int)" (?OnDoCommand@WatchCompany@@QAEXU?$TinyEnumT@W4Owner@@@@I@Z)
3>toolbar_gui.obj : error LNK2001: unresolved external symbol "void __fastcall ShowWatchWindow(enum Owner)" (?ShowWatchWindow@@YIXW4Owner@@@Z)
3>..\objs\Win32\Release\\openttd.exe : fatal error LNK1120: 2 unresolved externals

[Muxy]

[..]

[petert]

I've managed to get it compiling on MSYS. I've also made a diff with the changes to the vcprojects included.

Also, I thought it was funny that you can use the watch gui on the main screen

[petert]

Ok, the MSVC compile now works on my system with watch GUI. You can find 0.7.5 binaries at my dev site: http://users.tt-forums.net/petert/dev/Watch_GUI/

[Muxy]

[..]

[Ammler]

Hello

Might it be possible to make (and use for releases) a bit less "cheatish" version of that patch. Something like

- only watch other companies with rcon
- only watch unpassworded companies
- everybody can only watch the own company

I am fully aware someone could still patch it to use with the features you have already. But somehow the way to do it should be made a bit harder. At least no easy access to binaries.

I guess, from develpment view, there is no possibility to make something against this feature.

Don't get me wrong, it is a nice patch, we use this kind already quite some time on #openttdcoop too. But for competition games, it is a simply cheat, specially if not everyone has access to that patch.

Greets
Ammler