More height levels (in trunk since r27010)

[2007Alain2007]

to change snow level to more then 13

you got to change the openttd config

[ChillCore]

That works, untill you use them little up / down arrows, or use the keybord.
If you do you are again limited to level 13.

There is some work left to do on newgame creation.
Terkhen has coded his patch to be used in scenario editor.
We should do the same for newgame creation.
However, untill I figure out how exactly newgrf handle varying snowline I do not wish to mess about with that setting too much...

If whenever you are limited in snowlevel selection by pushing the arrows or using the keybord, you can do the following.

- Create a scenario with desired snowlevel height.
- Return to gamemenu.
- Start new game without touching the snowlevel option.

That will work faster than exiting the game and restarting it to allow your config file to be reloaded ...

[2007Alain2007]

Also i been useing the snow in temp patchs that works realy nice with this but would be nice to be able to pick the snow level on all climit

my speeling might be wrong there

[ChillCore]

It's a small step for OTTD, its a giant leap for ChillCore ....

As of v12 the moreheightlevelspatchs needs a newgrf to function:
flat_blacktiles.grf
Mikeel has been so kind to draw us some black tiles (19 sprites) and i finally managed to get them into the game.

Please put the grf in the data folder. (not the newgrf folder). It should be loaded automatically with the patched OpenTTD. Maybe you could put it in your shared folder but i have not tested this yet.

( EDIT:
- tested and shared folder works also.
- corected some info in the previous alinea
/EDIT )

Failing to put the grf in the correct location will cause the patch to fail at startup.

Attached is the new patch, and the zip containing the nfo, the pcx and the coded grf(windows)
Do I make a dos version also?

@ic111:
Could you please attach v12 and the grf to the first post stating the grf is needed for v12 and later.
Could you please also state there that the latest version of the patch is to be found near the end of the thread. (to avoid you having to update first post over and over)

[HackaLittleBit]

Nice!

Please put the grf in the same folder as where your OpenTTD.exe is. (not the data folder). It should be loaded automatically with the patched OpenTTD

I just put flat_blacktiles.grf in data folder and it worked

Anyhow it looks good.

[mikeel]

that's a great news! it seems that all the glitches are now fixed, is it right?

[ChillCore]

I just put flat_blacktiles.grf in data folder and it worked

My misstake, that should have been "in the data folder not in the newgrf folder."
Post corected.

that's a great news! it seems that all the glitches are now fixed, is it right?

Looks like it. Unless someone finds some more glitches.
Thank you again for those sprites.
Can i add a gpl liscence to them ?
(free to use when and however and so on)
Maybe they can be of some use for somebody else in the future ...



Thank you once again for your kind words.

[mikeel]

hope the patch go in the trunk
No problem with gpl license. They are simply black tiles, in the end.

[ChillCore]

hope the patch go in the trunk

We can only hope that some day ...
Quite honestly i do not want to know right now if it will or not.

I can only try my best at making it as good as it can get. (Toghether with ic111)
Once all bugs are fixed (including coding style and comments in code)

I shall have a look at which terrain-type options I need to disable and declare the patch finished (at least good enough for inclusion in trunk).

At that point we can only hope that some Dev has the patience and the courage to go trough the patch and ...

That is where playtesters come in.
The patch has to be proven stable first.
I did see a lot of terrain untill now but i did not really playtest
Its one or the other, or play or code.

No problem with gpl license. They are simply black tiles, in the end.

Good I was afraid i had to redo them.

[Vitus]

Got a little problem with this patch.

I'm not sure where you'll be able to reproduce it, but this is how I've done it:
Start with "New game", sub-arctic, set the size to 1024x1024, terrain type to alpinist, sea level to medium, smoothness cereally rough and freeform edges. The game then should crash during the generation of map.

Just to be sure: I used default .cfg with the 16+ levels enabled, of course. 1139835451 was the seed number.

Anyways, it's really wondeful patch. Thanks!

[ChillCore]

I could not reproduce that one.

Did the assert complain about mapsize in tile_map.h line 52 ?
If so i can make some wild guesses but i really have no idea what triggers that one yet.(it has to do with borders.

If it happens again could you please write down the assert.

ps:
I am glad you like what you see.

[Vitus]

Did the assert complain about mapsize in tile_map.h line 52 ?

Yes, exactly this one.

Here's the screenshot. Attached the settings just in case I missed something.

[2007Alain2007]

Can we be able to incress the snow levels in game on all wourlds please becuse max snow line is still 15

[ChillCore]

Here's the screenshot. Attached the settings just in case I missed something.

I attached the latest logfile.
Please read the known bugs and the todo list.
The logfile was a bit hidden a few posts back.
If you find any other bugs or know how to fix one i will be more than happy to hear it.
Thank you for testing, and taking the time to report bugs.

Can we be able to incress the snow levels in game on all wourlds please becuse max snow line is still 15

Is the snowlevel lmited in scenario editor also?

Climates that have snow in them will have the snowlevel increased.
Climates that do not have snow in them will not be changed by this patch.

For the snowlevel on newgamecretion: Be patient please, all in due time.
Not untill i know what i do and what effect it will have.

[2007Alain2007]

I tested with high snow levels and nothing i could see changed

[ChillCore]

Sorry Alain, cannot reproduce your problem.
see attachment.

[HackaLittleBit]

I could not reproduce that one.

I could! ChillCore change climate to arctic

[CommanderZ]

I could not reproduce that one.

I could! ChillCore change climate to arctic

Do you have the last release of the patch?

[planetmaker]

to what I found, version 12 is the latest one of this patch? I really feel like testing it again - it's a nice feature IMO

[ChillCore]

About that crash in line 52:
Changing the climate does the trick.
We have now a reproducable crash, Thank you vitus.
That will help in debugging big time.

@Planetmaker.
v12 is the latest version. I will post binaries soon.
I am now at revision 16350 and there is a few things i want to revieuw first.

If you must test now you can get the previous version still ...
I only changed minor things besides those blacktiles.