Patch: change finances window grouping

[jawsper]

Hi all this is my first finished and working patch

To the point: I wasn't really happy with the way the new grouping works in the finances window, I'd want it like this:


So I set off to work and made it work.

Here is what I did to the settings window: http://hostmysite.nl/Jawsper%20Inc.,%202581-02-24_1.png

Changed:

• Added 3 entries to the language file
• Added new list format to finances gui
• Changed the setting "gui.expenses_layout" from a bool to a var. You probably need to change/remove that line from openttd.cfg to make this work!

I hope you like my first contribution.

Also hope i made the patch files work properly


Update 5th of may 2009: Updated the file to one diff and made it r16183

Update 28th of october 2009 (wow it's been that long!): Updated to r17895

[CommanderZ]

This makes sense

Btw, you should put all the changes into one patch file. One diff can patch multiple source files.


And welcome to TT-Forums

[jawsper]

Well I tried to make one diff file, but Tortoise didn't want me to create a patch on a folder, so I made 3 patches and modified them to the right directory. I was going to merge the 3 diffs, but I was too afraid to break them


EDIT: Moved to first post

[Noldo]

I love this!

Another subtotal for operating profit and it's perfect.

[ever]

Well someone is obviously not an accountant.

[jawsper]

I'd add operating profit, but I have no clue what that is

[FooBar]

The "Operating Profit" is IMO already available: it's the last grand total...

I like this setup of the finance window!

[Noldo]

Always great to use the wrong terms. Anyway the subtotal that I would like to follow would include everything else but not Construction, New Vehicles and Loan interest (and maybe Other). So the incomes, running costs and property maintenance would be included.

This number would tell how much money is coming in without player intervention.
Also the effect of player action in from contructing and new vehicles is divided somewhat randomly between years so the big total doesn't really tell that much about how the company did on a specific year.

[jawsper]

I hope this is what you meant with operational profit

Also updated to r16410.

Will move this patch to first post after I decide what to actually call the selection "operational profit"

[Wasila]

I don't konw if this is what he meant..but what about turnover? Turnover = overall money made before any expenses, even running costs.

[jawsper]

Updated to r17895 in first post

Edit: whoops! That last patch was messy, updated it

[Lord Aro]

yes i know it's a bump but is it me or did this get added to trunk?

[petert]

yes i know it's a bump but is it me or did this get added to trunk?

I can see why you are confused. There is already a group finances, but this patch changes the settings there. Look at this link:

http://hostmysite.nl/Jawsper%20Inc.,%202581-02-24_1.png

[Lord Aro]

i see. i didn't look at the pictures close enough

(please shoot me )