Gonozal_VIII patchpack r12180

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
YukonRob
Transport Coordinator
Transport Coordinator
Posts: 290
Joined: 31 Jul 2007 00:58
Location: North of 63

Re: Gonozal_VIII patchpack r12180

Post by YukonRob »

FYI - I am unable to compile these (last couple) patches using C++2005 against the respective trunk revisions. The trunk + YAPP patch does compile however. Your patches do seem to patch properly (errorless) but upon compiling I keep getting a critical flaw with "station.sbr does not exist" (or something like that).
HTH,
Rob
User avatar
^^atte
Engineer
Engineer
Posts: 19
Joined: 15 Feb 2008 20:33

Re: Gonozal_VIII patchpack r12180

Post by ^^atte »

I love this patchpack :D it has almost all that i have wanted but never know how to do it :lol:

but i wonder if you can add: Patch: Disable Random Closing and Opening of Industries ?
http://www.tt-forums.net/viewtopic.php?f=33&t=34310

keep this up :mrgreen:
sc79
Director
Director
Posts: 586
Joined: 22 Feb 2005 09:51

Re: Gonozal_VIII patchpack r12180

Post by sc79 »

Not sure if this is still the case, but trains in r12141M would be wrongly pinned at a negative profit (for the "Train X's profit last year was ____"), despite whatever profit they might actually have.
strange, what patch settings do you use? especially daylength and the daylength affects cargo delivery prices setting
I have the same problem, using a map with ECS vectors, certain cargoes (and only certain ones) simply don't give a vehicle profit when delivered (the network still works, industries still use the delivered product, theres simply no profit for the vehicle). All trains have standard orders, and all others have correct profits. Daylength set to 30.
nautre125
Engineer
Engineer
Posts: 74
Joined: 04 Feb 2008 10:58
Location: Strasbourg, France

Re: Gonozal_VIII patchpack r12180

Post by nautre125 »

for the savegames, it is because of YAPP v4.x

I have another problem, due to the passenger destination patch. nobody comes in my station. A station where there should be a least 50 passenger when the train arrive has no passenger with the pax patch activated.
User avatar
axamentia666
Engineer
Engineer
Posts: 47
Joined: 18 Feb 2008 17:46
Location: Manchester

Re: Gonozal_VIII patchpack r12180

Post by axamentia666 »

Quality patch, definatly now in one of my favourite playable builds!!!

Keep it updated!! :bow:
Heh
jaybud4
Engineer
Engineer
Posts: 116
Joined: 16 Feb 2008 06:13

Re: Gonozal_VIII patchpack r12180

Post by jaybud4 »

Gonozal_VIII wrote:strange, what patch settings do you use? especially daylength and the daylength affects cargo delivery prices setting
Nono, the actual price is fine. It simply displays that horribly negative profit warning at the bottom for every train at the end of every year.
Image
If you're bugged by anything I say/do: Please send me a PM. I don't always watch every thread I post in after I do so.
Forked
Engineer
Engineer
Posts: 43
Joined: 13 Jan 2008 20:36

Re: Gonozal_VIII patchpack r12180

Post by Forked »

sickie wrote:Forked: I love you, hugs and kisses for releasing the binary so quickly. I have a very old notebook right now and it's slower than a snail and because it's evening i wouldn't be able to play tha new version without you.
fluffles :)
sickie wrote:And now to the business: The strangest thing I ever seen in OpenTTD is happening with the r12180 binary from Forked: I just downloaded it and run it. Then I saw something never seen I before; in the opening title screen, the second plane that lands on the airport, crashes. And it happens every time I open r12180 patchpack. here is a screeny of this hilarious (it is to me, at least) event:
I compile the .patch from first post with buildOTTD using the same rev as that patch was created against, I don't test the win32 builds .. usually no time, sorry :\

Has anyone seen this happening for other builds than the one I made?
User avatar
Indiana
Engineer
Engineer
Posts: 36
Joined: 07 Feb 2008 09:15

Re: Gonozal_VIII patchpack r12180

Post by Indiana »

I can't get it running under Deban or Ubuntu.
I tried it with r12141, got the source and appied the patch.
It compiles with 0 errors and 1 warring (something about a variable "best" which could be that it is used uninitilized).
It starts but get stuck while networtdetection.
Have a N.I.C.E. day!
Indiana
User avatar
DanMacK
Tycoon
Tycoon
Posts: 3906
Joined: 27 Feb 2004 20:03
Location: Ontario, Canada
Contact:

Re: Gonozal_VIII patchpack r12180

Post by DanMacK »

I thought the crashing on coasts had been resolved in the latest versions of that patch? (The Sea Level one)

Another cool one to add that's been around awhile is the Diagonal Crossings and AFAIK, it works.
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Gonozal_VIII patchpack r12180

Post by Roujin »

DanMacK wrote:I thought the crashing on coasts had been resolved in the latest versions of that patch? (The Sea Level one)

Another cool one to add that's been around awhile is the Diagonal Crossings and AFAIK, it works.
with which revision it works? With the one it has been last updated to one and a half years ago? then yes. With current trunk? no chance.

(unless someone updated it recently and i'm not aware of it)
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: Gonozal_VIII patchpack r12180

Post by Ammler »

I don't find the Thread about "Trains stop in middle of Station", thats why I post my suggestion here:
Image

I think, on a Terminus Station, the train should stop at the end (head), always.

Greets
Ammler
User avatar
BlueEagle_nl
Transport Coordinator
Transport Coordinator
Posts: 352
Joined: 28 Jan 2006 09:44
Skype: tilly5014
Location: Tillywood, The Netherlands

Re: Gonozal_VIII patchpack r12180

Post by BlueEagle_nl »

That's indeed a pretty good suggestion you make, or to make it possible in the orders to define whether a train should stop in the middle or at the end of the station, with a default value set in the Patches. Perhaps that would be easier to code, I don't know...

Maybe it's even possible to let trains stop so, that it has just entered the station completely, but doesn't stop in the middle or at the end of a station. For example, you would get:

Code: Select all

X = Station track where train stands
- = Regular track
= = Station track which is empty
< and > = Driving Direction

<----======XXXX--------<
>----XXXXX=====-------->
I just got a bundle constructed, for Linux, using the latest version of the patchpack (r12180M), which already includes all necessary files to play. So, just unTar that folder and play. I'll upload it as soon as I get it over at my parent's place, haven't got Internet myself (yet)...
Teeg
Engineer
Engineer
Posts: 55
Joined: 31 Jul 2007 23:57

Re: Gonozal_VIII patchpack r12180

Post by Teeg »

This is going to sound bratty however I phrase it, so I'll bite the bullet.

Has anyone been able to get this to compile properly on Linux? I'm positive I'm doing it properly (the 12180 revision compiles just fine without the patches), but when I try it with the patchpack, OpenTTD won't even open.

Is there some sort of log or record that would be useful in troubleshooting this? I'm running Ubuntu 7.10 (Gutsy).
anboni
Engineer
Engineer
Posts: 23
Joined: 21 May 2006 10:12

Re: Gonozal_VIII patchpack r12180

Post by anboni »

Are you placing the copypaste.grf in the data directory? This pack requires that one.

Other than that, the output from make should tell you if the compile succeeds or not, if there's an error during compile it will usually be just before the prompt (you are compiling from the prompt, right? :) )
Teeg
Engineer
Engineer
Posts: 55
Joined: 31 Jul 2007 23:57

Re: Gonozal_VIII patchpack r12180

Post by Teeg »

Having just run a compile, there are errors. Weird, must have been half-asleep last night.

Code: Select all

/home/mike/Games/openttd/src/roadveh_cmd.cpp: In function ‘uint CalcDistanceOfClosestTownFromTile(TileIndex)’:
/home/mike/Games/openttd/src/roadveh_cmd.cpp:957: warning: ‘best’ may be used uninitialized in this function

Code: Select all

/home/mike/Games/openttd/src/table/unmovable_land.h:8: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:13: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:18: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:23: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:28: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:33: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:38: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:43: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:48: warning: missing braces around initializer for ‘PalSpriteID’
/home/mike/Games/openttd/src/table/unmovable_land.h:53: warning: missing braces around initializer for ‘PalSpriteID’
However, the compile still completes. When it does so, and I try to run openttd from the terminal, I get the following errors:

Code: Select all

Your 'CHARS.GRF' file is corrupted or missing! The file was part of your installation.
Your 'OPENTTDW.GRF' file is corrupted or missing! The file was part of your installation.

ini: ignoring invalid NewGRF 'newgrf/NACityw.grf': not found
Error: No available language packs (invalid versions?)
openttd: /build/matthijs/openttd-0.6.0~beta2/src/openttd.cpp:110: void error(const char*, ...): Assertion `0' failed.
Aborted (core dumped)
The aforementioned newgrf is in place, as are the files "borrowed" from TTDX. The patch itself executes perfectly, without any conflicts.
anboni
Engineer
Engineer
Posts: 23
Joined: 21 May 2006 10:12

Re: Gonozal_VIII patchpack r12180

Post by anboni »

Teeg wrote:

Code: Select all

unmovable_land.h:13: warning: missing braces around initializer for ‘PalSpriteID’
These are just warnings, nothing to worry about.

Code: Select all

Your 'CHARS.GRF' file is corrupted or missing! The file was part of your installation.
Your 'OPENTTDW.GRF' file is corrupted or missing! The file was part of your installation.

ini: ignoring invalid NewGRF 'newgrf/NACityw.grf': not found
Error: No available language packs (invalid versions?)
These errors seem to suggest some files (or maybe just openttd, the binary) aren't in the correct place. This seems somewhat odd, as you mentioned an unpatched trunk compile does start but this patchpack'd version doesn't. I would look into that first though.

I must admit, I haven't done an openttd compile on linux for ages, I'm just being lazy and have BuildOTTD do the heavy lifting for me :)
jaybud4
Engineer
Engineer
Posts: 116
Joined: 16 Feb 2008 06:13

Re: Gonozal_VIII patchpack r12180

Post by jaybud4 »

OPENTTDW.grf suggests that it requires the windows binaries.
Think about it: The W stands for Windows.
Image
If you're bugged by anything I say/do: Please send me a PM. I don't always watch every thread I post in after I do so.
PhilSophus
Chairman
Chairman
Posts: 776
Joined: 20 Jan 2007 12:08
Location: Germany

Re: Gonozal_VIII patchpack r12180

Post by PhilSophus »

jaybud4 wrote:OPENTTDW.grf suggests that it requires the windows binaries.
Think about it: The W stands for Windows.
No, you don't need the windows binary. You need the original data files from either the Windows or DOS version of the original game. OPENTTDW.grf is the right one if you had the Windows data files.

@Teeg:
I don't have problems compiling (and running) it on Gutsy. Did you checkout the sources from SVN? If not OpenTTD has problems determining its version, In this case try giving the --revision option to configure like that:

Code: Select all

configure --revision=r12180
HTH

Edit: Just noticed that it says openttd-0.6.0~beta2 in your directory name. Are you sure you are not mixing versions in some way (i.e 0.6.0~beta2 and trunk r12180)? You don't need anything from 0.6.0~beta2.
If the above doesn't work, just try it the clean way:

Code: Select all

svn checkout -r12180 svn://svn.openttd.org/trunk gono12180
cd gono12180
patch -p0 -i path/to/gonozal_patch_r12180.patch 
./configure && make
# don't forget to copy or link the original game files and copypaste.grf to bin/data
bin/openttd
"The bigger the island of our knowledge, the longer the shore of our ignorance" - John A. Wheeler, Physicist, 1911-2008
jaybud4
Engineer
Engineer
Posts: 116
Joined: 16 Feb 2008 06:13

Re: Gonozal_VIII patchpack r12180

Post by jaybud4 »

PhilSophus wrote:
jaybud4 wrote:OPENTTDW.grf suggests that it requires the windows binaries.
Think about it: The W stands for Windows.
No, you don't need the windows binary. You need the original data files from either the Windows or DOS version of the original game. OPENTTDW.grf is the right one if you had the Windows data files.
But see Openttdw.grf is not part of the original game.
And the W still stands for Windows; but we're talking about Linux...
So in effect the problem is that it's calling for the Windows data files which aren't available because it's a Linux system.
Image
If you're bugged by anything I say/do: Please send me a PM. I don't always watch every thread I post in after I do so.
User avatar
sickie
Engineer
Engineer
Posts: 85
Joined: 15 Sep 2007 00:51
Location: Slovenia
Contact:

Re: Gonozal_VIII patchpack r12180

Post by sickie »

Well, well, jaybud4. It seems you are confused about *.grfs. They are not build for every OS OpenTTD runs on, there are DOS and Windows version of them, and which one someone would use is based on the fact if one have Windows or DOS version of TTD's (original) .grfs, regardless of the platform you are running OpenTTD on. If one downloads the GNU/Linux binary, one does find in data dir both openttdd.grf and openttdw.grf. And no openttdl.grf. It has nothing to do with OpenTTD's binary at all.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 7 guests