[UNIV] ISR - Industrial Stations Renewal

[Phreeze]

finally my efforts into the Lux.-Translation is in

[Trond]

Well, Ive been wondering again

I dont like the look of the monorail nor maglev tracks in the game, so I downloaded the metro tracks (http://www.tt-forums.net/viewtopic.php?t=49476). But the tracks doesnt change on the ISR stations... Any chance that could be worked out, or do you mabye have knowledge of another set of tracks that does work?

[mart3p]

I dont like the look of the monorail nor maglev tracks in the game, so I downloaded the metro tracks (http://www.tt-forums.net/viewtopic.php?t=49476). But the tracks doesnt change on the ISR stations... Any chance that could be worked out, or do you mabye have knowledge of another set of tracks that does work?

ISR currently only supports the Metro tracks used as additional railtypes, not as replacement of monorail or maglev.

I hadn't realised replacement of monorail or maglev was possible with the Metro track set, thanks for pointing it out. I will add support for this, it's now on my todo list.

[George]

I've downloaded the latest nightly version of OpenTTD (r26228) and in my savegames with ISR 0.9.2 station randomisation is lost.

[mart3p]

I've downloaded the latest nightly version of OpenTTD (r26228) and in my savegames with ISR 0.9.2 station randomisation is lost.

Hi George, thanks for the bug report. I can confirm that there is a problem:

randomise_bug_1.png (64.28 KiB) Viewed 8349 times

It only seems to effect some stations though. In my screenshot the fruit station is no longer randomised but the goods station is ok, although the crawler crane has disappeared.

But this must be caused by some change in OpenTTD, I don’t think it's an ISR bug. I will investigate further.


Edit:
The goods station sprites are selected by a random action 2 that directly selects from different sprite sets. The fruit station spites are selected by setting a temporary register value with a randomly selected sprite offset. This register is used to select the sprites in the sprite layout (station property 1A). So I think the problem is with temporary registers rather than the randomisation.

I’ve also tried 1.4.0-beta1 and it has the same problem. It looks like this needs an OpenTTD bug report…


Edit:
Bug report #5852 added to Flyspray.

[keoz]

I also have some strange behaviours on ISR, since some releases (I couldn't tell which).

As an example:

KelTransport, 1932-03-21.png (21.63 KiB) Viewed 8297 times

This is a coal loading station, but it looks like iron. Note that I'm using FIRS, but also note that using previously ISR with FIRS didn't result in that problem.

Another problem:

KelTransport, 1932-03-21#3.png (18.39 KiB) Viewed 8297 times

Usually, using that graphic in a double track way resulted in a larger building, while only there only is twice the same.

And still a last one:

KelTransport, 1932-03-21#4.png (30.69 KiB) Viewed 8297 times

When building Grain loading Station, there is no randomization at all. I'm not sure, but in my reminding, using that kind of station was partially randomized. Now, there is systematically big silos. And I can't obtain anymore the big red loading building. As a note: there also is a problem when using the section "ISR: Raw Materials". The first two graphics just give bare platform.

BUT As a last IMPORTANT note: I really often reload NewGRF's in my game, so those problems also might result from an excessive reloading, which should be avoided ... Thus, the bugs are to confirm !

[Simons Mith]

I see iron ore appearing at coal mines too, and many station types (oil, and goods A, B, and flat, notably) are not showing any noticeable design variety.

[mart3p]

I also have some strange behaviours on ISR, since some releases (I couldn't tell which).

Hi keoz, thanks for reporting.

All these bugs are caused by the same problem as George's bug above. The bug is in OpenTTD 1.4.0-beta1 and recent nightly builds.

See Flyspray issue #5852.

[keoz]

I also have some strange behaviours on ISR, since some releases (I couldn't tell which).

Hi keoz, thanks for reporting.

All these bugs are caused by the same problem as George's bug above. The bug is in OpenTTD 1.4.0-beta1 and recent nightly builds.

See Flyspray issue #5852.

Ok !

Thank you for watching on this.

And more generally, thank you for this amazing set !

[mart3p]

Regarding the bugs in ISR since nightly r26175 and 1.4.0-beta1, it now seems that this is an ISR problem. OpenTTD is working as intended.

Unfortunately, the technique I used for setting temporary registers was not intended usage. But as it worked perfectly at that time, I continued to use the same technique throughout ISR. If you want more details see ISR issue #6718. Basically, OpenTTD is now being stricter about where the register values are assigned.

It will take some weeks to fix this but I hope to have it done before OpenTTD 1.4.0 is released.

So for now, if you want to continue a game that uses ISR 0.9.2 you will have to continue using OpenTTD 1.3.3. If you use OpenTTD nightlies or 1.4.0-beta2 (and onwards), ISR 0.9.2 will not work.

Sorry for the inconvenience.

[ISA]

If you use OpenTTD nightlies or 1.4.0-beta2 (and onwards), ISR 0.9.2 will not work.

Sorry for the inconvenience.

Thanks for the info. Just started playing again over awhile and I did want to update the nightly, but I didnt... bit lazy!

[mart3p]

Industrial Stations Renewal v0.9.3

Changes for ISR v0.9.3:

Traditional Chinese translation added.
Fix #6718: Corrected the way temporary registers are assigned for advanced sprite layout (property 1A).

This fixes the bugs reported above. ISR is once again compatible with recent OpenTTD nightlies and OpenTTD 1.4.0-beta2.


ISR v0.9.3 requires OpenTTD 1.2.0 or later.
ISR v0.9.3 does not support TTDPatch. TTDPatch players should continue to use ISR v0.8.2.

ISR v0.9.3 is compatible with savegames using ISR v0.9.0, v0.9.1 and v0.9.2.

It is available for download from BaNaNaS and the OpenTTD in-game content downloader.

[planetmaker]

wooo! Thank you mart3p

[STD]

Thanks, mart3p

[keoz]

Hey, that was fast !

Thank you.

[Simons Mith]

You say ISR 0.9.3 is 'savegame compatible with ISR v0.9.0, v0.9.1 and v0.9.2'. But the only way to take advantage of this (and fix my current game) is to be naughty and load NewGRFs while the saved game is loaded, yes?

Edit: @Andrew350 (below) Thanks for the clarification.

[Andrew350]

No, as long as you delete the old version(s) of ISR, OpenTTD will use the newest one when you load the savegame.

[YNM]

Fallback to the newer, indeed.

(you must manually delete the old within your OpenTTD directory, through)

[Pyoro]

Does that make a difference ... ?

[YNM]

... slight ? (also there's an in-game console command to do that, if I remembered correctly)