Crash when scrolling on map

[sicano]

Hi all.

I'm using TTD Patch Nightlies and I'm having a problem with scrolling on map. Depending on the savegame, it seems there are some areas on the map in which scrolling causes a crash.

In the savegame I attached (in the RAR archive), try to scroll up-right, it should crash.

Hope the debug printscreen is what you need!

Thanks in advance, bye

[DaleStan]

Oh, wow. EIP's in a huge block of 0s, and the return value is in kernel32.dll. I don't want to know how you managed that.

You left out the version number though, and ttdpatch.cfg is useless. It thinks you're using a pretty old, and modified, version.

[sicano]

I'm using 2.6 alpha 0 r1664 (current last nightlie).

The problem is not related to this particular version of the patch, I've experienced the same with all other recent nigtlies.

[JGR]

Strange:
Running the savegame on my compiled nightly: r1651mod, with my config, I get a crash in the class5 draw code after scrolling around a bit.
548F2B: ebp is wrong,
called from Class5DrawLand.notwater-->correctstationalt, jmp from correctstationalt.done to 548EE0.

This suggests a broken savegame to me... Try starting a new game and testing that.
I will see if I can extract more info from this crash...

I will now try it with the config...

JGR

Edit: I think that this screenshot may shed light on the problem...

Observe the airports.

sc_bad.PNG (411.47 KiB) Viewed 539 times

The AI appears to have built airports on slopes...
Which is bad, and so the slope code gives up, when it is drawn.
The savegame might be a loss, but you may be able to wipe those tiles somehow...
I might try the clonetile cheat from some grass.

Edit 2:
Your map is littered with these broken AI airports. How long have you been playing it, and which versions of TTDP did you start with (and use in between). I think you may have to just abandon that game. (I saw another 4 before it crashed).
In general, the AI is extremely poor, and causes more problems than the marginal benefit of some competition, so I (and many people), do not use it.

Edit 3:
Tiles at (102,82)-(103,83), hex: 5266-5367, have bad L5 values for a class 5 tile.
L5s range from 0x84-0x87.
Viewing causes instant death.
Located just East of Datson airport. Owner: Denville Transport, Blue.
I will try and neutralise these and see if this fixes it.

Edit 4:
Changing to class 0 with ollydbg prevents the crash.
L3, L6, L7 and L8 were blank. L1 and L2 seemed to be OK.
The attached savegame is a "fixed" version, which (probably) won't crash, but is still broken.

TRP00.SV1

(330.89 KiB) Downloaded 134 times

[sicano]

I was thinking it was a corrupted savegame too (I abandoned another savegame which had the same problem), so I started a new game (this started few weeks ago, usin the nightlie up to date for that period) and was very surprising to me having again the same problem.

So you suppose that removing AI setting will reduce the risk of this problem?

Thanks for info and the savegame

[JGR]

What I meant was removing the AI entirely...
If you are thinking of the aiboost switch, it never worked, and has been removed, so you can remove it from your cfg.

The AI was rubbish when it was first implemented in TTD, and it doesn't play nicely with many new patch features...
I never use it.

However, the AI building airports on slopes and the broken station tiles, shouldn't happen and ought to be fixed...
If it's blindingly obvious how to fix it, I might try.

Good luck

JGR

[3iff]

You could always set the AI to not build airports...there's a setting in the config file...
aibuildairchance, set it to 0 (from 5041).

The AI do build airports everywhere, as if they don't verify the land they choose for the airport as being available and level...

[Dave]

The AI do build airports everywhere, as if they don't verify the land they choose for the airport as being available and level...

Indirect blasting of the patch-devs. This wasn't a problem in TTD, but has become an issue because of build on slopes, I think.

[Pookey]

I did have that same problem in one of the really early nightlies but JGR fixed it then without any problems.