Disclaimer:
*most* of this is still my personal opinion:
When I mention Devs ... I take into account the opinion of some of them but these are not their words, except for the quotes I made previously which was the view shared by more than 1 of them.
ic111 wrote:
ChillCore: As legal values for settings, I generally used the range that makes technically sense and that one might want to use. Specifically, if there would be a desert height, anything from <all rainforest> to <all desert> would be senseful values IMHO. Why not play a map with all rainforest? (and missing industries are IMHO no argument, as industries can be altered by NewGRFs). Thus, I used range 1..255.
I understand your reasoning, but to avoid OpenTTD possibly behaving badly you should not:
- Go higher than MAX_TILE_HEIGHT - 2. (snowline in trunk does not go all the way down to zero neither.)
- MIN_DESERT_HEIGHT = 1 is a bad idea too IMHO, the lower line of the desert (as in trunk) does not start at a fixed height but at a fixed number of tiles from the shore ... this could very well be higher than 1 and then you will be defining the upper desert line below the lower line, which might cause problems. I have never experimented with this so I might be wrong. I'd stick with 4 as minimum (the value current trunk has -> proven safe value).
ChillCore: You are right, default max. heightlevel should be 15, my mistake.
My pleasure.
Regarding desert height, I am open for any solution that doesn´t make things significantly more complicate than the 240 patch. As I have written previuosly, in fact a much more sophisticated landscape generator would be desirable, but is clearly out of scope for this patch. So, it´s up to you (devs) wether you use the 240 patch, or do simply nothing about desert height, leaving the hardcoded value of 4.
Devs (not only frosh) have a very strong feeling towards not going for a gui and having it configurable by the player.
The gui and everything else can easily be done afterwards as a separate patch.
I understand this logic and I can agree with that.
They can agree on "_settings_game.construction.max_heightlevel / 4" for desert amount (landscape.cpp), at least for now as far as mhl is concerned.
I mentioned before that this patch could be rewritten as a oneliner and as you had most code available ... I do not feel too guilty about this.
ic111 wrote:
chillcore wrote:
Both 155 and 240 are stored in the savegame but not in the config file.
-> should be stored in both places (like snowline)
So what did I miss technically?
src/table/gameopt_settings.ini in patch 155.
src/table/settings.ini in patch 240.
It is not "both in the same location" as I said before but one in the savegame and not in the config file and the other patch the other way round, sorry. I had trouble waking up properly this morning and posted a bit too soon.
ic111 wrote:
ChillCore wrote:
Gui clamping of selecting desertline.
->The actual clamping of the desert line height in the gui, when creating a new game, could be based on the selected max height?
¿ "upper clamp = _settings_game.construction.max_heightlevel / 4 * 3" ? instead of MAX_DESERT_HEIGHT. see previous comment.
You mean, forbidding a desert height higher than max. heightlevel?
Yes indeed I meant that
Well, one might implement this, makes code a bit more complicate as then for any change of these two values, the respective other value has to be checked. On the other hand, both are maximal values, if you choose max. desert height 100 on a max. heightlevel 50 map, you simply won´t get any rainforest. So, it´s a defined result, and thus I decided on not implementing additional checks for this. But this can be changed if we want it to be changed.
If you clamp the selection of desert line height to be lower than _settings_game.construction.max_heightlevel (with a gui redraw if needed) the scenario you mention above will never happen (maybe mhl should do this for the snowline to avoid the same problem there.)
But we can/could/should discuss this further as a separate patch ¿and in a separate topic? (-> even now already and based on clean trunk if you want that.)
As mentioned above ... devs would rather not implement 240 as is for now but replace it by a oneliner. (except for saving the value in the savegame maybe, I did not ask this)
"generated height / 4" for now.
ic111 wrote:
12:41:24 <frosch123> also, i think the max-height must be fixed at map generation, any may not be altered in game
Can we agree on making this an option in the cheat window?
I.e. on the same level as changes to money, time, climate, etc.
I don´t care about where and how, but I think there should really be a way to change this. I, and I think many other players too, play this game in single player mode, without even AI or network players. Thus, I want to be able to form the game (of course within the technically possible limits) the way I like it. And this involves corrections of this kind if after starting a game, I realize that some aspect of the game is not yet in the state I want it.
Devs even have stronger feelings about this not changing in game then over desert line (see previous posts in this thread).
Maybe this could be done as a cheat but I can/should/will not speak in Devs name.
My previous post with the quotes I posted after asking permission.
Again, I quoted frosh but he was not the only one of the Devs to share the same view as you can read on the previous pages.
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.
Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.