planetmaker wrote:ic111 wrote:Ok if you *really* insist on it, then I have to implement this also.
I would not regard it necessary.
What about the scenario editor? Do you also want to forbid someone forming higher mountains after generating a world with max. height 32?
(and I have thought I could start with other things now...)
Forbidding terraforming to heights higher than the current MAX_HEIGHT should not make any difference - except that it's not a define but a (global)? variable. I'd have assumed you have the code to limit stuff to MAX_HEIGHT anyway (does it need changing at all?) The only thing I assume is "missing", that is a max height selector in the game generation window(s).
Ok, what needs to be done?
- Defining a variable max_heigth in the advanced settings
===> Reason: I don´t want to restrict a game forever in this sense, IMHO there needs to be some way to change it afterwards. Furthermore, by doing so I don´t have to think about the question what happens if someone changes landscape in scenario editor (no, I don´t want to forbid people loading a max_height = 32 map in scenario editor and building a high mountain on it).
- Include it in the map generation settings
- Adjust the Terrragenesis map generator to never generate too high maps while generating senseful maps with not just a huge plateau on top
===> I will have to look how this can be done, perhaps it´s trivial, perhaps it costs several days to do so
- Make sure that the variable is ignored in the old map generator
- Make sure that the variable is used in heightmap generation
===> I.e. replace the newly introduced max_height for heightmap variable by the one I will now introduce
- Introduce terraforming condition
===> Easy
- Replace MAX_HEIGHTLEVEL in snowline code
===> Easy
Corrections to the list welcome.
If TerraGenesis can be adjusted easily, its a job for the next one or two days (in fact, I wanted to start today in the evening with working on a timetable patch, making them much better managable).
If TerraGenesis becomes a major problem, it´s a job for a week or so.
And concerning your 90-percent-rule: For me, there is a big difference between
(a) bugs, problems, etc. that obviously have to be fixed (we had a lot of them in the last months), and
(b) change requests referring to how it works
Here we have an instance of the latter, *you* want to have a proportional snowline instead of a fixed one as already implemented, have decided this at some place I do not or cannot read/discuss, and expect me to adjust the patch to the corresponding specification.