Chill's patchpack v14_7

[Muzzly]

Few words about compiling experience.

For 3-4 week I was using minGW. I do not remember what version it was but I am sure it was not the latest one, I tried to uses the version, that wiki suggest ( if it was still available).

After a while I realized that minGW compiled version was crashing very often and Visual Studio compiled version not.

From then I uninstalled minGW and now I am using only Visual Studio. I cannot say if this will happen if you take the latest minGW version.

Because Wasila is using minGW, I would suggest to reproduce crash with VC binary, just to be sure

[Terkhen]

Oh, I understand now. I quickly ran the newly compiled game and it hasn't crashed yet; I'll test it properly tomorrow. Thanks .

I don't know if you know this, but there were a few other things that looked like error messages which popped up while compiling.

Wasila

The second screenshot might be related to http://mingw.org/wiki/FAQ (check the first two points of Porting Issues).

Very curious... I compiled the moreheightlevels patch in the thread's OP with the corrent version (r20761) and not a single hunk succeeded...

http://www.tt-forums.net/viewtopic.php?p=902415#p902415

[Wasila]

I'm not really willing to update my minGW after spending so much time setting it up in the first place...

How exactly do I convert the file to EOS?

[Nickel_Plate]

I have not run program yet but i had same compiling errors as Wasila using MinGW.

[Nickel_Plate]

Patched and compiled r20768.

Copy/Paste crashes everytime try to use it. NO CRASH LOG, dumps straight to windows.

Mini map only goes to top corner.

[Wasila]

Copy/Paste crashes everytime try to use it. NO CRASH LOG, dumps straight to windows.

Do you have copypaste.grf installed?

As for the smallmap error, that's already known .

[Nickel_Plate]

Game won't start without it , so it must be installed.

[Dante123]

just a minor bug report.

when i now use the copy/paste in the latest version, it does not show that rail example anymore

here a example from what i see now:

minor_error.PNG (85.35 KiB) Viewed 2793 times

and as you may know, on previous versions it had those indication lines where and how the rail would be placed

[ChillCore]

How exactly do I convert the file to EOS?

You mean EOL?
Notepad++ is free, has syntax highlighting for many languages and can convert line endings to windows format so patches be can applied with TortoiseSVN. Other (decent) texteditors have the option too but Notepad that comes with Windows hasn't.

Also I would like to ask you a favor. Could you please generate a map of size 8k * 8k and querry the last few tiles to see if the changes in newgrf_debug_gui.cpp are sufficient for such big maps.
I can then upload a new larger map patch as I have seen that some more people was having trouble.
Thank you in advance.

Copy/Paste crashes everytime try to use it. NO CRASH LOG, dumps straight to windows.

Sometimes that happens ... I have no fix for it (yet) as I do not know what triggers it.
Were you trying to paste loaded templates or was it while copypasting without saving?
Do you have a reliable way to reproduce it?
You may want to save your game before trying to copypaste or set autosave to daily in the game settings to not lose to much if/when the game crashes.

Mini map only goes to top corner.

As I have not had the time to do much over the weekend I'll revert to the previous smallmap_gui code and post the patch later today.

When i now use the copy/paste in the latest version, it does not show that rail example anymore

Thank you for the report. I did not notice it before as I do not use it much.
I know where the conflict is and I can fix it. The only problem is that when I do, giving orders to vehicles gets broken.
Untill I know how to fix it properly you'll have to live with it. I'll need to do some digging and it may take some time trying different things. Sorry for the inconvenience.

[Nickel_Plate]

It seems to happen when

1) i try to load template from disk

2) try to save template to disk.

[Dante123]

When i now use the copy/paste in the latest version, it does not show that rail example anymore

Thank you for the report. I did not notice it before as I do not use it much.
I know where the conflict is and I can fix it. The only problem is that when I do, giving orders to vehicles gets broken.
Untill I know how to fix it properly you'll have to live with it. I'll need to do some digging and it may take some time trying different things. Sorry for the inconvenience.

ooh its no big deal, although sometimes i paste stuff the wrong way around now

[ChillCore]

As promised the patch with reversed smallmap code ... to be fixed somewhere in the future.
Also included the change in newgrf_debug_gui to prevent the crashing on very large maps. 8K * 8K is untested ... it is possible that 26 is not enough. I have tested 4K * 8K but not while playing, game did not crash.

Not yet fixed.
- Preview while pasting templates.
- Crash when pasting saved templates.

[Wasila]

Also I would like to ask you a favor. Could you please generate a map of size 8k * 8k and querry the last few tiles to see if the changes in newgrf_debug_gui.cpp are sufficient for such big maps.
I can then upload a new larger map patch as I have seen that some more people was having trouble.
Thank you in advance.

Even my computer is no match for the great extra-large-maps-patch. (read: generation failed - not enough memory available to allocate).

Notepad++ is free, has syntax highlighting for many languages and can convert line endings to windows format so patches be can applied with TortoiseSVN. Other (decent) texteditors have the option too but Notepad that comes with Windows hasn't.

How about Wordpad?

Two more things:

1. Would it be possible to include this patch: http://www.tt-forums.net/viewtopic.php? ... 56&start=0 into the patchpack?
2. Do you maintain savegame compatibility? So can I download the new version and keep on playing with my previous save?

[ChillCore]

Even my computer is no match for the great extra-large-maps-patch. (read: generation failed - not enough memory available to allocate).

Ah OK, I thought you had more memory installed then me ...

How about Wordpad?

As I do not have windows on my PC I can not check and I never used Wordpad before. If you check the tabs and the option is not there then no.
Just download Notepad++ and use that, you will not regret it.

1. Would it be possible to include this patch: viewtopic.php?f=33&t=49956&start=0 into the patchpack?

It is not difficult to merge and it works very well toghether with the patchpack.
Unfortunately it is broken against current trunk and I already have too much to fix for the moment.
The author seems to busy currently to update to current trunk, according to his recent comments in his thread.

2. Do you maintain savegame compatibility? So can I download the new version and keep on playing with my previous save?

Yes, until the code becomes too messy to maintain. I will then break it and keep it again for a few versions.
Yes, you can continue games started with v9_9_4 and later.

[Gremnon]

Notepad++ excels over Wordpad almost as easily as it does over Notepad itself.
I'm going to have a glance into the Departure Boards + Wallclock patch and see if I can generate a fix to make it work against the most recent version of this pack, because I like it too.
And probably trunk too.

[ChillCore]

I'm going to have a glance into the Departure Boards + Wallclock patch and see if I can generate a fix to make it work against the most recent version of this pack, because I like it too.
And probably trunk too.

Cool.
You will be looking at changes from r20771 and a few after that.
Good luck.

[hthhs]

Notepad++ excels over Wordpad almost as easily as it does over Notepad itself.
I'm going to have a glance into the Departure Boards + Wallclock patch and see if I can generate a fix to make it work against the most recent version of this pack, because I like it too.
And probably trunk too.

I'm already working on it. If all goes well I should have updated the patch thread shortly.

EDIT

Done.

[Wasila]

Kewl. Also Close/Upgrade airports also just got bumped to trunk

I'll try Notedpad++ tonight if I get the chance.

Ah OK, I thought you had more memory installed then me ...

How much do you have?

[ChillCore]

Ah OK, I thought you had more memory installed then me ...

How much do you have?

I have 1024 MB. Which is not enough for 8K * 8 K maps.
OpenTTD seems not to use virtual memory of which I have plenty ...



Please find attached the new version of the patchpack.

Updated:
-------
- Cargodist to r20802. (Gogo fonso. )
- More height levels to v30_1 (- smallmap positioning fix + missing "is already levelled" message fix)

Added:
-----
Departure boards- 24h clock patch
Thank you for the update hthhs.

New files in the src folder:
-----------------------------
departures.cpp
departures_func.h
departures_types.h
departures_gui.cpp
departures_gui.h

To test please:
----------------
Could someone be so kind to generate a 8K * 8K map and querry the southern most tiles while having the grf debug tools enabled. Thank you in advance.

Known bugs updated in first post.
Patch and added patches zip updated in second post.

[Gremnon]

Warnings while compiling V10 on 32-bit Arch Linux:

Code: Select all

[SRC] Compiling copy_paste.cpp
/home/liam/source/ottd-chipp/10/src/copy_paste.cpp: In member function ‘void CopyPaste::internal_PasteArea(TileIndex)’:
/home/liam/source/ottd-chipp/10/src/copy_paste.cpp:716:44: warning: name lookup of ‘tile’ changed
/home/liam/source/ottd-chipp/10/src/copy_paste.cpp:514:6: warning:   matches this ‘tile’ under ISO standard rules
/home/liam/source/ottd-chipp/10/src/copy_paste.cpp:549:2: warning:   matches this ‘tile’ under old rules

[SRC] Compiling settings.cpp
/home/liam/source/ottd-chipp/10/src/settings.cpp: In function ‘StringID CompanyLoadProfile(CompanyProfile&)’:
/home/liam/source/ottd-chipp/10/src/settings.cpp:1866:60: warning: comparison with string literal results in unspecified behaviour
/home/liam/source/ottd-chipp/10/src/settings.cpp: In function ‘StringID CompanySaveProfile(const CompanyProfile&)’:
/home/liam/source/ottd-chipp/10/src/settings.cpp:1881:11: warning: unused variable ‘valid’

[SRC] Compiling watch_gui.cpp
/home/liam/source/ottd-chipp/10/src/watch_gui.cpp: In member function ‘virtual void WatchCompany::SetStringParameters(int) const’:
/home/liam/source/ottd-chipp/10/src/watch_gui.cpp:196:29: warning: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers
/home/liam/source/ottd-chipp/10/src/watch_gui.cpp:200:29: warning: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers

Compiled build runs. Running it from a terminal doesn't give any further warnings, and so far the game appears to work as normal, so the warnings don't appear to have any game-crashing effects as yet.