Distant-join-stations (in trunk)

[Splatman]

Any chance of getting a patch against the latest trunk?

[Tiberius]

Here it goes, updated to latest GUI framework ...

(2008-07-24): Now it closes station-selecting window after you selected a station.

EDIT: change to svn-diff style (actual code not altered at all)

[Thief^]

It would be much easier to apply all these updated patches you're posting if you were using svn diff.

[Tiberius]

Fix the bug that prevents AI players to build a station.
Thanks makbeth, author of RCPP, for kindly providing the fix

[PhilSophus]

Little update to current trunk.

[MJS]

Very good - maybe the topic title might be changed as well?

[nulio]

Wow this is really great.

I really don't know how all this stuff works but I'll ask anyway. How long till this stuff is included in a stable release? (I would extend the question to copy&paste also)

[PhilSophus]

I really don't know how all this stuff works but I'll ask anyway. How long till this stuff is included in a stable release?

That's indeed a good question. The devs had some objections, but the patch was changed according to their comments back in April (it was in fact me, who did it). Since quite some revisions have gone by since then, I don't know in how good shape the code still is.

@Frostregen, I just noticed this was never posted to flyspray. Would you mind if I posted it there (referencing you as the original author of course) or do it yourself? However, I would recheck the code before (I probably don't get at it before middle of the week, though).

[Eddi]

was the issue with the race condition when stations are changed by another client ever solved? (send station IDs instead of list indices with the build command?)

[PhilSophus]

was the issue with the race condition when stations are changed by another client ever solved? (send station IDs instead of list indices with the build command?)

Yes, that was what I was referring to in my previous post (see http://www.tt-forums.net/viewtopic.php?p=658205#p658205). Although, it was not in April but even back in January. In April I did some changes related to the adjacent stations setting.

[Frostregen]

@Frostregen, I just noticed this was never posted to flyspray. Would you mind if I posted it there (referencing you as the original author of course) or do it yourself? However, I would recheck the code before (I probably don't get at it before middle of the week, though).

Thx for asking,
It is ok, just do it

Greetings,
Frostregen

[MJS]

Sounds like a good idea! I can't help but repeat: this was included in Patch a really long time ago, and hampers playability of OTTD by people who have switched recently. Plus, it can't be such a bad idea, can it?

Only thing is, it might be better connected with 'show catchment area' (on right click?), which is very useful; and there should be a way to highlight all stations (esp. bus stops) belonging together.

[PhilSophus]

Only thing is, it might be better connected with 'show catchment area' (on right click?), which is very useful; and there should be a way to highlight all stations (esp. bus stops) belonging together.

I agree that these are nice features to have. However, I disagree that those should be merged into this patch, as these are completely distinct features and a patch should only implement one thing at a time.


EDIT: I added a patch setting to disable the feature and posted the patch to flyspray as FS#2291. Now let's all pray to the gods of the OpenTTD Olympus to accept it for trunk

[Wolf01]

@Frostregen, I just noticed this was never posted to flyspray. Would you mind if I posted it there (referencing you as the original author of course) or do it yourself? However, I would recheck the code before (I probably don't get at it before middle of the week, though).

Hey, don't forget about me

Credits to Wolf01 for the idea.

[PhilSophus]

Hey, don't forget about me

Sorry for having overlooked you (I only checked only the authorship of posted patches not the full five pages of posts). Honor to whom honor is due , so I added it to the flyspray task.

Anyone else, I forgot?

[TrueTenacity]

With this patch do the station names change to be one big station covering the whole area or do they retain their identities and just share a common pool of pax / cargo

[PhilSophus]

Neither, as far as I understand your question.

This patch just allows you to build disconnected station tiles, so all of them are the same station from the moment of building them in the same way two neighboring tracks of a station are the same station: One collection of cargo and only one station sign, which can at times be confusing because you don't know which station a bus stop belongs to at first sight (i.e. before clicking it).


Just a notice: I update the patch from time to time in the flyspray task. So, anyone looking for a newer one might have a look there (or set a watch on this task).

[planetmaker]

With this patch do the station names change to be one big station covering the whole area or do they retain their identities and just share a common pool of pax / cargo

You cannot build stations larger than you could do anyway. This patch only provides simple means to build a station which has tiles which are not adjacent.

[dasy2k1]

i wish this was added to trunk. i havent got it at the moment as im using clestarr's cargodest at the moment
and im not even sure what svn rev it uses,

im allways budling a station, then building a chain of bussops so i can get one where i want then deleting the gap filling ones
this patch means that you dont have to do this!

[Ruudjah]

Awesome patch. This makes passengers services on competition servers a whole lot cheaper. What happens right now:

-You start to build a station at town A and town B
-When you have some income, you extend the station so that the catchment area is bigger
-This can cuase problems: trees removed decrease town rating. Sometimes town are really evil and you can forget about station extension.

With the patch:
-building a station with a good catchment area is cheap, and quicker
-you dont loose any rating (or hardly any)
-It allows you to build bigger stations at start since you have more rating to 'waste'.

My question: Is this patch usable on the client only? In other words, does the server need this patch also for it to work?