YAPP - Yet Another PBS Patch (now in trunk!)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Michi_cc
OpenTTD Developer
OpenTTD Developer
Posts: 619
Joined: 14 Jun 2004 23:27
Location: Berlin, Germany
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Michi_cc »

Service announcment:

If you have been playing older versions of YAPP or any of the patchpacks with integrated YAPP, you should delete your openttd.cfg because there might be stale patch settings that have changed since then.

This especially concerns the setting pf.yapf.rail_pbs_station_penalty, which now has a default of 800, a value that was once uppon a time different.

-- Michael Lutz
-- Michael Lutz
User avatar
Timitry
Transport Coordinator
Transport Coordinator
Posts: 313
Joined: 01 Oct 2004 15:28
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Timitry »

Wow, what a great addition to OpenTTD! Congratulations, MichiCC, and thanks to Rubidium!

How about making an announcement in the General OpenTTD? Many players will probably not look in the Development Forum, but might want to play with YAPP urgently :)

And i guess we have a point for the 0.7 roadmap :-)
Aphfaneire
Engineer
Engineer
Posts: 68
Joined: 03 Jul 2007 17:50

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Aphfaneire »

Is it true?

Is it in nightly's today?

If so woohoo!

I still have the gonzal patch version, which is full of bugs, but it been a while so im guessing it must be pefect if its in trunk!


You guys make every TTD gamer's dreams come true! :bow: :bow:
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Roujin »

congratz michi :)

hope you'll keep inproving and fixing it if necessary ;)
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by planetmaker »

Nice job Michi_cc! Thanks a lot for another great addition to this game. :)
User avatar
^^atte
Engineer
Engineer
Posts: 19
Joined: 15 Feb 2008 20:33

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by ^^atte »

:O <3 ^^, finnly this patch is in trunk, im been w8ing some time for it :D

anyway im away to play now xD,

good job Michi_cc, :D
User avatar
thgergo
Route Supervisor
Route Supervisor
Posts: 391
Joined: 29 Mar 2005 12:44
Location: Hungary

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by thgergo »

A real masterpiece has just entered into the trunk? This PBS must be very stable to get in:), also this YAPP better than the previsious PBS implemention by hackykid :bow: Ill try it soon with the recent nightly... Keep up very good work:) :mrgreen:
Image
Image
Tekky
Route Supervisor
Route Supervisor
Posts: 420
Joined: 19 Dec 2006 04:24

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Tekky »

The latest nightly build which now includes YAPP can be downloaded here:

http://www.openttd.org/nightly.php
phil88
Transport Coordinator
Transport Coordinator
Posts: 267
Joined: 25 Jan 2007 23:26

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by phil88 »

This is probably the most a single nightly has ever been downloaded :p

Good work guys, 'tis a great patch kudos to you all.
- Phil
User avatar
Bastiaan
Chairman
Chairman
Posts: 781
Joined: 12 Feb 2004 19:34
Location: Zwolle (NL)
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Bastiaan »

Thank you so much for this patch. PBS was the only thing I missed in OTTD, and now it's finally there!
Image
nautre125
Engineer
Engineer
Posts: 74
Joined: 04 Feb 2008 10:58
Location: Strasbourg, France

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by nautre125 »

Congratz michi_cc and thank you for your work.
Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Mchl »

Something strange in trunked YAPP:
I have 'Cycle through signal types' set to 'Advanced only' yet I start always with a two way normal signal.
It wasn't so in the previous YAPP version I have.

Is this intentional?
razielanarki
Engineer
Engineer
Posts: 20
Joined: 08 May 2002 05:01

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by razielanarki »

yapp is in trunk? wow, great news!
congratulations michi_cc!
Michi_cc
OpenTTD Developer
OpenTTD Developer
Posts: 619
Joined: 14 Jun 2004 23:27
Location: Berlin, Germany
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Michi_cc »

Mchl wrote:Something strange in trunked YAPP:
I have 'Cycle through signal types' set to 'Advanced only' yet I start always with a two way normal signal.
Check 'Signal type to build by default' directly above.

-- Michael Lutz
-- Michael Lutz
Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Mchl »

Michi_cc wrote: Check 'Signal type to build by default' directly above.

-- Michael Lutz
Lol.
Totaly forgot about that one...
Perils of using common config file for too long :)
User avatar
Zephyris
Tycoon
Tycoon
Posts: 2897
Joined: 16 May 2007 16:59

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Zephyris »

I go away for a few days and when I come back YAPP is in trunk!? Woooo!!! :D
User avatar
Brianetta
Tycoon
Tycoon
Posts: 2567
Joined: 15 Oct 2003 22:00
Location: Jarrow, UK
Contact:

Bug report

Post by Brianetta »

I found a bug in YAPP.

Effect:
Stale reservation; track is never used.

To replicate:
  1. * Allow a train to reserve a length of track.
    * Build a one-way advanced signal on the reserved track, facing away from the train.
    * The train will stop at the signal, and turn around. A new path is reserved in the opposite direction. The remainder of the existing reservation is not cleared.
If this happens in the game, the only remedy is to manually shepherd a train across the reservation, or to remove and replace all the reserved track.
PGP fingerprint: E66A 9D58 AA10 E967 41A6 474E E41D 10AE 082C F3ED
User avatar
AntBUK
Transport Coordinator
Transport Coordinator
Posts: 319
Joined: 02 May 2007 12:29
Location: Sheffield, England
Contact:

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by AntBUK »

Congrats mate ^^

I nearly soiled myself when I saw the changelog lol
Rasing Awareness: Aspergers Syndrome 1 (NAS UK)2 (BBC)3 (YaleDDC)


Something is driving you insane... It is me.
User avatar
Zutty
Director
Director
Posts: 565
Joined: 22 Jan 2008 16:33

Re: YAPP - Yet Another PBS Patch (now in trunk!)

Post by Zutty »

Trunk! WOW! Congrats michi_cc. :bow:

This is a huge milestone for OpenTTD.
PathZilla - A networking AI - Now with tram support.
Aphfaneire
Engineer
Engineer
Posts: 68
Joined: 03 Jul 2007 17:50

Re: Bug report

Post by Aphfaneire »

Brianetta wrote:I found a bug in YAPP.

Effect:
Stale reservation; track is never used.

To replicate:
  1. * Allow a train to reserve a length of track.
    * Build a one-way advanced signal on the reserved track, facing away from the train.
    * The train will stop at the signal, and turn around. A new path is reserved in the opposite direction. The remainder of the existing reservation is not cleared.
If this happens in the game, the only remedy is to manually shepherd a train across the reservation, or to remove and replace all the reserved track.

Ive had a very similar problem with the gonzal patch months ago!

But this is mainly due to upgrading a network to pbs. When i build with pbs straight away there are far less problems. No trains crashing like mad, which they still do!

But the crashing is mainly due to puting new pbs signals on old routes built for pre-signals. That and the faster they are the less likely they are to pick up a path and not enter a junction or station. I spent more than an hour cleaning up a massive old map of mine, i lost about 18 trains and my profit dipped slightly...

But its all gravy now 8)
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Google [Bot] and 7 guests