Patch: Filter by cargo [in trunk]

[Tiberius]

Thanks planetmaker

For those who wonder why this haven't went into trunk yet: OpenTTD official developers want to share the interface used to filter stations (which can select multiple cargo types at once), preferably share the same code.

Perhaps I should implement a whole new widget type for this ? I don't even know if enlarging 'data' in Widget from uint16 to uint32 is safe/the right thing to do(tm) for now ...

I may (or may not) implement it recently (or in distant future), but don't hold your breath. If anyone want to be the one please implement it for us all, meanwhile you can BuildOTTD yourself or try my patchpack

[Tiberius]

The second filter-by-cargo patch that uses station cargo filtering interface ...
Not sharing the same code though, didn't come up a good way to do it ...

When opening a new vehicle-purchasing window it'll restore the last filter used with the same type of vehicles (road, train, ship, airplane).

Use CTRL to select multiple cargo types at once.
I was trying to link a Factory in the following picture, for example ...

NO = Show vehicles that takes no cargo at all (that is, locomotives)

[DJ Nekkid]

i have a certain feeling that your approach (accorting to the screenie) witht teh small "icons" on the top with "ps, cl, ML, OL, LV, GD ... NO, ALL" will have some pain with window size if used with one or two (or rather a few) ECS vectors, or some other "new cargo" grfs... Altho, i heavent tested this, but it's just a notch I have...

[Tiberius]

It will automatically enlarge the window to accommodate additional buttons for more cargo types introduced by NewGRFs (max 32 as OTTD allowed), like the screenshot below.

Since we know developers want the window as small as possible, make it easier porting OTTD to small-screen devices like NDS, PSP, S60 etc., therefore I decide to keep window sizes manageable from the beginning. Hey, perhaps someone will ask me to show these buttons in multiple rows later

[sir_schwick]

I recently tried out this patch, as it was bundled with Roest's Patchpack. On the prescribed build(r1309 I think) most of the other patches work but this one is not present at all. I am also running ECS and its compatible grfs at the moment. Is Filter by Cargo compatible with ECS?

[planetmaker]

Is Filter by Cargo compatible with ECS?

Look at the image caption in the posting imediately above your post.

[Timitry]

Heyho!

I like that patch, looks really good!

2 things: First, the multiple rows-thing for the icons would be good, as the window shouldn't be too wide.
Second: Maybe this is already implemented, did not test it, but does it show a tooltip when right-klicking on or hovering over the cargo icons, telling you which cargo it is? As especially with ECSVectors it can be hard with the abbrevations...

Hope to see this in trunk soon!

[sir_schwick]

Is Filter by Cargo compatible with ECS?

Look at the image caption in the posting imediately above your post.

Doh. Ummm, what else should I look for to solve the issue of not having your awesome patch working?

[gule]

After a long long time I updated this patch to trunk. It is my version with dropdown.

Updated version in first post.

[Zuu]

After a long long time I updated this patch to trunk. It is my version with dropdown.

Updated version in first post.

Congratulations for successful merge with trunk!

I see your first post is from April.

[planetmaker]

small update

[2007Alain2007]

Hi i am under takeing a new patchs pack and would like to inclued your patch but i need help doing this

[ColdIce]

the update is here

http://bugs.openttd.org/task/1941?strin ... &closedto=

the patch is down the list for r15591

[planetmaker]

Update for r15776

[frosch]

Despite of the general list filtering stuff someone mentioned in the FS task:

1) What's the point of cargo_filter_xxx for every vehicle type, when only one is used?
(They were static in another version of the patch FS#2196, but now?)

2) cargo_type and capacity of xxxVehInfo as well as refit_mask should no longer be used in GUI code (also not in other code, except in authorized places ). Use Engine::CanCarryCargo(), Engine::GetDefaultCargoType(), Engine::GetDisplayDefaultCapacity(), GetUnionOfArticulatedRefitMasks() or GetIntersectionOfArticulatedRefitMasks(). (The last part was already fixed somewhen in FS#1941)

3) + this->cargos_dropdown_pos[CF_SHOW_ALL] = 0;
Uhm, CF_SHOW_ALL is -1.

[2007Alain2007]

trying my best to update just asking what WIDGET thing at the end do i use

{ WWT_DROPDOWN, RESIZE_RIGHT, COLOUR_GREY, 191, 293, 14, 25, 0x0, STR_SORT_CRITERIA_TIP},

think its this // BUILD_VEHICLE_WIDGET_SORT_DROPDOWN but every time i try i get an errour in game

[2007Alain2007]

I tryed my best to get this updated and have failed can any one help please by updateing it

[planetmaker]

look at flyspray for a re-written version. I haven't tested it yet, though.

[2007Alain2007]

no there updated the widgets in the build_vehicle_gui

[gule]

In trunk (r16042) thanks to frosch and srb.