YAPP - Yet Another PBS Patch (now in trunk!)

[Trond]

Yes, but Roujin just posted the patches, not a prebuildt version. thats what I meant

Isnt that correct?

[Yexo]

Yes, but Roujin just posted the patches, not a prebuildt version. thats what I meant

Isnt that correct?

That's correct

[Michi_cc]

Version 5.2 is out, get it as usual from the last release post.

Changes:

• Fixed invalid path reservation of reversing trains through one-way signals.
• Better handling of spread out stations like the example from Rubidium. This has performance implications for very spread out stations, but for typical stations the performance loss is insignificant.
• Better protection of reserved station tiles from being overbuilt. (Still not perfect, but much better than before.)

-- Michael Lutz

[MrMox]

The Win32 BuildOTTD version with YAPP 5.2:

trunk_r12622_yapp_r12622_v5_2_svn.patch_08-04-2008_07-56-03.zip

(2.87 MiB) Downloaded 166 times

r12622 contains a small problem with nonstop orders mentioned here. This version is the same as the one above, with Rubidium's fix incorporated. Use this if you play with "TTDPatch compatible nonstop handling" set to on.

trunk_r12622_yapp_r12622_v5_2_svn.patch_08-04-2008_19-11-14.zip

Rubidium's fix included.

(2.87 MiB) Downloaded 185 times

[Two5Kid]

You're a godsend MrMox, too bad I'm at work, will be downloading this latest patch soon, real soon!

[patter]

Version 5.2 is out, get it as usual from the last release post.
-- Michael Lutz

We're not worthy! We're not worthy!

Thanks for bringing back the best patch into openttd, looks like I have to recompile but hey I wasn't planning to do anything tonight

[Progman]

Code: Select all

openttd: /home/progman/openttd/trunk/src/yapf/yapf_base.hpp:272: void
CYapfBaseT<Types>::AddNewNode(typename Types::NodeList::Titem&, const typename Types::TrackFollower&)
[with Types = CYapfRail_TypesT<CYapfRail2, CFollowTrackT<TRANSPORT_BEGIN, false, false>,
CNodeList_HashTableT<CYapfRailNodeT<CYapfNodeKeyTrackDir>, 12, 16>, CYapfDestinationTileOrStationRailT,
CYapfFollowRailT>]: Assertion `0' failed.
Aborted

Tested with 5.2 on r12622 loaded with a 5.1 game (see attachement)

[beefsack]

Thanks a million Michi_cc you are an absolute legend

[Trond]

(see attachement)

it's 9/11...

[Haiya-Dragon]

Code: Select all

openttd: /home/progman/openttd/trunk/src/yapf/yapf_base.hpp:272: void
CYapfBaseT<Types>::AddNewNode(typename Types::NodeList::Titem&, const typename Types::TrackFollower&)
[with Types = CYapfRail_TypesT<CYapfRail2, CFollowTrackT<TRANSPORT_BEGIN, false, false>,
CNodeList_HashTableT<CYapfRailNodeT<CYapfNodeKeyTrackDir>, 12, 16>, CYapfDestinationTileOrStationRailT,
CYapfFollowRailT>]: Assertion `0' failed.
Aborted

Tested with 5.2 on r12622 loaded with a 5.1 game (see attachement)

Got the same assert also with a 5.1 game loaded in a 5.2 patch version. Reloading it in 5.1 gave no problems. I can post a savegame if you wish, but it's an extended network multiplayer game with a ton of newGRF loaded, so that's probably not too practical.

[oldgeek]

Code: Select all

~/OpenTTD/r12622/trunk $ make run
make[1]: Entering directory `/home/norman/OpenTTD/r12622/trunk/objs/lang'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/home/norman/OpenTTD/r12622/trunk/objs/lang'
make[1]: Entering directory `/home/norman/OpenTTD/r12622/trunk/objs/release'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/home/norman/OpenTTD/r12622/trunk/objs/release'
openttd: /home/norman/OpenTTD/r12622/trunk/src/yapf/yapf_base.hpp:272: void CYapfBaseT<Types>::AddNewNode(typename Types::NodeList::Titem&, const typename Types::TrackFollower&) [with Types = CYapfRail_TypesT<CYapfRail1, CFollowTrackT<TRANSPORT_BEGIN, true, false>, CNodeList_HashTableT<CYapfRailNodeT<CYapfNodeKeyTrackDir>, 12, 16>, CYapfDestinationTileOrStationRailT, CYapfFollowRailT>]: Assertion `0' failed.
/bin/sh: line 1: 32677 Aborted                 ./openttd
make: *** [run] Error 134

Another crash with 5.2 on r12622 loaded with a 5.1 game (see attachement)

[MrMox]

Yet Another Unofficial Build of YAPP 5.2 ...

I updated the patch file so that it works with r12651. This in order to get the fix for the problems with non-stop orders mentioned here. Notice that save-games from versions build with r12622 won't work with this version.

Have fun

trunk_r12651_yapp_r12622_v5_2_svn.patch_10-04-2008_18-37-32.zip

(2.88 MiB) Downloaded 163 times

[elmex]

Thanks for the patch! I wouldn't want to play without it anymore Keep up the good work!

[vwspeedracer]

Yet Another Unofficial Build of YAPP 5.2 ...

I updated the patch file so that it works with r12651. This in order to get the fix for the problems with non-stop orders mentioned here. Notice that save-games from versions build with r12622 won't work with this version.

Have fun

trunk_r12651_yapp_r12622_v5_2_svn.patch_10-04-2008_18-37-32.zip

Could we get Yet Another Unofficial Patch of Yet Another PBS Patch? I'd to build it on my Mac.

[MrMox]

Sure, here it is:

yapp_r12622_v5_2_svn.patch

(194.46 KiB) Downloaded 179 times

I've used this patch file to build a version with r12660 and haven't found any problems so far after playing for several hours. It may work for even newer versions but I haven't tried that.

[vwspeedracer]

Brilliant, thanks!

[Michi_cc]

Guess what, trunk had another savegame bump, so you're getting version 6 now.

Changes:

• Removed the previous changes for spread-out stations, as they were causing asserts. Instead reserved station tiles now have a bigger penalty, you can control the factor which the base penalty for reserved tiles is multiplied by with yapf.rail_pbs_cross_st_factor. This also helps with spread-out stations, even though this solution is not perfect, but it actually works.
• Updated for the order changes in trunk.
• 6.1: Fixed some problems with lost trains.
• 6.2: Auto-signal would sometimes not copy the signal type.

No other new features present.

-- Michael Lutz

[MrMox]

The Win32 BuildOTTD version with YAPP 6.0:

trunk_r12697_yapp_r12697_v6_svn.patch_14-04-2008_16-52-26.zip

(2.88 MiB) Downloaded 290 times

[pavel1269]

I just play with this patch with friends and i must say ... GREAT!

[Roest]

I merged it with copy&paste for anyone interested.