Patch: Close airports

[DaleStan]

There's another part to it too. Adding an airport may be a big change, but consistency of related items is also important. The vehicle-type buttons should all behave the same way, and since some of them could be enabled with small changes, all should be enable/disable. The close airport button is, IMO, sufficiently unrelated that it can choose its own way.

[CobraA1]

I have just reread your post three times and I still do not get what point you are trying to make

I think it's a bit like this:

-If it can be enabled somehow, it should be greyed out.

-If it can't be enabled somehow, it should disappear.

is that if more buttons are later added,

Well, I see some other options:

1) Allow it to perform some similar option for other vehicle types, so it never has to disappear

2) Only allow aircraft-only buttons on the same line, so that they can all appear or disappear.

3) Place it somewhere else where it won't have that issue.

[cirdan]

I've rebased the patch against current nightly (r11537) and included a fix (thanks to glx) to a reported compilation warning.

EDIT: Updated the patch to r11542 and applied the proper fix.

[nfp]

this is good patch.

But meybe is whole idea of waiting planes in the air bad. In real life if you want to close airport and you want to rebuild it, you probably stop all trafic, so all planes are hidden on other airports or hangars. That can be applied to all other vehicles (trains, ships).

So what i propose is that every vehicle or ship or train or plane which wants to go to stoped station will be sent to closest depo or hangar. In case of planes not the hangar of stopped airport.
And than after you open the station all previously stopped vehicles will be unstopped.
Here can be some issue, iem not sure if its possible you must store exactly which vehicles was stopped.

[Bilbo]

I suggest moving to next airport in orders in case of closed airport ... so for planes going between 3 airports, they start going between 2 of them, for planes between 2 airports they'll basically stay at the other airport. Or perhaps make it an option - move to next possible target or circle around? While circling around is less logical, it may be better from the perspective of comfort (planes will just wait a bit longer and will not spread to nearby hangars)

Also, you'll have to handle some pathological cases that the closed airport is the only one left or if both airports in the orders gets closed, etc ....

[cirdan]

But meybe is whole idea of waiting planes in the air bad. In real life if you want to close airport and you want to rebuild it, you probably stop all trafic, so all planes are hidden on other airports or hangars. That can be applied to all other vehicles (trains, ships).

Note that this issue is not new with this patch. It also happens if you demolish an airport with aircraft heading to it; they will arrive and circle around the now airportless station.

[Bilbo]

they will arrive and circle around the now airportless station.

Once the station "decays" and disappear, airport will head to next station, or nearest hangar (no usable station in orders) and i case it was the last airport in existence, it will "run out of fuel" and crash.

[cirdan]

they will arrive and circle around the now airportless station.

Once the station "decays" and disappear, airport will head to next station, or nearest hangar (no usable station in orders) and i case it was the last airport in existence, it will "run out of fuel" and crash.

And what if the station does not "decay", because it still has a bus stop, for instance? If I recall correctly, aircraft will get into the dummy airport finite state machine and happily circle around forever.

[pavel1269]

Friendly update to this patch I like this one

[cirdan]

Updated against nightly r11927.

[Stargazer]

I'll hopefully be giving this a go tonight...

I just want to be sure... Will this latest version cause the Desync problem like the one mentioned in the first post?

[cirdan]

I just want to be sure... Will this latest version cause the Desync problem like the one mentioned in the first post?

No, only the two first versions had that problem.

As you can see, the latest version of the patch is against r11927. Please tell me if it no longer applies cleanly, or if it breaks/doesn't work/whatever (bug reports always welcome).

[imcfarla]

Hi,

This is really useful when you have very busy airports!

I have updated the patch
1) to apply to beta4
2) to keep the button in the right place when resizing the station_gui window
3) to hide the close airport button when the station is not an airport
4) to hide the close airport button when in the rating screen

Regards,

Iain

[LordAzamath]

why not to apply to beta5 ?

[imcfarla]

I hadn't noticed beta5 was out when I posted the patch

It does apply (with a bit of fuzziness) I just checked

Regards,

Iain

[cirdan]

Hi,

This is really useful when you have very busy airports!

I have updated the patch
1) to apply to beta4
2) to keep the button in the right place when resizing the station_gui window

Thanks for the update. I have been offline for a week, so I have not seen it until today.

3) to hide the close airport button when the station is not an airport

Hmm, there was some discussion about this, and I think we did not reach an agreement about whether the button should be disabled or hidden in that case.

Anyway, just for the record, I stopped updating of this patch as trunk is currently in a feature freeze. I will resume development as soon as 0.6.0 is released.

[jez]

(retracted, sorry!)

[cirdan]

I've updated the patch against 0.6.0.

The only significant change is that the close-airport button now spans the whole width of the station window. This is required for switching between accepts and ratings views to work properly.

[planetmaker]

I updated to current trunk (r13119).

[planetmaker]

Update to current trunk