Downloadable Graphics from servers?

Discuss, get help with, or post new graphics for TTDPatch and OpenTTD, using the NewGRF system, here. Graphics for plain TTD also acceptable here.

Moderator: Graphics Moderators

Moriarty
Tycoon
Tycoon
Posts: 1395
Joined: 12 Jun 2004 00:37
Location: United Kingdom of Great Britain and Northern Ireland
Contact:

Post by Moriarty »

Thankyou Bilbo. 8)

So is such a feature going to be created for OTTD?
Or for that matter, should someone create a patch (and it was "good") would it be merged with trunk?
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Post by Bilbo »

Moriarty wrote:Thankyou Bilbo. 8)

So is such a feature going to be created for OTTD?
Or for that matter, should someone create a patch (and it was "good") would it be merged with trunk?
Well, devs were quite opposed to having this feature, so I think even if someone will make a nice patch it won't be accepted probably.
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Post by DaleStan »

Moriarty wrote:
the license (which cannot be changed)
The license holder can change it at any time. :?
Ah. You seem to have a problem here. You are assuming that every GRF has exactly one license holder. This is not the case. Whenever there are multiple license holders, all have to agree to any change in the license. And silence is not "mark of the consent".
Moriarty wrote:
DaleStan wrote:1) There must be some way to ensure that GRF is transmitted with its license, and
2) There must be some way to ensure that GRF transmission is followed by a valid offer for the source code (if/when we figure out what constitutes "source code") IOW, the grf cannot be distributed by anyone who does not have (or, at least, know where to find) the source code.
Both of which are resolved by distributing the zip file (originally downloaded from the license holders site)
Negative. The first is, but the second is not. Nothing requires that the source might be *bundled* with the GRF. It just has to be offered.

Not to mention the fact that OpenTTD still doesn't know what to do with a ZIP file.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
csuke
Transport Coordinator
Transport Coordinator
Posts: 361
Joined: 05 Jun 2004 18:48
Location: London UK

Post by csuke »

Why are you lot just going round in circles?

It is VERY simple, all it needs is for someone to code a patch, compile it against the latest version, and distribute it along with all the relevant source code to anyone who wants to use it.
The OpenTTD devs are apparently quite against this so someone would have to be found with the required skill. Perhaps it could be included in an integrated build?

As for the legal issues, nothing a bit of code in the patch can't deal with plus a few new flags in the GRF's for anyone who wants theirs distributed like this. ie:
-Simple yes/no for whether auto distribution is allowed
-Name of accompanying file(s) that have to be downloaded with .grf
-Link to site where source code will be available

As for the patch, any .txt files that must be downloaded are auto displayed when the user joins the server and must be "read and accepted" before the grf is downloaded. The links must also be displayed. No need for zip files.

Anyone who modifies someone elses .grf and redistributes it without/with a changed licence is breaking the original agreement, this problem already exists, and unless someone can write some code which subliminally messages people in order to brainwash them into not breaking the licence agreements then we are not going to fix this...

This is not the fault of the patch or OpenTTD so no problems there.

Any questions?
Image
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Post by Bilbo »

csuke wrote: -Name of accompanying file(s) that have to be downloaded with .grf
Ther may be slight problem with files like "readme.txt", since almost every grf author store the readme in readme.txt (and not more intelligently in NAME_OF_THE_GRF.txt), so unless you take care of it somehow (put grf's + txt's in zipfiles or directories ...), there will be many readmes overwriting each other (last downloaded readme wins :)
csuke wrote: -Link to site where source code will be available
If the patch is under license with mandatory source distribution (like GPL) ... for most of GRS's I see no source
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
csuke
Transport Coordinator
Transport Coordinator
Posts: 361
Joined: 05 Jun 2004 18:48
Location: London UK

Post by csuke »

i only put that in there to keep dalestan happy, he seems to keep harping on about it

and anyone who wants to distribute their grf's like this already has to add the required flags so i am sure it would not be too much bother to have them rename their .txt's
Image
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Post by DaleStan »

csuke wrote:-Name of accompanying file(s) that have to be downloaded with .grf
What if the server, for whatever reason, doesn't have those text files?
csuke wrote:--Link to site where source code will be available
That is not sufficient. The source offered must correspond exactly to the grf offered. The version on the website might have changed.
csuke wrote:Anyone who modifies someone elses .grf and redistributes it without/with a changed licence is breaking the original agreement

This is not the fault of the patch or OpenTTD so no problems there.

Any questions?
Do the words "Grokster" or "enablement" mean anything to you
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
Moriarty
Tycoon
Tycoon
Posts: 1395
Joined: 12 Jun 2004 00:37
Location: United Kingdom of Great Britain and Northern Ireland
Contact:

Re:

Post by Moriarty »

csuke wrote:Why are you lot just going round in circles?
I don't want to, but some people don't seem to be taking my points. :(

I still think dumping it all into a zip and distributing that would be simpler. If you didn't have a container like that you'd need to download to individual directories (for the "readme.txt" reason).
No pointers needed with zips and you're guaranteed to give what the grf makers want to give.


DaleStan wrote:
Moriarty wrote:
the license (which cannot be changed)
The license holder can change it at any time. :?
Ah. You seem to have a problem here. You are assuming that every GRF has exactly one license holder. This is not the case. Whenever there are multiple license holders, all have to agree to any change in the license. And silence is not "mark of the consent".
I'm aware of this, but I don't see how it's particularly pertinent to this topic. It can still be changed.
DaleStan wrote: Nothing requires that the source might be *bundled* with the GRF. It just has to be offered.
I'm really not seeing the problem here. We're going OVER the requirements - not only are we offering, it's mandatory if the newGRF creator put it in the zip.
Not to mention the fact that OpenTTD still doesn't know what to do with a ZIP file.
Then whoever codes the feature gets to add the functionality. I'm sure it'll end up being used for other things too.

DaleStan wrote:
csuke wrote:-Name of accompanying file(s) that have to be downloaded with .grf
What if the server, for whatever reason, doesn't have those text files?
csuke wrote:--Link to site where source code will be available
That is not sufficient. The source offered must correspond exactly to the grf offered. The version on the website might have changed.
Both of which are resolved via the zip-file method.

Do the words "Grokster" or "enablement" mean anything to you
I was under the impression that so long as you made adequate provisions and that the given purpose of your program was not to do it against the license, then you're pretty much clear. By this definition our suggested features are in the clear. Or do you know something we don't?


I really don't see why some folks are so averse to this. All the legalistic points have been resolved (and were several days ago), and the technical problems are all quite simple.
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: Re:

Post by DaleStan »

Moriarty wrote:
DaleStan wrote:You are assuming that every GRF has exactly one license holder. This is not the case. Whenever there are multiple license holders, all have to agree to any change in the license. And silence is not "mark of the consent".
I'm aware of this, but I don't see how it's particularly pertinent to this topic. It can still be changed.
No, it can't. Oracle is gone. And 459 isn't much easier to find. And those are just the two I know about.
Moriarty wrote:
DaleStan wrote:Nothing requires that the source might be *bundled* with the GRF. It just has to be offered.
I'm really not seeing the problem here. We're going OVER the requirements - not only are we offering, it's mandatory if the newGRF creator put it in the zip.
That wasn't the question I asked. What if the newgrf creator does not include the source, but instead provides two different downloads, one for the grf and the other for the source?
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
Moriarty
Tycoon
Tycoon
Posts: 1395
Joined: 12 Jun 2004 00:37
Location: United Kingdom of Great Britain and Northern Ireland
Contact:

Re: Re:

Post by Moriarty »

DaleStan wrote:That wasn't the question I asked. What if the newgrf creator does not include the source, but instead provides two different downloads, one for the grf and the other for the source?
Assuming the license states the source is required for distribution, and that the GRF is designed to work under OTTD, then I'd say it's their fault for not releasing a properly formatted file.
It's like blaming me for reading a secret document that the gov released accidentally without redacting (removing) the secret bits. They're the ones who screwed up, not me.
User avatar
Korenn
Tycoon
Tycoon
Posts: 1735
Joined: 26 Mar 2004 01:27
Location: Netherlands
Contact:

Re:

Post by Korenn »

DaleStan wrote:Not to mention the fact that OpenTTD still doesn't know what to do with a ZIP file.
save games are already compressed using zlib. All that's necessary to use .zip files is to write handlers for the archiving directory stuff.
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Re: Re:

Post by Rubidium »

Moriarty wrote:
DaleStan wrote:That wasn't the question I asked. What if the newgrf creator does not include the source, but instead provides two different downloads, one for the grf and the other for the source?
Assuming the license states the source is required for distribution, and that the GRF is designed to work under OTTD, then I'd say it's their fault for not releasing a properly formatted file.
It's like blaming me for reading a secret document that the gov released accidentally without redacting (removing) the secret bits. They're the ones who screwed up, not me.
The GPL license for example states that the distributor must give the downloader the original source code on request. So when you redistribute an old version and the original author has replaced the version on his website, the redistributor must give the downloader the source code upon request.

It does NOT say that the source and binary have to be in the same package. However, this means that anyone who wants to enable distribution (of a GPLed grf) by OTTD must have the source code of the version he is being distributing.
Or rather, when you fail to produce the source code of the GPLed grf that you are distributing, you are performing illegal business.

Ergo, it is not a problem of the original author as (s)he provides both the binary and source code of the GRF. The problem is really of the redistributor as (s)he has to be able give the source code of the binary when (s)he is (re)distributing the binary.
Moriarty
Tycoon
Tycoon
Posts: 1395
Joined: 12 Jun 2004 00:37
Location: United Kingdom of Great Britain and Northern Ireland
Contact:

Re: Downloadable Graphics from servers?

Post by Moriarty »

Ergo, it is not a problem of the original author as (s)he provides both the binary and source code of the GRF. The problem is really of the redistributor as (s)he has to be able give the source code of the binary when (s)he is (re)distributing the binary.
I understand the premise, however I'd disagree.
If the distributor knew about the flag (they'd have to to set it!), they'd also know about how the distribution method worked. Thus the problem IS their doing because they're knowingly releasing a package that will break their own license.
I appreciate it's a grey area, but as far as I can see (not a lawyer) it's still the publishers mistake.
User avatar
Zephyris
Tycoon
Tycoon
Posts: 2897
Joined: 16 May 2007 16:59

Re: Downloadable Graphics from servers?

Post by Zephyris »

Surely source code is not an issue with something like newgrf which is freely decompilable... Compare to 32bpp .pngs; these include an image and the embedded text to define offsets. If you were to distribute these under the GFDL then you wouldn't be expected to provide the "source code" of the offsets, as these can be freely extracted from the final product.
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Re: Downloadable Graphics from servers?

Post by Rubidium »

It does NOT decompile it into "readable" source code; it does a fair job, but it isn't the original source code. For example grfcodec has trouble determining whether something should be shown as a string or not. And remember that comments and indentation are an important factor in especially the source code of newgrfs.

So decompiled newgrf is NOT the source. It's like decompiling the OTTD binary and saying you have got the source of OTTD.
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Re: Downloadable Graphics from servers?

Post by Bilbo »

Zephyris wrote:Surely source code is not an issue with something like newgrf which is freely decompilable... Compare to 32bpp .pngs; these include an image and the embedded text to define offsets. If you were to distribute these under the GFDL then you wouldn't be expected to provide the "source code" of the offsets, as these can be freely extracted from the final product.
Well, the actual source code may be just the same as you would get from decompile, but with some useful comments added and something done better, like using word/byte "macros" instead of hex code where appropriate, etc ...

technically, same could be said for TTDPatch, as "you can decompile the binary and you get the asm source, minus just few comments and variable names" :)
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
DaleStan
TTDPatch Developer
TTDPatch Developer
Posts: 10285
Joined: 18 Feb 2004 03:06
Contact:

Re: Downloadable Graphics from servers?

Post by DaleStan »

Moriarty wrote:Assuming that ... the GRF is designed to work under OTTD
Ah-ha. "The use of this GRF in OpenTTD is entirely unsupported. Use at your own risk."
Oh. Wait. Was that not the result you wanted? I'm ever so sorry.
Moriarty wrote:Thus the problem IS their doing because they're knowingly releasing a package that will break their own license
No, they're not. YOU are responsible for ensuring that YOU comply with the license. No one else has any responsibility to make it easy, or even possible, for you to comply. YOU are the only one who can be blamed if you fail to comply.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
User avatar
Killer 11
Tycoon
Tycoon
Posts: 2463
Joined: 06 Jan 2004 18:38
Location: Kaunas, Lithuania
Contact:

Re: Downloadable Graphics from servers?

Post by Killer 11 »

Moriarty wrote:Thus the problem IS their doing because they're knowingly releasing a package that will break their own license
No, they're not. YOU are responsible for ensuring that YOU comply with the license. No one else has any responsibility to make it easy, or even possible, for you to comply. YOU are the only one who can be blamed if you fail to comply.[/quote]

I don't really know this legal stuff but if say some author uploaded a grf with a license in a rar file somewhere and i download it only to later see that his license has flaws that make his download site unusable with the grf that i have ALREADY downloaded IMO the guy would be the one to blame as he is the one that made a fundamentaly flawed license with witch breaking laws is UNAVOIDABLE.

Don't know how on topic this is tough.

More on topic stuff...

On the point that people know or don't know that htey're downloading it illegaly there is absolutely NO difference between autodl and ftp with loads of license-less grf's as people who download them don't know that htey are illegal becouse they simply CAN'T find any licenses. Most people don't know a thign about grf's as most of them don't visit this forum, i wouldn't be surprised if DaleStan's tunels are being used in a lot of servers disregarding thel icense completely or if people already have made that FTP thing.
Truth is noone can stop someone to make this patch and make his own compile farm that aplies this thing to the latest nightlies. And people would use it just becouse they CAN.

Main point is that if huge megacorporations can't stop people from breaking copyrights(heck even Steam is cracked :roll: ) then so can't we, regardless of a form of distribution be it either manula or automatic...
User avatar
nicfer
Director
Director
Posts: 529
Joined: 03 May 2005 20:50
Location: Somewhere in a country called Argentina

Re: Downloadable Graphics from servers?

Post by nicfer »

Well people, stop fighting and start acting like civilizated people.

As for the trouble, I vote for keeping the actual system, as doing this will be "Too much work for too low benefit". Why not code something better, like new industries, coloured nicks in multiplayer or ability to build lighthouses / transmitters yourself? :lol:.
Sorry for my english I am argentinian
TTO don't crashes in Windows XP; XP crashes TTO

Formerly known as UnderBuilder.

MyMiniCity
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Re: Downloadable Graphics from servers?

Post by Bilbo »

UnderBuilder wrote:As for the trouble, I vote for keeping the actual system, as doing this will be "Too much work for too low benefit". Why not code something better, like new industries
Belugas is working on it. Maybe he will appreciate some help, so 0.6.0 may come out sooner ...
UnderBuilder wrote:coloured nicks in multiplayer
Not a good idea, I prefer to recognize the company by the player color. It would be too fancy and will make a bit of mess in chat.
UnderBuilder wrote:or ability to build lighthouses / transmitters yourself? :lol:.
Why build something that is only decorative and can't be removed when you later need to?

Yes, there are many good ideas that can be worked on. Just I don't think the last two are amongst them :)
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
Post Reply

Return to “Graphics Development”

Who is online

Users browsing this forum: No registered users and 22 guests