Daylength Patch [12/09/2008] Compatibility: r14293

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Which daylength are you playing at?

1-5
53
41%
6-15
27
21%
15+
50
38%
 
Total votes: 130

Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Roujin »

oops, seems I uploaded the wrong file (or rather, forgot to save my changes). In fact, a closing bracket was missing in the above .diff, that's all :roll:

Here's the fixed one.
Attachments
daylength_r12930_fixed.diff
daylength patch for r12930
(30.28 KiB) Downloaded 235 times
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
Trond
Tycoon
Tycoon
Posts: 973
Joined: 25 Jan 2008 07:32
Location: Gamle Ørnenuten

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Trond »

Well, thanks for that one again Roujin... It compiles fine now, but it doesnt load my savegame from previous version... No biggie I guess, but just tought I'd let you know.

Error message: "EngineRenews: failed loading savegame: too many EngineRenews"

and after that this one pops up:
Clipboard01.jpg
Clipboard01.jpg (23.52 KiB) Viewed 6491 times
I guess it's time to start a new game again... *sigh*
..: Trond :.. because you deserve it! Image

The whole problem with the world is that fools and fanatics are always so certain of themselves,
and wiser people so full of doubts.
Bertrand Russell

MyGRFs: Norwegian Funny Town Names 4 | LOTR & WoW Town Names 2 | Islandic Town Names 1 | Random Norwegian Town Names
Favorites: GRFCrawler | ISR | WIKI | Now Playing: OpenTTD 1.3.2 w/YAPP 3.0-RC3.9ish
Anunnaki
Engineer
Engineer
Posts: 64
Joined: 16 Aug 2005 16:09
Location: Prague, Czech Republic

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Anunnaki »

Hi there,

this is unofficial update compatible with r132005, but withouth SL_PATCH_BASE parts, witch are used for load/save games, saved by older versions of daylenght patched game. So standard parts from svn r132005 are remaining there.
r13205-daypatch_unofficial.diff
It is update from existing update ROUJIN's daylength_r12930_fixed.diff update.
(23.71 KiB) Downloaded 174 times
Tiberius
Engineer
Engineer
Posts: 86
Joined: 17 Sep 2004 03:15

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Tiberius »

Version bump for r13374, also modified timetable interface to display hour/minute durations for extended daylength :D

EDIT: change to svn-diff style (actual code not modified at all)
I may implement/fix/tweak/eat/ditch it soon (or in distant future, if at all, so don't hold your breath).
If anyone want to be the one please implement it for us all 8)
Tiberius
Engineer
Engineer
Posts: 86
Joined: 17 Sep 2004 03:15

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Tiberius »

Updated to r13691, fixed a bug that overflows competitor starting timer when saving game.
Attachments
daylength_r13691.patch
(26.08 KiB) Downloaded 253 times
I may implement/fix/tweak/eat/ditch it soon (or in distant future, if at all, so don't hold your breath).
If anyone want to be the one please implement it for us all 8)
User avatar
SVW-Gigant
Engineer
Engineer
Posts: 28
Joined: 05 Jun 2008 20:12
Location: Bremen, HB, Germany
Contact:

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by SVW-Gigant »

Hello,
I´ve downloaded the newest daylength-patch file above me, but I dont know what I´ve to edit to make the days longer (from original to 2x or 4x or 20x experimential). I´ve also installed the cygwin, but there is no patch-/diff.exe. There´s no readme or other help. I´m beginner in this topic, so can anybody help me? Any google-search and links are not successful until yet. I´m using OTTD 0.6.1.
grz

PS: Like also German PMs :wink:
experience Northern Germany 2.1!
Tiberius
Engineer
Engineer
Posts: 86
Joined: 17 Sep 2004 03:15

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Tiberius »

I would suggest save your time from learning how to compile it, just fetch and play RCPP or TibPP instead :)
I may implement/fix/tweak/eat/ditch it soon (or in distant future, if at all, so don't hold your breath).
If anyone want to be the one please implement it for us all 8)
User avatar
SVW-Gigant
Engineer
Engineer
Posts: 28
Joined: 05 Jun 2008 20:12
Location: Bremen, HB, Germany
Contact:

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by SVW-Gigant »

Thx :D This is really the easiest way to change the day length...
experience Northern Germany 2.1!
Chico008
Traffic Manager
Traffic Manager
Posts: 143
Joined: 05 Mar 2008 10:56
Location: France

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Chico008 »

are you still developping Daylength patch ?
can you make an update for latest trunk please ?

thanks.
Nappe1
Traffic Manager
Traffic Manager
Posts: 175
Joined: 19 Jan 2004 17:25
Location: kotka or Savitaipale, Finland
Contact:

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Nappe1 »

Tiberius wrote:Updated to r13691, fixed a bug that overflows competitor starting timer when saving game.
Umm I was about to update this to 14173 but the tortoiseSVN says it's not diff or index is missing? :?
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Rubidium »

Nappe1 wrote:Umm I was about to update this to 14173 but the tortoiseSVN says it's not diff or index is missing? :?
TortoiseSVN is a lame tool for applying patches because it basically only supports what it makes itself. Patches made by other tools, that are valid patches, are not supported by TortoiseSVN. To apply them you need a proper tool for applying patches.
Nappe1
Traffic Manager
Traffic Manager
Posts: 175
Joined: 19 Jan 2004 17:25
Location: kotka or Savitaipale, Finland
Contact:

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Nappe1 »

Rubidium wrote:
Nappe1 wrote:Umm I was about to update this to 14173 but the tortoiseSVN says it's not diff or index is missing? :?
TortoiseSVN is a lame tool for applying patches because it basically only supports what it makes itself. Patches made by other tools, that are valid patches, are not supported by TortoiseSVN. To apply them you need a proper tool for applying patches.
though I might not have time to learn use another set of "proper tools" (as Tortoise SVN was recomended for this here when I first time worked with this patch.), what you would recommend to replace TortoiseSVN's patch tool? obiously I am in Windows (which many ppl think as lame OS) if that makes any difference.

EDIT: never mind... I noticed that whole settings structures have been completely re-written from scratch since this patch has last time updated and I am wayy too tired to start look around where all settings have went.
User avatar
BlueEagle_nl
Transport Coordinator
Transport Coordinator
Posts: 352
Joined: 28 Jan 2006 09:44
Skype: tilly5014
Location: Tillywood, The Netherlands

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by BlueEagle_nl »

Someone still working on Daylength?

And can someone update the Topic Title to the latest available release?
Nappe1
Traffic Manager
Traffic Manager
Posts: 175
Joined: 19 Jan 2004 17:25
Location: kotka or Savitaipale, Finland
Contact:

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Nappe1 »

I have something going on... at least fixing the autosave being every day as default. :)

but it is going to take a while before I post the update.
User avatar
andysine
Tycoon
Tycoon
Posts: 1050
Joined: 31 Mar 2006 14:07
Location: Bath, England

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by andysine »

I don't suppose someone could assist me...

I'm working on Mac OS X and I'm having trouble trying to add this patch to my copy of the trunk. I have very limited knowledge of Terminal, and although I previously successfully added YAPP to a build, I'm trying to do the same with this Daylength patch and having problems. I can roll back to r13691 easily enough, and apply the patch okay. I also have no trouble in updating my version to r14004 and compiling, but after I use the "make" command in Terminal, it fails. I know this is a very specific request, but in essence, all I'm after is an OS X bundle with YAPP (which I now know is in the trunk) with adjustable day-length. Of anyone already has an OS X app with daylength and YAPP, I'd be much obliged...

Thanks,

Andy
Age of Industry Replacement Set
Themed industry set for OpenTTD

The Greenest Valley
A beautiful scenario featuring Cardiff and the south Wales valleys

Mountains and Prairies
Huge scenario based on Western Canada
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by planetmaker »

andysine wrote:I'm working on Mac OS X and I'm having trouble trying to add this patch to my copy of the trunk. I have very limited knowledge of Terminal, and although I previously successfully added YAPP to a build, I'm trying to do the same with this Daylength patch and having problems. I can roll back to r13691 easily enough, and apply the patch okay. I also have no trouble in updating my version to r14004 and compiling, but after I use the "make" command in Terminal, it fails. I know this is a very specific request, but in essence, all I'm after is an OS X bundle with YAPP (which I now know is in the trunk) with adjustable day-length. Of anyone already has an OS X app with daylength and YAPP, I'd be much obliged...
My guess is that this patch does not apply to trunk anymore without code changes.
This is what I do in dir where I previously did some svn checkout in order to patch the source:

svn revert
svn up -r <revision>
patch -p0 < patchfilename
./configure
make

Both, the third line (patch...) as well as the last line (make) may fail.
patching will fail, if any of the HUNKs didn't succeed to apply. You'll get notification telling you that in the patch's output. If so: Updating of the patch is required or rolling back the revision of your checkout
make may also fail with error. Then, again, code modification or a roll back to the proper svn revision is required
Last but not least, not everything which compiles necessarily results in a working binary as you easily may programm something which triggers assertions or plain crashes.

To be more specific, it will help, if you paste the output you get in paste.openttd.org and post a link here.
User avatar
andysine
Tycoon
Tycoon
Posts: 1050
Joined: 31 Mar 2006 14:07
Location: Bath, England

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by andysine »

Okay, I think I've done that correctly.

http://paste.openttd.org/81668 - there's a lot of red text there! I take it thats not a great sign!?
Age of Industry Replacement Set
Themed industry set for OpenTTD

The Greenest Valley
A beautiful scenario featuring Cardiff and the south Wales valleys

Mountains and Prairies
Huge scenario based on Western Canada
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by planetmaker »

Hi,
andysine wrote:Okay, I think I've done that correctly.

http://paste.openttd.org/81668 - there's a lot of red text there! I take it thats not a great sign!?

Code: Select all

Hunk #1 FAILED at 1.
# 1 out of 87 hunks FAILED -- saving rejects to file src/table/namegen.h.rej
This is the main problem. You should try to apply the patch to the version is was written for; the author will tell in the posting where he released it. Obviously it's not 14004.

It compiled, but the version you compiled might have issues in some places.
User avatar
Gremnon
Tycoon
Tycoon
Posts: 1517
Joined: 16 Sep 2005 12:23
Skype: the_gremnon
Location: /home
Contact:

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by Gremnon »

Actually, I managed to get this to compile perfectly with a recent build. I don't have the exact revision number to hand, but I can find out if it's necessary.
All I did was use the instructions at the end of the BuildOTTD thread for using it's compiler without it, and it runs perfectly.

Edit: Ok, I didn't fully read it, I didn't notice it wasn't a win32 build. My bad.
chrissicom
Route Supervisor
Route Supervisor
Posts: 415
Joined: 07 Oct 2004 10:05

Re: Daylength Patch [03/09/2007] Compatibility: r11060

Post by chrissicom »

The patch was built for r11060 and is compatible to the current trunk revision afaik. Although you need to change some lines to make it work otherwise the patchfile is not applied properly. The logic of this patch should still work fine though I think.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 11 guests