Tim's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

timofp
Engineer
Engineer
Posts: 50
Joined: 09 Oct 2010 13:04

Tim's Patch Pack

Post by timofp »

After some weeks of work. I present you the first version of my patchpack. At the moment it's a collection of patches I like, but suggestions are welcome. Some popular and recent patches are included as well as some older patches.

Based on OTTD Version 1.5.1-RC1
Compiled with Intel C++ Compiler for better performance.

Included Patches
01. Town Cargo Generation Factor http://www.tt-forums.net/viewtopic.php? ... 99&start=0
02. Day Length http://www.tt-forums.net/viewtopic.php?t=42432
03. Increased Max Loan (Own Work)
04. Infrastructure Sharing http://www.tt-forums.net/viewtopic.php?t=42254
05. Group Info http://www.tt-forums.net/viewtopic.php?f=33&t=72855
06. Trip History http://www.tt-forums.net/viewtopic.php?f=2&t=33411
07. Departure Boards viewtopic.php?f=33&t=49956
08. Show Station Coverage http://www.tt-forums.net/viewtopic.php?t=44835
09. Control Initial City Size http://www.tt-forums.net/viewtopic.php?f=33&t=70655
10. Advanced Train Purchase Window http://www.tt-forums.net/viewtopic.php?f=33&t=70964
11. Wait at Depot http://www.tt-forums.net/viewtopic.php?f=33&t=70969
12. Safe Level Crossing http://www.tt-forums.net/viewtopic.php?t=46091
13. Minimum Town Distance http://www.tt-forums.net/viewtopic.php?t=33625
14. Measurement Tool http://www.tt-forums.net/viewtopic.php?f=33&t=49212
15. Station Rating (Own Work based on http://www.tt-forums.net/viewtopic.php?t=66892)
16. Enhanced Viewport viewtopic.php?f=33&t=53394
17. Chunnel http://www.tt-forums.net/viewtopic.php?t=41775
18. Signals on Bridges and Tunnels http://www.tt-forums.net/viewtopic.php? ... 60&start=0
19. Upgrade Airpots http://www.tt-forums.net/viewtopic.php?t=35867
10. More Conditional Orders http://www.tt-forums.net/viewtopic.php?t=38317
21. Timetable All Stops http://www.tt-forums.net/viewtopic.php?f=32&t=50274
22. ATC Control http://www.tt-forums.net/viewtopic.php?t=52085
23. Logic Signals http://www.tt-forums.net/viewtopic.php?f=33&t=68436
24. Reduce Tree Growth http://www.tt-forums.net/viewtopic.php?t=45502
25. Poly Tracks http://www.tt-forums.net/viewtopic.php?t=57080
26. Old Tracks http://www.tt-forums.net/viewtopic.php?t=32285
27. Max GRF to 255 (Own Work)
28. Editor Tools (Rivers, Large & Random Towns, Expand Towns) in Game
29. Place Individual Buildings http://www.tt-forums.net/viewtopic.php?f=33&t=68894. Modified the patch so it's also possible ingame, not only in editor.
30. Build & Refit http://www.tt-forums.net/viewtopic.php?f=33&t=35805
31. Tree Height with snowline http://www.tt-forums.net/viewtopic.php?f=33&t=72502
32. Modified Town Zones (Own Work), something I'm working on. Enabling this setting modifies the town zone behaviour for the first 200 houses. It now takes longer before zone 1 and 2 is created. This has the effect that (depending on the house set), it will take longer before higher density buildings will appear.

64Bit Windows version and Source are below (32Bit version will follow later).

Enjoy!
Attachments
TPP_v1.02.rar
Windows 64Bit
(9 MiB) Downloaded 654 times
1.5.1-RC1.part1.rar
Source Part 1
(8 MiB) Downloaded 292 times
1.5.1-RC1.part2.rar
Source Part 2
(2.49 MiB) Downloaded 292 times
Last edited by timofp on 02 Jun 2015 12:30, edited 5 times in total.
User avatar
kamnet
Moderator
Moderator
Posts: 8589
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: Tim's Patch Pack

Post by kamnet »

In your next version, would you consider adding:
- Local Authority Zoning
- Increased NewGRF limit for single player

Also, any chance of a Win32 binary our source code? I'm using using a 32-bit version of Windows 7 on my desktop.
User avatar
Mizari
Traffic Manager
Traffic Manager
Posts: 136
Joined: 22 Apr 2012 14:21

Re: Tim's Patch Pack

Post by Mizari »

Does it lack automatic timetable spacing?
timofp
Engineer
Engineer
Posts: 50
Joined: 09 Oct 2010 13:04

Re: Tim's Patch Pack

Post by timofp »

kamnet wrote:In your next version, would you consider adding:
- Local Authority Zoning
- Increased NewGRF limit for single player

Also, any chance of a Win32 binary our source code? I'm using using a 32-bit version of Windows 7 on my desktop.
Visual Studio is giving me some problems with compiling the 32 Bit version, I will try to solve it or use MinGW and provide you with a 32Bit version.

I will surely change the NewGRF limit and will take a look at the Local Authority Zoning, it's on my list of possible inclussions.
Mizari wrote:Does it lack automatic timetable spacing?
I'm not a fan of it, I like to do it manually. That's why I didn't include it. However, I will take a look at including it if possible.
User avatar
FLHerne
Tycoon
Tycoon
Posts: 1543
Joined: 12 Jul 2011 12:09
Location: St Ives, Cambs, UK

Re: Tim's Patch Pack

Post by FLHerne »

Basing patchpacks off stable releases is usually not the best choice, as they're forked off the main development branch.
If you later want to rebase your patchpack to contain newer features in trunk not backported to 1.5.x, it'll be more work than if it were based on a trunk version.
Temporary Permanent signature filling text. Content coming soon delayed indefinitely! Oh, and I have had a screenshot thread.
Linux user (XMonad DWM/KDE, Arch), IRC obsessive and rail enthusiast. No longer building robots; now I ring church bells.
Author of an incredibly boring stickied post about NewGRFs.
Eddi
Tycoon
Tycoon
Posts: 8272
Joined: 17 Jan 2007 00:14

Re: Tim's Patch Pack

Post by Eddi »

i disagree. making a patchpack based on a stable version might ease the maintenance effort and lets you focus more on which patches to include, instead of constantly rebasing on trunk revisions. you can then even cherry-pick some trunk features to include.

you probably do have to completely start all over when the next stable version is released.

it's a tradeoff that needs careful consideration, in any case.
User avatar
kamnet
Moderator
Moderator
Posts: 8589
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: Tim's Patch Pack

Post by kamnet »

As long as it's not being promoted as OpenTTD 1.5.x, I see no problem building a patch pack off of stable. It will offer the features that most players will be familiar with and not surprise them with what's coming down the line.
timofp
Engineer
Engineer
Posts: 50
Joined: 09 Oct 2010 13:04

Re: Tim's Patch Pack

Post by timofp »

Thank you for the feedback.

I've updated my Patch pack with these changes

New: Max GRF to 255 (Own Work)
New: Editor Tools (Rivers, Large & Random Towns) in Game (Own Work)

I've also added a 32Bit Windows version and both versions are now compiled using the Intel C++ Compiler for better performance.

I will try to implement the other requests later this weekend.
Ranz0r
Engineer
Engineer
Posts: 1
Joined: 24 May 2015 14:45

Re: Tim's Patch Pack

Post by Ranz0r »

Hi Tim,
great work! Thank you.

Could you release the sources, so i can compile a linux version, or if you prefer, could you compile a linux version?

Cheers,
Ranz0r
User avatar
te_lanus
Transport Coordinator
Transport Coordinator
Posts: 326
Joined: 19 Jul 2012 18:04
Location: The Elizabeth Arkham Asylum for the Criminally Insane

Re: Tim's Patch Pack

Post by te_lanus »

timofp wrote: I've also added a 32Bit Windows version and both versions are now compiled using the Intel C++ Compiler for better performance.

I will try to implement the other requests later this weekend.
:( 32bit doesn't work on XP
timofp
Engineer
Engineer
Posts: 50
Joined: 09 Oct 2010 13:04

Re: Tim's Patch Pack

Post by timofp »

Ranz0r wrote:Hi Tim,
great work! Thank you.

Could you release the sources, so i can compile a linux version, or if you prefer, could you compile a linux version?

Cheers,
Ranz0r
I will clean up the sources and release them with the next version.
te_lanus wrote:
timofp wrote: I've also added a 32Bit Windows version and both versions are now compiled using the Intel C++ Compiler for better performance.

I will try to implement the other requests later this weekend.
:( 32bit doesn't work on XP
What error do you get? I didn't test it on XP, but it might be related to the Intel Compiler.
User avatar
te_lanus
Transport Coordinator
Transport Coordinator
Posts: 326
Joined: 19 Jul 2012 18:04
Location: The Elizabeth Arkham Asylum for the Criminally Insane

Re: Tim's Patch Pack

Post by te_lanus »

timofp wrote: What error do you get? I didn't test it on XP, but it might be related to the Intel Compiler.
Error program cannot be run (5) or something like that
LarryGolade
Engineer
Engineer
Posts: 17
Joined: 23 Aug 2014 17:22

Re: Tim's Patch Pack

Post by LarryGolade »

with a patch for automatically filling timetable and it will be perfect
Last edited by LarryGolade on 27 May 2015 07:11, edited 1 time in total.
timofp
Engineer
Engineer
Posts: 50
Joined: 09 Oct 2010 13:04

Re: Tim's Patch Pack

Post by timofp »

LarryGolade wrote:with a path for automatically filling timetable and it will be perfect
Not something I like, but I will try to add it.
I also spend almost a whole day during last weekend on trying to add the zoning patch, but was not succesful.

Next update will for sure include
- House picker, build any house from the gui, both in editor and in game
- modified Town generation, I'm experimenting with creating this, it modifies the town zone calculation in such a way that your village has to be larger before inner zone (in most set larger buildings) appear. This way, you can have more realistic sized villages and not all villages become filled with skyscrapers.
- some other smaller patches like build and refit.

I will also provide a non MS Visual Compiled 32Bit binnery, this might fix the WinXP issue, and I will provide the source code for the people who want to compile for a different platform.
sziha
Engineer
Engineer
Posts: 27
Joined: 30 Jul 2013 19:47
Location: Vancouver, BC, Canada

Re: Tim's Patch Pack

Post by sziha »

timofp wrote:And I will provide the source code for the people who want to compile for a different platform.
Yes, please!! For another couple months I'm stuck with a Macbook :D
I have my own Screenshot Topic! :o (!YaY!)
Arveen
Engineer
Engineer
Posts: 3
Joined: 30 May 2015 07:27
Location: DE / FFM
Contact:

Re: Tim's Patch Pack

Post by Arveen »

I really like the selection of patches here. Also looking up for the addition of the automatic-seperation patch.

I played around with it a bit and discovered a reproducible crash:

- Just build a simple track with a bridge in it, add depot and a train (no orders required - just let it go in a circle or so)
- Add a bridge to the track
- Add regular signals, also on the bridge
- Let the train run (works)
- Send the train back to the depot
- Remove the signals and replace them with One-Way-Path Signals
- Start the train again
- As soon as the train reserves the path onto the bridge with the signals the game crashs

Image

Crash Log:

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Sat May 30 07:36:27 2015
In game date: 1965-01-01 (45)

Crash reason:
 Exception: C0000005
 Location:  00007FF6266216BB
 Message:   <none>

OpenTTD version:
 Version:    1.5.1-RC1 (0)
 NewGRF ver: 15106a8c
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: May 24 2015 13:22:48

Registers:
 RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000 RDX: 0000000000001923
 RSI: 0000000000000003 RDI: 0000000000000001 RBP: 00000022F216C150 RSP: 00000022F216C120
 R8:  0000000000000000 R9:  0000000000000001 R10: 0000000000001923 R11: 00000022A0527010
 R12: 0000000000001923 R13: 000000000000FFFF R14: 0000000000000000 R15: 0000000000001923
 RIP: 00007FF6266216BB EFLAGS: 00010287

 Bytes at instruction pointer:
 49 8B 00 4C 89 C1 4C 89 45 08 FF 90 80 00 00 00 4C 8B 45 08 83 F8 10 0F

Stack trace:
 8266EF78 00000022 00000334 00000000 A14C8DE0 00000022 26713ECD 00007FF6
 00000000 00000000 F216C360 00000022 00000000 00000000 F228E600 00000022
 00000000 00000000 00001600 00007FF6 00000000 00000000 A14C8D00 00000022
 000003F3 0000002F 00000000 00000000 0000FFFF 00000022 A099F1D0 00000022
 FFFFFFFE FFFFFFFF A099F1D0 00000022 00744D50 00000000 27842966 00007FF6
 A099F1D0 00000022 A099F1D0 00000022 A099F1D0 00000022 A099F400 00000022
 00000000 00000000 26626111 00007FF6 F4146AF8 00000022 0000027C 000015E0
 000000E2 00000002 00000780 00000000 00000000 00000000 266FFEC5 00007FF6
 00000000 00000000 A0216170 00000022 00000000 00000000 FFFFFFFE FFFFFFFF
 A099F1D0 00000022 A099F1D0 00000022 00744D50 00000000 27842966 00007FF6
 00000000 00000000 A099F478 00000022 A099F1D0 00000022 A099F478 00000022
 00000000 00000000 26622C02 00007FF6 8269AE90 00000022 00000286 00000000
 000015E8 00000022 A0217110 00000022 000001B0 00000000 A099F1D0 00000022
 00000000 00000000 F216C360 00000022 000003D6 00000000 00000334 00000000
 0000044B 00000000 F216C300 00000022 A0217110 00000022 26714C87 00007FF6
 00000116 00000000 000000E5 00000000 00000017 00000000 00000116 00000000
 000016C2 00000000 00000002 00000000 000003D6 00000000 F216C3F0 00000022
 A099F1D0 00000022 00744D50 00000000 27842966 00007FF6 00000000 00000000
 00000000 00000000 00000000 00000000 A099F1D0 00000022 2662254E 00007FF6
 000003A9 00000000 0000011A 00000000 00000015 00000000 000003A9 00000000
 00744D50 00000000 266CFAA5 00007FF6 A16EE750 00000022 2671D51E 00007FF6
 A099F1D0 00000022 269AFE27 00007FF6 000000B6 00000000 000000E7 00000000
 000000A0 00000000 00000000 00000000 FFFFFFFE FFFFFFFF 00000000 00000000
 26A36400 00007FF6 00000000 00000000 00000000 00000000 00744D50 00000000

Operating system:
 Name:     Windows
 Release:  6.2.9200 ()
 Compiler: MSVC 1700

Configuration:
 Blitter:      32bpp-anim
 Graphics set: OpenGFX (5580)
 Language:     C:\Games\OTTD-TimsPP\lang\english_US.lng
 Music driver: win32
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: win32
 Sound set:    OpenSFX (87)
 Video driver: win32

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0):
  0: Human

Libraries:
 FreeType:   2.4.11
 ICU:        51.2
 LZMA:       5.0.4
 LZO:        2.06
 PNG:        1.5.14
 Zlib:       1.2.7

Module information:
 C:\Games\OTTD-TimsPP\openttd.exe handle: 00007FF6264B0000 size: 16316416 crc: 5636EE20 date: 2015-05-24 11:27:44
 C:\Windows\SYSTEM32\ntdll.dll handle: 00007FF9CA650000 size: 1733952 crc: 5517429E date: 2015-03-23 21:59:25
 C:\Windows\system32\KERNEL32.DLL handle: 00007FF9C9E40000 size: 1309744 crc: 8327D87F date: 2014-10-29 04:09:24
 C:\Windows\system32\KERNELBASE.dll handle: 00007FF9C7A50000 size: 1133200 crc: C4E2F54B date: 2014-10-29 03:55:08
 C:\Windows\SYSTEM32\WINMM.dll handle: 00007FF9C3D20000 size: 126056 crc: 7659EB7B date: 2014-10-29 03:52:43
 C:\Windows\system32\WS2_32.dll handle: 00007FF9C8010000 size: 363080 crc: FEC14C29 date: 2014-10-29 03:51:53
 C:\Windows\system32\IMM32.dll handle: 00007FF9C7CD0000 size: 210744 crc: 7F26DDC8 date: 2014-10-29 04:00:23
 C:\Windows\system32\USER32.dll handle: 00007FF9C8080000 size: 1540696 crc: 10D1C3D1 date: 2014-10-29 04:00:24
 C:\Windows\system32\GDI32.dll handle: 00007FF9C9A00000 size: 1385216 crc: E25AD224 date: 2014-10-29 04:00:24
 C:\Windows\system32\ADVAPI32.dll handle: 00007FF9C9D90000 size: 685408 crc: F1EC28BC date: 2014-10-29 03:54:14
 C:\Windows\system32\SHELL32.dll handle: 00007FF9C8420000 size: 22291584 crc: F57E06A8 date: 2015-02-12 17:40:58
 C:\Windows\SYSTEM32\WINMMBASE.dll handle: 00007FF9C3AC0000 size: 161120 crc: 43BDBD7D date: 2014-10-29 03:52:43
 C:\Windows\system32\msvcrt.dll handle: 00007FF9CA4D0000 size: 687496 crc: AB7BF219 date: 2014-10-29 03:53:30
 C:\Windows\system32\NSI.dll handle: 00007FF9C7FA0000 size: 24800 crc: EA0F476C date: 2014-10-29 03:51:53
 C:\Windows\system32\RPCRT4.dll handle: 00007FF9C9F80000 size: 1310912 crc: C3D72688 date: 2014-10-29 03:51:53
 C:\Windows\system32\MSCTF.dll handle: 00007FF9C7D80000 size: 1385256 crc: 432F61C2 date: 2015-03-14 08:20:01
 C:\Windows\SYSTEM32\sechost.dll handle: 00007FF9C9B70000 size: 360480 crc: 19E9E10C date: 2015-03-23 21:59:25
 C:\Windows\SYSTEM32\combase.dll handle: 00007FF9C8200000 size: 2174976 crc: 98B4DD2D date: 2014-10-29 03:55:46
 C:\Windows\system32\SHLWAPI.dll handle: 00007FF9C7FB0000 size: 339312 crc: 557A1A0C date: 2014-10-29 03:57:40
 C:\Windows\SYSTEM32\cfgmgr32.dll handle: 00007FF9C7C80000 size: 315576 crc: C6A55E14 date: 2014-10-29 04:09:27
 C:\Windows\SYSTEM32\DEVOBJ.dll handle: 00007FF9C6590000 size: 155456 crc: 027D4AD1 date: 2014-10-29 04:09:23
 C:\Windows\SYSTEM32\SHCORE.dll handle: 00007FF9C5CF0000 size: 723072 crc: 8E0C4760 date: 2015-01-23 07:17:39
 C:\Windows\system32\uxtheme.dll handle: 00007FF9C6410000 size: 1192960 crc: 473B2300 date: 2014-10-29 02:50:45
 C:\Windows\system32\dwmapi.dll handle: 00007FF9C5AF0000 size: 125504 crc: F24873F8 date: 2014-10-29 04:00:24
 C:\Windows\system32\ole32.dll handle: 00007FF9CA2D0000 size: 1660528 crc: 398DF8A6 date: 2014-10-29 03:55:47
 C:\Windows\SYSTEM32\kernel.appcore.dll handle: 00007FF9C65E0000 size: 33064 crc: 46564BB7 date: 2014-10-29 04:09:27
 C:\Windows\SYSTEM32\CRYPTBASE.dll handle: 00007FF9C7780000 size: 31528 crc: 48DECD65 date: 2014-10-29 03:51:52
 C:\Windows\SYSTEM32\bcryptPrimitives.dll handle: 00007FF9C75A0000 size: 397192 crc: 86B758AD date: 2014-10-29 04:04:55
 C:\Windows\system32\mswsock.dll handle: 00007FF9C6FB0000 size: 339456 crc: 65010040 date: 2014-10-29 01:29:43
 C:\Windows\SYSTEM32\MMDevAPI.DLL handle: 00007FF9C41B0000 size: 444728 crc: 9D748D54 date: 2014-10-29 03:52:43
 C:\Windows\SYSTEM32\wdmaud.drv handle: 00007FF9B3070000 size: 228864 crc: B12B8E56 date: 2014-10-29 01:10:10
 C:\Windows\SYSTEM32\ksuser.dll handle: 00007FF9C13A0000 size: 22208 crc: 52213363 date: 2014-10-29 03:52:43
 C:\Windows\SYSTEM32\AVRT.dll handle: 00007FF9C56F0000 size: 35664 crc: 93162AF9 date: 2014-10-29 03:57:45
 C:\Windows\SYSTEM32\AUDIOSES.DLL handle: 00007FF9B7530000 size: 500016 crc: 16CF52F4 date: 2014-10-29 03:52:49
 C:\Windows\system32\OLEAUT32.dll handle: 00007FF9CA580000 size: 788680 crc: 2576FAE6 date: 2014-12-19 08:57:44
 C:\Windows\SYSTEM32\powrprof.dll handle: 00007FF9C7710000 size: 277368 crc: 7D42587C date: 2014-10-29 04:09:26
 C:\Windows\SYSTEM32\msacm32.drv handle: 00007FF9C2BD0000 size: 26624 crc: DB5F4CD1 date: 2014-10-29 02:37:22
 C:\Windows\SYSTEM32\MSACM32.dll handle: 00007FF9C2A50000 size: 106384 crc: CAA1FA35 date: 2014-10-29 03:52:43
 C:\Windows\SYSTEM32\midimap.dll handle: 00007FF9C2200000 size: 23552 crc: 5011F5F8 date: 2014-10-29 02:42:51
 C:\Windows\system32\psapi.dll handle: 00007FF9C8070000 size: 17560 crc: 4B24A606 date: 2014-10-29 04:09:24

---- gamelog start ----
Tick 0: new game started
Revision text changed to 1.5.1-RC1, savegame version 300, not modified, _openttd_newgrf_version = 0x15106a8c
New game mode: 1 landscape: 0
Added NewGRF: GRF ID F1250005, checksum 955C122CEFCC91F1EDAB646F7DF7D141, filename: firs_industry_replacement_set-1.4.4\firs.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 52577801, checksum 20B5D8122F2B4AD74ADDA30E44BA8233, filename: opengfx_biggui-2.0.0\ogfx-biggui.grf (md5sum matches)
Added NewGRF: GRF ID 46727806, checksum BBE029FCDD7A16F85876D417FF318D23, filename: opengfx_trees-0.8.0\opengfx+trees.grf (md5sum matches)
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2\ogfx-airports.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B33, checksum 437E4F6BDA52EB5CA9615196291514CA, filename: opengfx_industries-version\ogfx-industries.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum 136D889FDAEAA3491F8320248A04425C, filename: opengfx_landscape-1.1.2\ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B32, checksum B46F2D7781158DD122F2E4B2AFC9F38F, filename: opengfx_road_vehicles-0.4.1\ogfx-rv.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B31, checksum 4E0B2D42462F295F36AFBA90D239A323, filename: opengfx_trains-0.3.0\ogfx-trains.grf (md5sum matches)
Added NewGRF: GRF ID 4A530117, checksum CA32127C974FD70434F9CA4E0AD4A501, filename: ecs__firs_vehicle_set-2014.11.26\efrefit.grf (md5sum matches)
Added NewGRF: GRF ID 56420202, checksum 1AFF9BDD5893C71281911C405D3246C1, filename: purr_universal_rainbow_rails-0.0.3\purr.grf (md5sum matches)
Added NewGRF: GRF ID 74677462, checksum 1D2A4E03D9F30922788C166254C27619, filename: total_bridge_renewal_set-1.2\total_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 444E0700, checksum 48B3F9E4FD0DF2A72B5F44D3C8A2F4A0, filename: universal_rail_type-2.0.1\universalrailtype.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21\pb_av8w.grf (md5sum matches)
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] openttd              0x00007FF6266216BB
[01] openttd              0x00007FF626626111
[02] openttd              0x00007FF626622C02
[03] openttd              0x00007FF62662254E
[04] openttd              0x00007FF6266CFAA5
[05] openttd              0x00007FF6266C5191
[06] openttd              0x00007FF62699FE94
[07] openttd              0x00007FF6269A9C95
[08] openttd              0x00007FF6265E61A8
[09] openttd              0x00007FF6265E4CEE
[10] openttd              0x00007FF6265A7BEE
[11] KERNEL32             0x00007FF9C9E413D2 BaseThreadInitThunk + 34
[12] ntdll                0x00007FF9CA665444 RtlUserThreadStart + 52

*** End of additional info ***

jimmydanny
Engineer
Engineer
Posts: 123
Joined: 26 Mar 2006 17:39
Location: jim-tore@oshaug.com

Re: Tim's Patch Pack

Post by jimmydanny »

Following! Too few patchpacks out these days! I see a lot of things I like in the list, I will finish my game in Spring PP, and try yours out, see if there is anything I personally miss, and I'll tell you :) More patches isn't bad, except for you when you have 1000 errors while compiling the newest version! More patches=more features. All can be disabled if you want so ;)
Intel Core i7-3930K @ 4,0GHz, 16GB DDR3, AMD Radeon HD 6970, Intel 530 SSD
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: Tim's Patch Pack

Post by planetmaker »

timofp wrote: I will clean up the sources and release them with the next version.
I would strongly suggest to do that for *every* version where you provide binaries - including those which you already released. Make sources available for the same place, time and method you provide binaries. You're obliged to do so. It is *the major* condition under which you were given the code to toy with in the first place (read: you are currently in violation of the copyright of several dozen people, including all moderators of this forum section ;) ).
timofp
Engineer
Engineer
Posts: 50
Joined: 09 Oct 2010 13:04

Re: Tim's Patch Pack

Post by timofp »

An Update

A few new patches
Place Individual Buildings http://www.tt-forums.net/viewtopic.php?f=33&t=68894. Modified the patch so it's also possible ingame, not only in editor.
Build & Refit http://www.tt-forums.net/viewtopic.php?f=33&t=35805
Tree Height with snowline http://www.tt-forums.net/viewtopic.php?f=33&t=72502
Modified Town Zones (Own Work), something I'm working on. Enabling this setting modifies the town zone behaviour for the first 200 houses. It now takes longer before zone 1 and 2 is created. This has the effect that (depending on the house set), it will take longer before higher density buildings will appear.

On your feedback
planetmaker wrote:
timofp wrote: I will clean up the sources and release them with the next version.
I would strongly suggest to do that for *every* version where you provide binaries - including those which you already released. Make sources available for the same place, time and method you provide binaries. You're obliged to do so. It is *the major* condition under which you were given the code to toy with in the first place (read: you are currently in violation of the copyright of several dozen people, including all moderators of this forum section ;) ).
Thank you for the heads up, I did provide the sources earlier, but I removed them when uploading the 32Bit version (thought there was a max limit on number of attachments, but it seemed to be the size of attachments). But I will make sure to always provide sources in the future.
Arveen wrote:I really like the selection of patches here. Also looking up for the addition of the automatic-seperation patch.

I played around with it a bit and discovered a reproducible crash:

- Just build a simple track with a bridge in it, add depot and a train (no orders required - just let it go in a circle or so)
- Add a bridge to the track
- Add regular signals, also on the bridge
- Let the train run (works)
- Send the train back to the depot
- Remove the signals and replace them with One-Way-Path Signals
- Start the train again
- As soon as the train reserves the path onto the bridge with the signals the game crashs

[/code]
This seems to be a known bug with the signals on/in bridges/tunnels patch combined with the ATC patch. Some other patch packs also encounter this. I will try to look into it, but can't guarantee a sollution. A "fix/workaround" is always placing at least one block signal before and after the tunnel.
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: Tim's Patch Pack

Post by romazoon »

very nice compilation of patches ! thanks for sharing !

one question though : why are most of existing scenario "not loadable" in your patchpack ?
So far the only scenario i was able to load in your patchpack are dating back from TTD patch and TTD !!!
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 31 guests