ECS vectors v1.1.2 (by George) 19/06/2011

Discuss, get help with, or post new graphics for TTDPatch and OpenTTD, using the NewGRF system, here. Graphics for plain TTD also acceptable here.

Moderator: Graphics Moderators

Do you use ECS with TTDP?

I use ECS under TTDP
5
3%
I use ECS under TTDP and OTTD
6
4%
I use ECS under OTTD
158
93%
 
Total votes: 169

User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

I've added displaying of stockpile size in the industry window. Green text indicates accepting, red - no accepting
Unfortunately, CB 37 code depends on accepting code, so I ask you to make testing of industry accepting.
I've uploaded files to http://george.zernebok.net/newgrf/downloads.html as soon as someone would report that everything works fine, I'll update bananas too.
Image Image Image Image
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Please report if someone is testing the GRFs.
Image Image Image Image
Blood Angel
Engineer
Engineer
Posts: 63
Joined: 19 Mar 2004 12:35
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by Blood Angel »

I'm testing now.

a bug in previous "release": I set parameters to 15 (for unlimited accepting) but when stockpile size is full cargo accepting but now money :( I found the bug in cement works with sand...
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Blood Angel wrote:I'm testing now.
a bug in previous "release": I set parameters to 15 (for unlimited accepting) but when stockpile size is full cargo accepting but now money :( I found the bug in cement works with sand...
Please make a list of industries that have this bug - I can't reproduce this bug for cement works and sand.
Image Image Image Image
Spedichef
Engineer
Engineer
Posts: 12
Joined: 21 Mar 2005 11:36

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by Spedichef »

Using all ECS of Nov 14 will cause an error with program termination in the scenario editor, when I clicking the button to place industries. Runtime error shows up under rev 18000 and rev 18081. Picture attached.
Attachments
error_revn18081.png
error_revn18081.png (49.39 KiB) Viewed 3160 times
Blood Angel
Engineer
Engineer
Posts: 63
Joined: 19 Mar 2004 12:35
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by Blood Angel »

George wrote:
Blood Angel wrote:I'm testing now.
a bug in previous "release": I set parameters to 15 (for unlimited accepting) but when stockpile size is full cargo accepting but now money :( I found the bug in cement works with sand...
Please make a list of industries that have this bug - I can't reproduce this bug for cement works and sand.
on first screenshot you can see not full stockpile on cement works and 141 thousands $ as income
Water Transport, 8th Mar 1930.png
first
(67.68 KiB) Downloaded 2 times
on second full stockpile on cement works and only 9 thousands $ as income
Water Transport, 17th Jun 1931.png
second
(66.97 KiB) Downloaded 2 times
all parameters seted as 15.. build is r18081 for macos
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Spedichef wrote:Using all ECS of Nov 14 will cause an error with program termination in the scenario editor, when I clicking the button to place industries. Runtime error shows up under rev 18000 and rev 18081. Picture attached.
R18081 - can't reproduce. Please give more information
Image Image Image Image
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Blood Angel wrote:
George wrote:
Blood Angel wrote:I'm testing now.
a bug in previous "release": I set parameters to 15 (for unlimited accepting) but when stockpile size is full cargo accepting but now money :( I found the bug in cement works with sand...
Please make a list of industries that have this bug - I can't reproduce this bug for cement works and sand.
on first screenshot you can see not full stockpile on cement works and 141 thousands $ as income
Water Transport, 8th Mar 1930.png
on second full stockpile on cement works and only 9 thousands $ as income
Water Transport, 17th Jun 1931.png
all parameters seted as 15.. build is r18081 for macos
Please attach a savegame
But. imho, if you get ANY profit, you have to do nothing with industries. ECS does not provide any special cargo payment algorithms.
Image Image Image Image
Blood Angel
Engineer
Engineer
Posts: 63
Joined: 19 Mar 2004 12:35
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by Blood Angel »

George wrote: But. imho, if you get ANY profit, you have to do nothing with industries. ECS does not provide any special cargo payment algorithms.
is stockpile feature of openttd?

savegame attached
Attachments
Water Transport, 14th Jun 1931.sav
savegame
(47.66 KiB) Downloaded 101 times
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Blood Angel wrote:
George wrote: But. imho, if you get ANY profit, you have to do nothing with industries. ECS does not provide any special cargo payment algorithms.
is stockpile feature of openttd?
stockpile is feature of ECS, but it does nothing with cargo payment.
Image Image Image Image
Blood Angel
Engineer
Engineer
Posts: 63
Joined: 19 Mar 2004 12:35
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by Blood Angel »

George wrote:
Blood Angel wrote:
George wrote: But. imho, if you get ANY profit, you have to do nothing with industries. ECS does not provide any special cargo payment algorithms.
is stockpile feature of openttd?
stockpile is feature of ECS, but it does nothing with cargo payment.
is stockpile affect to confirm cargo? maybe it is confirm only small size of cargo (payment was only for spread between max stockpile and current stockpile)
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Blood Angel wrote:is stockpile affect to confirm cargo? maybe it is confirm only small size of cargo (payment was only for spread between max stockpile and current stockpile)
Stockpile only affects cargo acceptance (yes/no).
The possible reason is that a train came to the destination, found no cargo accepting, returned back, and again back to destination. The cargo was accepted there at the moment. Because it took 3 times more to travel, it was paid less.
Image Image Image Image
User avatar
kamnet
Moderator
Moderator
Posts: 8705
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by kamnet »

I think I found a bug with the Glass Works. I notice that the max coal and sand waiting to be process keeps flip-flopping between "45 max", "45 maax" and "0 max".
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

kamnet wrote:I think I found a bug with the Glass Works. I notice that the max coal and sand waiting to be process keeps flip-flopping between "45 max", "45 maax" and "0 max".
Please provide more information. I can't reproduce it.
Image Image Image Image
User avatar
kamnet
Moderator
Moderator
Posts: 8705
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by kamnet »

Here are a few screen shots along with my grflist. I'm not noticing it affecting my gameplay, money made or cargo output, everything seems as it was with the last released version of ECS.
ecs1.png
ecs1.png (99.8 KiB) Viewed 3068 times
ecs2.png
ecs2.png (98.78 KiB) Viewed 3068 times
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

kamnet wrote:Here are a few screen shots along with my grflist. I'm not noticing it affecting my gameplay, money made or cargo output, everything seems as it was with the last released version of ECS.
Please post a savegame
I suppose 2514 is the answer, but I want to be sure.

P.S. I never test/play the game before 1920 or after 2050, all the code assumes this range of dates. May be in some cases it causes the overflow, leading to unexpected behaviour. I need information to understand, reproduce and fix such bugs.
Image Image Image Image
Blood Angel
Engineer
Engineer
Posts: 63
Joined: 19 Mar 2004 12:35
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by Blood Angel »

Water Transport, 14th Jul 1949.png
(100.49 KiB) Downloaded 1 time
why are dyes red? (I've never transported dyes)
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Blood Angel wrote:
Water Transport, 14th Jul 1949.png
why are dyes red? (I've never transported dyes)
please post a savegame too
Image Image Image Image
User avatar
George
Tycoon
Tycoon
Posts: 4364
Joined: 16 Apr 2003 16:09
Skype: george-vb
Location: Varna, Bulgaria
Contact:

Re: ECS implementation by George: ECS vectors. Beta 5 25/10/2008

Post by George »

Blood Angel wrote:
Water Transport, 14th Jul 1949.png
why are dyes red? (I've never transported dyes)
This bug is fixed. It happened for vehicles factory.
Image Image Image Image
Post Reply

Return to “Graphics Development”

Who is online

Users browsing this forum: Google [Bot], Semrush [Bot] and 4 guests