Toolbar Overlap Fix v2 - in trunk since r11256

[BigBB]

Everytime you open a new toolbar for e.g. depots, stations, etc. it overlap the parent toolbar and so covered several buttons.

Two years ago richk67 made a patch (link) which moved the child toolbar exactly under the parent one. But he defined every child toolbar, this means that everytime a new child toolbar get into the game (by a patch or a NewGRF?) you have again a overlap toolbar.

So it's easier and dynamic to say which parent toolbars have sub toolbars who get moved. These two are WC_BUILD_TOOLBAR (for build railway/roads/ship docks/airports) and WC_SCEN_LAND_GEN (for landscaping).

Flyspray task

Have fun,
BigBB


There are two versions:
v2.2y - the child toolbar is under the parent one and a little bit to the right (like original)
v2.2xy - the child toolbar is under the parent one and the left side is under the left side of the parent one

[chrissicom]

That sounds very promising I'll test this with the signal gui, copy & paste gui etc.

And a happy welcome to the forums! always great to see new patch authors! One liners are the best hehe

[NukeBuster]

Did you add it to flyspray?

[BigBB]

Did you add it to flyspray?

Why? The devs can read (and/or ignore) it here as well as flyspray.

[DaleStan]

Because it's harder to ignore on FS.

[chrissicom]

I put this patch in my local build of ChrisIN and it works like a charm now I don't have to worry about fixing toolbar overlap fix anymore when adding new windows/buttons! So when the devs are quick the patch is in trunk before I upload the new ChrisIN

[BigBB]

Because it's harder to ignore on FS.

Yes your right, but e.g. the signal GUI patch: there were 7 (non-ottd)-devs involved (Hackykid / lucaspiller / Sacro / Ryalla / Hazelrah / BamBam / Bilbo) but nowhere an answer. Not in the both signal GUI threads here and here as well as not in the MiniIN thread here and not at the flyspray-thread here.

The first post of Hackykid was on Apr the 28 2005, 2 and 1/2 year ago...

So nobody knows what must be changed to get into trunk or if it never will be get into trunk.

It's okay if the devs don't answer every thread, but this ...

And this is why I posted here: "The devs can read (and/or ignore) it here as well as on flyspray."


Here a patch which change the x-coordinate too. Choose the one you like.

Edit: patch removed, see first post.

[Roujin]

well, maybe it's because of the complexity. if that patch you mentioned (with 7 people involved) is such a monster, maybe none of the devs can bring themselves to looking at the whole thing - but this patch of yours seems rather small, so chances are higher that someone will look at it. If it's only a few lines, someone will have the time to check it and tell you if it's alright or what is wrong.

small patches just have the advantage that they are probably accepted much faster than huge ones...

PS: even if it sounds sad, it's still the devs' choice if they want a patch or not - here a quote from belugas i just found somewhere..

[...]Now, users patch: There are a lot of users who propose us patches, for new features as well as for bug fixes. Or sometimes, simply to get over a problem they were facing. But those submitted patches are just suggestions, and not the future, bear that in mind.
One of the tasks we (devs) have to do is verify if the proposed patches would be good enough for inclusion in trunk, and eventually make suggestions to improve them. Some are, some are not.[...]

[BigBB]

PS: even if it sounds sad, it's still the devs' choice if they want a patch or not

Yes I know, I don't want to reproach so.. The devs do good work .

But first I wait till the people say what version is better: 2.0 or 2.1 .

[Roujin]

ok, that's reasonable.

I've tried both now, and i like version 2.1 better.

description for everyone else: 2.0 puts the window under the first one and like ~10 pixels to the right
whereas 2.1 puts the window exactly under the first one

[Octopussy]

Your Patch is very usefull.

Thanks

[BigBB]

I've started a poll to know which version is preferred.

[Octopussy]

I prefer the Y transformation

This patch is required and very simple. It would be fun to have it into the nightly !!

[BigBB]

A new version uploaded (v2.2). Now the patch is complete so I opened a flyspray task (see first post), too.

Have fun,
BigBB

[belugas]

And now i've closed the flyspay task because i've commited version xy in r11256.
Thanks

[BigBB]

Thank you belugas .

[richk67]

Fantastic. Thanks for taking my patch on and reworking it BigBB.