Patch: Centred X in close window button

[dev|ant]

Since my last patch got shot down, I thought I'd try another one liner: fixing the off centre X that is the close window button. Seemed to be a popular request in my last thread.

[webfreakz.nl]

Great!

Devs: Just merge this one, and don't complain about stuff, just do it....

[Dextro]

The only thing I have to say about this one is: MERGE NOW!

[Horse]

This is a good solotion for people with bad eyes.

Really don't close this topic ths is serious good for they people.

[Killer 11]

wahoooo! Teh X is in Teh Center now muhahaha

[Villem]

TTDPatch had this ages ago!
J/K

Good job, though i don't see why it needed to be done as i never noticed it..
and i doubt anyone casually playing is going to either..
oh well, one more patch to the big list of patches..

[Graphite]

Good job, though i don't see why it needed to be done as i never noticed it..

I personally believe that minor bugfixes are just as important as adding new content, but from the responses I see on the forums, most people seem to disagree. If every small issue in the game gets fixed alongside the big ones, then the final result is a smooth, consistent game with no pesky flaws or annoyances.

[Dextro]

Good job, though i don't see why it needed to be done as i never noticed it..

I personally believe that minor bugfixes are just as important as adding new content, but from the responses I see on the forums, most people seem to disagree. If every small issue in the game gets fixed alongside the big ones, then the final result is a smooth, consistent game with no pesky flaws or annoyances.

Need one say more?

[DaleStan]

Good job, though i don't see why it needed to be done as i never noticed it..
and i doubt anyone casually playing is going to either..

Something must be wrong with your eyes. Or your monitor.
It stands out like a skyscraper in the stone age.

(I would say "like a sore thumb", but that's cliched and insufficiently emphatic.)

[DeletedUser21]

Now we have someting to brag about!

'The 'X' is in the middle now! '

[webfreakz.nl]

Now we have someting to brag about!

'The 'X' is in the middle now! '

So is the X in your avatar!

btw:

Are you a Doom3 fanatic? (MarsCity UAC) ??

[DeletedUser21]

Nah, that was part of a little joke, about where you lived, and some tought that some of us came from mars, and I'm not hiding that.


But anyway, The X is centered, whats next?

[DaleStan]

Well, I went and made a nuisance of myself on IRC, and:

Code: Select all

  <DaleStan> Can anyone explan why this hasn't been committed yet? http://www.tt-forums.net/viewtopic.php?t=22243
    <Bjarni> yeah
    <Bjarni> the planets aren't in the right position for committing patches from the forum
 <peter1138> because it may or may not be correct ;p
<Prof_Frink> peter1138: check it then
<Prof_Frink> you can use it as an excuse not to do newstations
    <Bjarni> no, don't do that
 <peter1138> i have
    <Bjarni> the planets aren't in the right position to even look at diffs from the forum
    <Bjarni> they are all orbiting the sun, which makes forum diffs very evil
   <belugas> planets all orbiting the sun... you're right...  It is Soooo bad
      <Tron> DaleStan: it "solves" the problem in a totally wrong way, plus the style is incorrect
    <Bjarni> see
    <Bjarni> it's evil
      <Tron> and that webfreak guy should better shut up
  <DaleStan> Well, then, what's the right way?
      <Tron> i didn't even bother to look at the problem any closer
      <Tron> but pretending the char is one less wide than it is, isn't a valid solution

So, now you have your answer, webfreak: Both style and solution are incorrect. The former should be easy to fix, but the latter is more difficult.

[webfreakz.nl]

Why should I shut up? And I won't. We live in a free 'country' with rights of free speak so...

Let Tron first be active at the forum and then we'll talk later...
And saying I should shut-up doesn't make any sense to me, how does he know me? He looked here at the forum? Wow! Amazing...

[richk67]

Well, I went and made a nuisance of myself on IRC, and:

Code: Select all

  <Tron> but pretending the char is one less wide than it is, isn't a valid solution

So, now you have your answer, webfreak: Both style and solution are incorrect. The former should be easy to fix, but the latter is more difficult.

Well... is it a bug? Yes. Does this patch completely fix it? Yes. Is it elegant? No.

In my code, I would include the patch, but add a comment line:

Code: Select all

// kludge. needs recoding to OpenTTD standard

You can then search for all bits marked "kludge" to correct them in the future.

Anyway, last time I checked, the purpose of OpenTTD is to have a working program, not win the "most elegant (but buggy) code" competition.

[DaleStan]

Why should I shut up? And I won't. We live in a free 'country' with rights of free speak

In public, yes. On these forums, no, you don't.

The *GOVERNMENT* doesn't have the right to censor.[0] Contrary to popular belief, that does not apply to non-governmental organizations.
This is not a government-run forum, nor does it recieve any government money. Ergo any censorship that occurs on these forums is not government censorship, and hence legal.

Richk, a more standard marker of bad-but-working code is "FIXME"; see the coding style document for what OTTD uses.

[0] Ignoring for the moment that the fact that this is not true in all countries.

[matthijs]

Let Tron first be active at the forum and then we'll talk later...

Sorry to say, but OpenTTD development happens on IRC mainly, the forums are secondary. So, good you showed up on IRC, webfreakz.

You can then search for all bits marked "kludge" to correct them in the future.

We have to much messy code. If a bug is really critical, we might fix it in such a way for later rewrite. But for a minor bug like this, the cost of a messy fix doesn't outweigh the gain. Besides, in practice, anything scheduled to be "corrected in the future" will remain pending for way too long...

DevIant, can you explain why this fix works? Maybe we can help you finding a better solution for this problem. Also, stop by on IRC sometime :-)

[toholio]

Why should I shut up?

I suspect that Tron was responding to when you said "Devs: Just merge this one, and don't complain about stuff, just do it....". Ordering the devs about wont make you many friends.

And I won't. We live in a free 'country' with rights of free speak so...

Free speech doesn't apply with private forums. What can and can't be said here is up to Orudge.

Let Tron first be active at the forum and then we'll talk later...

Once you are active in the development of OpenTTD you can complain about its slow pace until then: don't.

[webfreakz.nl]

Let Tron first be active at the forum and then we'll talk later...

Sorry to say, but OpenTTD development happens on IRC mainly, the forums are secondary. So, good you showed up on IRC, webfreakz.

You can then search for all bits marked "kludge" to correct them in the future.

We have to much messy code. If a bug is really critical, we might fix it in such a way for later rewrite. But for a minor bug like this, the cost of a messy fix doesn't outweigh the gain. Besides, in practice, anything scheduled to be "corrected in the future" will remain pending for way too long...

DevIant, can you explain why this fix works? Maybe we can help you finding a better solution for this problem. Also, stop by on IRC sometime

The problem with IRC is nothing gets logged to the outside world, you can't read stuff said last week.

[DeletedUser21]

Maybe development is slow ATM, but ordering people around doesn't make it go faster. (ATM )