Windows and backdrops with gradients

boekabart · Post by **boekabart** » 02 Sep 2005 11:37

I've made a patch that allows you to turn on fancy looking 'gradients' for lots of the windows in OTTD. In my opinion, it gives OTTD a lot more modern look.

The result is pertty good already, although since we're currently still using a paletted drawing, the gradients are not always perfectly colored. I'm working on a dithering version for a little better results.

The patch is turned on by default since I think the performance hit is close to zero, I optimized the implementation pretty good.

I've attached a patch for both the 0401 and current trunk (2905). Have fun and I'll keep you informed on the developments with the gradient one.

bobingabout · Post by **bobingabout** » 02 Sep 2005 11:47

erm, this would be better with 32bpp.

boekabart · Post by **boekabart** » 02 Sep 2005 11:58

bobingabout wrote:erm, this would be better with 32bpp.

Really? DUH! But that's not in place yet, is it

!?
No, actually when I started this thing I was shocked that it was all still hardcore paletted (that the actual pixelbuffer we write to is), I was hoping that the pixel buffer would be 32 bpp and that the translation would be done wherever someone writes to it. I'm pretty sure (from the diffs between 2355 and 2905) that the guys up there are working on that, though... Anyway, I still wanted to do this to show that Cris Sawyer could had been years ahead of XP and OSX with this, even in paletted mode. Wait till you see the dithered results (I'm actually eager to see them too

). Anyway, I personally think it is already an improvement now..... just my 2 cents and 18 kb of diff

. I hope someone out there agrees with me and I definately think smth like this (more configurable, maybe) will be in later 32bpp releases.

boekabart · Post by **boekabart** » 02 Sep 2005 13:43

I finished a first version of dithering.
One little comment: It uses a static array to store all calculated gradient- and dither information, the total size of this array is now 256(colors)*64(gradient levels)*8(size of dithering info) bytes = 128 kb. Is this a problem on some of the platforms, if so I can rewrite it to a malloc. Still 128kb, but no longer in the static data segment.

The performance should be pretty good, no impact, I replaced the original memcpy with memcpys per 64 bits, shouldn't impact window drawing too much. The dithering and gradients are all precalculated (on first use, per window color) so no real impact in run-time from that.

A bit later I hope to post also the patch for the 0401 release, now only for the trunk! I hope you all like it, I'm pretty happy with it!

boekabart · Post by **boekabart** » 02 Sep 2005 14:34

Note that in-game there are also a lot of places where the gradient improves the looks, the background of all icons, for instance.

I've put a compiled exe here: http://www.debb.nl/OpenTTD/OpenTTD_r290 ... Patch2.rar, the RAR includes the EXE (based on r2905) and the language files.
Language files that contain the right text for the patch setting:
* Romanian
* English + American
* Dutch
* Italian
* French
* German
Not all of them are my native tongue (only one of them in fact

) so they may be strange (I, F and G mainly)[/url]

belugas · Post by **belugas** » 02 Sep 2005 14:38

I'd say it is quite refreshing indeed!
Dithering looks fantastic!

I just love new features

MeusH · Post by **MeusH** » 02 Sep 2005 16:13

That's great! Pity new patches are not added to the trunk

You will have to wait a long time...

Anyway, great job

SirkoZ · Post by **SirkoZ** » 02 Sep 2005 16:16

Well - the idea is nice and implementation too (visually), but in my opinion the dithering can be seen and is not good to watch for more time - for eyes the best would be smooth, which is pretty much the case in normal o/TTD.

thgergo · Post by **thgergo** » 02 Sep 2005 17:16

Good job, i like it

32bit would be better

...

boekabart wrote: I've put a compiled exe here: http://www.debb.nl/OpenTTD/OpenTTD_r290 ... Patch2.rar, the RAR includes the EXE (based on r2905) and the language files. (I, F and G mainly)[/url]

That dont works for me: wrong language files

belugas · Post by **belugas** » 02 Sep 2005 17:27

thgergo wrote:That dont works for me: wrong language files Sad

Same for me..
Even tried to recompile with current Trunk files for english and french..

Post by **peter1138** » 02 Sep 2005 17:34

MeusH, where did you get that idea?

MeusH · Post by **MeusH** » 02 Sep 2005 17:49

On IRC, where you've said only "stale" patches will be merged. I still don't get what you mean, but all I know is that devs are busy and they will not add user-made patches.

Post by **peter1138** » 02 Sep 2005 17:55

That's not what I said at all, heh.

SirkoZ · Post by **SirkoZ** » 02 Sep 2005 17:57

Well, it sure looks like it. Good thing we got the integrated nightly build.

boekabart · Post by **boekabart** » 02 Sep 2005 19:23

About that wrong lang file: I checked at a friend just 1 hour ago, same problem. I guess I made a mistake somewhere, I guess it has to do with that wrong lithuanian lang file that has been in the trunk for a while already now (anyone in the devteam going to FIX that?!). I'll try again when i have time, 30 min or so.

StavrosG · Post by **StavrosG** » 03 Sep 2005 17:54

MeusH wrote:On IRC, where you've said only "stale" patches will be merged. I still don't get what you mean, but all I know is that devs are busy and they will not add user-made patches.

I think they meant "stable" patches, not stale

Then the devs got distracted with another conversation anyway (I happened to be in the channel then, but not paying much attention)

boekabart · Post by **boekabart** » 03 Sep 2005 18:09

I made the whole render/blit engine in OpenTTD 32 bits just to make you guys who don't like dithering happy.
Well actually as a good practice for myself too.

THREAD HERE

Check out the also-new filtered zoom mode! (left on, right off)

Transport Tycoon Forums

Windows and backdrops with gradients

Windows and backdrops with gradients

Dithering!

EXE available

Made the thing 32bpp

Who is online