roest's patch pack v9 (r13019)

[Roest]

Might be a compiler issue. Try buildottd which uses mingw if i remember right.

[Gollum]

i'll try but that's not good for me, since i modify the code a lot and compile-recompile-debug it in MSVS

[Toni Babelony]

Dear lord... This is just too much. OTTD has entered another level for me now. Combining all these great features and great trainsets together, it's just too friggin' much!

[Draakon]

An update, good, now the engine pool is in.

[Gollum]

Got inside of it. Memory problem. I have no idea how in hell it works for you.....

Code: Select all

std::list<RouteDisplayInfo> stack;
		stack.push_back(RouteDisplayInfo(src, INVALID_ORDER, 0, 0, 0, 0));

		const int max_trial = 1024;
		for (int trial_count = max_trial; trial_count >= 0 && ! stack.empty(); trial_count--) {
			const std::list<RouteDisplayInfo>::iterator it = stack.begin();
			const RouteDisplayInfo &m = *it;
			stack.erase(it);

			if (m.station_id == INVALID_STATION) { // destination

stack (std::list) is defined.
One element is added to it.
Then we get inside of the loop. iterator is created pointing to the beginning of the list (on that only element in it).
Then we create a const reference to the value of iterator, thus m is a variable which is a copy of variable (*it). m is a reference to *it, which means m is not a copy of that value, it simply is another variable associated with the same thing in memory.
And then. We erase that thing in memory by calling stack.erase(it). m now points to garbage. Which is referenced in the next if statement and even more further.

[Roest]

I never looked deep into it. I'm on the verge of starting my own paxdest project. This patch is too big and too old to ever get it fixed for multiplayer stability.

[Gollum]

well, anyway, if you're going to write anything like that - you'd better prepare for this kind of stuff

[Gollum]

yep... the whole code is kinda buggy. don't want to play with these destinations anymore

[Two5Kid]

Erm, anyone could help out? Daylength + r12930 and above. No need PaxDest if it's too much of a hassle. Daylength is very important. Haha! Starting a new game.

Edit: Oops! What I meant was Roest's Patchpack + Daylength +/- PaxDest.

@Philosophus: Really? I downloaded the one on page 3, it didn't have daylength although it did have PaxDest. Maybe you're referring to the one on page 1. Will give it a go. My bad. Haha!

Edit again: Erm, nope. The one on Page 1 doesn't have daylength either.

[PhilSophus]

Erm, anyone could help out? Daylength + r12930 and above. No need PaxDest if it's too much of a hassle. Daylength is very important. Haha! Starting a new game.

Edit: Oops! What I meant was Roest's Patchpack + Daylength +/- PaxDest.

The last version of this patchpack is for r12930 and includes daylength, so, sorry, I obviously fail to see your problem.

[ige]

Sorry Philosophus, but the Windows binarys do not include the Daylength Patch

[Draakon]

Can you include this? http://www.tt-forums.net/viewtopic.php?f=33&t=36648

[Roest]

Can you include this? http://www.tt-forums.net/viewtopic.php?f=33&t=36648

I'm starting to believe you aren't the brightest here. In that thread i mentioned the patch isn't working since he missed something and here you ask me if i can include it.

[Draakon]

Can you include this? http://www.tt-forums.net/viewtopic.php?f=33&t=36648

I'm starting to believe you aren't the brightest here. In that thread i mentioned the patch isn't working since he missed something and here you ask me if i can include it.

You weren't giving a good information on what was missing.

[Gollum]

the patch has already been fixed.

[Roest]

updated to r12951

added: Nycom's routing restrictions patch

[Draakon]

After the update, most of the scenarios i was able to load can't be loaded now because of the broken savegame error. Any plans on fixing it?

[Roest]

nice, i just found out this forum has an ignore option

[niche]

very nice pack
can you add:
Track Sharing
Limit Road Vehicle Speed
There is a patch but i didnt know the name, it let you make subcompanys.
That would be great

[Sieben]

i really like this pack. could you please add Advanced Terraform - Drag&Draw or 45° rotated rectangle clearing / leveling patch.
i also have the problem that i cannot load most of the scenarios since the last update.