NewGRF GUI Window

[Jupix]

How is wiki.openttd.org readable for even 640*480. I tried this just..Wanted to show manual to someone...He couldn't read it...

What, the page refused to load on a low resolution?

[Rubidium]

How is wiki.openttd.org readable for even 640*480. I tried this just..Wanted to show manual to someone...He couldn't read it...

With links/lynx it is; otherwise you are free to 'fix' it.

[cmoiromain]

I wanted to bring back this topic, the number of GRF files becoming larger every day, with the new industries and the graphic replacement projects going on. This feature would really be useful, despite the fact that the window is too large. And, as it was already said, maybe the patch could switch back to normal behaviour when resolution is too small. I have no idea how C++ works, but I guess that would do the trick:

Code: Select all

if ($screen_height >> 480 && $screen_width >> 640)
    {
    //paste your patch here
    }
else
    {
    //paste original code here
    }

That's PHP coding, but I believe C++ looks the same...


And another request, maybe to add a way of adding sub folders to the list of available GRFs, once again because organising them all would make life easier (for example a directory containing all the ECS vectors, another containing all the UKRS files (train, roads, industries...), one containing the newGFX files, and so on)

I am conscious that trunk does not take in new features until v0.6 is out, but I hope this will make it soon afterwards!

[DaleStan]

Code: Select all

if (height >> 480 && width >> 640)

That's PHP coding, but I believe C++ looks the same...

I don't think that's quite what you meant. C++ or PHP.

[cmoiromain]

here you go

[DaleStan]

That's not what I meant. In most languages (including C, C++, C#, Java, Perl, and Python) >> is the right-shift operator. Right shifting by values equal to or larger than the width of the left-hand operand is discouraged. 641-bit wide integers are rather larger than most current processors are comfortable handling.

[cmoiromain]

for me that literally means "If the screen height is more than 480 pixels and the screen width is more than 640, then put the patch (draw the new window). If any of the height or width is smaller, then use the original behaviour. IIRC in PHP >> means "bigger than". But then maybe I'm wrong, I haven't coded for more than a year...

But anyway this is not the matter, the topic was about a new GRF selection window.

[fabca2]

IIRC in PHP >> means "bigger than".

no,

DaleStan is totally right.
> is greater.
>> is the right-shift operator.

[Roest]

reviving another corpse

[yorick]

It might be better to filter out the ones that you can't apply (same grfid as one already in), so you can get a nice overview.

[Roest]

added a button to toggle between all grfs and unselected ones
fixed some truncation
changed the strings in english.txt so it works with all languages

[rbenevid]

Does it support low resolutions? 320x240? Not that I need it, it's that I think the devs won't accept this patch in the trunk if it doesn't support it. And this patch is too good to not go into the trunk!

Thank you!

[Roest]

Does it support low resolutions? 320x240? Not that I need it, it's that I think the devs won't accept this patch in the trunk if it doesn't support it. And this patch is too good to not go into the trunk!

Thank you!

No it doesn't and i doubt it ever will. The solution will probably be a switch between this and the original windows for low resolutions. But then, having two different newgrf windows is also disliked by the devs.

[Trond]

Just tested this and it works like a charm on high resolution, wich is probably what most people use these days Good Job Roest!

[Wolf01]

I was playing with paint some days ago trying to figure out a grf window to start a my own patch, but I think I won't code anything
If you like, this is what I was thinking: http://wolf01.game-host.org/OTTD_relate ... estyle.png

[Roest]

ctrl-clicking the "toggle show mode" button now toggles between grf names and filenames
the right list of selected grfs can now be sorted using drag&drop

[Roest]

updated to r13135

[Tiberius]

update for r13377
edit[0]: now it's horizontally resizable!
edit[1]: tweaked left pane scroll bars, fixed 'warning symbol' display
edit[2]: removed unused configuration variable

[planetmaker]

Is there a chance for an update? It compiles, but I it crashes when I choose "apply" in the newgrf window. Messages in the console (applied to r13571).

Code: Select all

openttd(930,0xa000d000) malloc: *** vm_allocate(size=8421376) failed (error code=3)
openttd(930,0xa000d000) malloc: *** error: can't allocate region
openttd(930,0xa000d000) malloc: *** set a breakpoint in szone_error to debug
openttd(930,0xa000d000) malloc: *** vm_allocate(size=8421376) failed (error code=3)
openttd(930,0xa000d000) malloc: *** error: can't allocate region
openttd(930,0xa000d000) malloc: *** set a breakpoint in szone_error to debug

Thanks

[Tiberius]

checked against r13638 and seems working fine.