Cargo Distribution

[Dag]

Thanx that did it.

I always forget something when I do not play for some time.

[Creat]

JGR, Creat, Wasila: It's nice to hear about those playing styles and strategies of yours. However, I think it's a bit off-topic in this thread as this thread is more about Cargodist development. I made a new thread for discussing playing strategies with Cargodist or related patches: http://www.tt-forums.net/viewtopic.php?f=29&t=58091. Could you please move the discussion there?

Of course, sorry for hijacking your thread for this

Unfortunately I now have a crash to report: It happened in a multiplayer game with 3 players but can be reproduced by loading the savegame in singleplayer as well. The culprit seems to be in "StationID FlowStat::GetVia(StationID excluded)" (station_cmd.cpp). I'm not running a pure cargodist version though, there are 2 patches applied (both having nothing to do with stations though). The attached game crashes on feb. 18th. My build is based on rev 7c20bfc00ba0c5dcf252566c985c9663653964be (version from jan 5th).

I have attached a patch from my version to revision 7c20bfc00ba0c5dcf252566c985c9663653964be below. The only patches that I have applied are Slim Timetable Separation and Minimum Distance (towns only). Both have nothing to do with flowstats (which seems to be where the problem occurs). While it's of course possible that I mucked something up while merging I don't think I have...

The GRFs are mostly more or less current nightly versions, if you need any just let me know. ECS Vectors are taken from here.

[fonso]

It doesn't crash for me. Can I get the crash.* files? How did you find out that it crashes in Station::GetVia? Can I get the document you got that idea from? What CPU and OS are you using? I've tried with Windows/x86 and Linux/amd64 now and it still doesn't crash ...

[Creat]

It doesn't crash for me. What CPU and OS are you using? Can I get the crash.* files?

OK that is somewhat unexpected... I verified that it crashes here (Athlon 64 X2 5600+ [Brisbane] @ Windows 7 x64) on 32 and 64 bit builds. I also verified this on a second PC (also win7, 64 bit build only). Crash files are attached this time (sorry).

How did you find out that it crashes in Station::GetVia? Can I get the document you got that idea from? I've tried with Windows/x86 and Linux/amd64 now and it still doesn't crash ...

It wasn't exactly a document (but the crash.log should include the call stack), I just debugged into the code as it crashed. I also tried with a debug build hoping to get a bit more detailed information but the release builds seem to contain quite a few symbols already. Apparently what happens is: end = 7, max = 6, begin = 0. The fact that end>max is causing a negative value to be given as the "max"-parameter (which is uint) for RandomRange, which obviously overflows and causes that function to return 2758134575, which leads to the map error in line 3941 (which is the actual crash).

It seems to me GetVia should return INVALID_STATION, as there is only one entry in the map ("shares"), with the entry being 7,19. While you -1 the max value on initialization (presumably for upperBond to work correctly) you later (line 3935) check for (end == max), but end was initialized to the raw value (without the -1). Is that correct? Is that it? And why hasn't this happened (crashed) before? It doesn't seem like such an unlikely scenario, is it?

If you still can't reproduce any of this and still need to after my 'analysis' (ok that might be overstating it a bit but I did my best) I can just upload you my build somewhere (just let me know which files you need in addition to the standard OpenTTD files, if any) so we can see if that changes anything. But since you clearly applied the my patches (or you couldn't load my savegame) it should be the same build anyway...

[fonso]

This code is fairly new. I just wrote it two weeks ago. So there might still be some stupid errors in it. I'll have a look at it. Thanks.

[donchatryit]

CargoDist does not provide savegame compatibility.

Even for games previously saved with earlier versions of cargodist? That would be sad if true.

If that is so, could someone point me to where I can find the cargodist version patched to OpenTTD 1.0.0 on the compile farm?

[fonso]

Cargodist is not savegame compatible with itself. In order to provide compatibility to old cargodist versions as well as old trunk versions a lot of code would have to be written which would become totally useless once Cargodist is merged into trunk.

[romazoon]

I have a suggestion about the linkgraph.

On most of my big games, i just can t see well all the links as too many of them cross each other, so i was wondering if it would be possible to add a filter to reduce the numbers of link showed at same time.

You allready have filters per cargo, so would it be possible to add a link filter per distance ?? (i dont know wich value would fit the best, actually maybe something adjustable by users could maybe be the best in order to make that filter usefull on all sort of mapsize)

[TERdON]

I have a suggestion about the linkgraph.

On most of my big games, i just can t see well all the links as too many of them cross each other, so i was wondering if it would be possible to add a filter to reduce the numbers of link showed at same time.

You allready have filters per cargo, so would it be possible to add a link filter per distance ?? (i dont know wich value would fit the best, actually maybe something adjustable by users could maybe be the best in order to make that filter usefull on all sort of mapsize)

It should be two-way. You might want to remove the short links if you want to check the long ones; and filter the long ones if you check local network.

Another option would be to filter links by transportation type (train, bus, airplane, boat). Dream would of course be to go by groups of vehicles or something...

[Creat]

Just one short question. I remember a discussion in this thread about dropping links which are no longer served instantly from the map. Meaning if there are no orders anymore which cover a certain connection, the connection is removed. Was that ever implemented? Or do links still have to timeout even if they are no longer serves by any vehicle?

I tried searching but couldn't find it, and since it's basically a yes/no question I thought I'd just ask

Edit: nevermind, question answered itself while playing. They are apparently removed at the next linkgraph recalculation (at least that would aprox. match the time it takes for them to disappear).

[Wasila]

This is not the first crash I've had, but I thought I better report it this time. Do you think it will be safe to play on with the emergency save?

EDIT: Evidently not. Attached is the save, which consistently crashes on the 4th of Jan.

*** OpenTTD Crash Report ***

Crash at: Sat Jan 14 12:23:35 2012
In game date: 1986-01-01 (0)

Crash reason:
Exception: E1212012
Location: 767FB9BC
Message: Assertion failed at line 800 of C:/MinGW/msys/1.0/home/[user name]/trunk/src/cargopacket.cpp: next != to

OpenTTD version:
Version: r23672M (2)
NewGRF ver: 12005c78
Bits: 32
Endian: little
Dedicated: no
Build date: Dec 26 2011 13:02:15

Registers:
EAX: 0028ED74 EBX: 00000016 ECX: 00000000 EDX: 0008E3B8
ESI: 74B13180 EDI: 00000000 EBP: 0028EDC4 ESP: 0028ED74
EIP: 767FB9BC EFLAGS: 00000246

Bytes at instruction pointer:
C9 C2 10 00 CC CC CC CC CC 8B FF 55 8B EC 56 8B 75 08 83 FE F4 72 18 83

Stack trace:
E1212012 00000000 00000000 767FB9BC 00000000 0028EDA8 74D1FE81 00170616
74B164A8 74AC03D8 00012010 00000000 FFFFFFFF 0028EDC4 74D1FEC6 00170616
7732FA7A 77351052 FFFFFFFF 00000024 0028EE30 00544ABF E1212012 00000000
00000000 00000000 74B10290 0028EE30 74AD5E81 74AD5E87 00000016 9328B738
0028F421 00000027 0028F180 7732FA7A 77349DBC 00000000 00000024 00544A98
00000001 0028EDF0 0028E918 0028FFC4 74A98CD5 E7AD07B8 FFFFFFFE 0028F168
74AD8E8A 00000016 00000027 00080680 00000202 00000000 000C0023 040DB658
00000000 00F70000 09C7B6C0 00000000 00000000 00580009 00000522 0022064A
00170616 00000000 09C7B6A8 00000001 09C7B6B8 0028EEA0 7733E023 00010003
00000000 0028F0AC 09C7B6B8 0028EF48 74D1F908 00F70000 00000000 09C7B6C0
00000001 0028F0AC 00000001 0000001C 0000000F 00000000 009E6B40 00000010
00170616 202D2020 00000006 00000000 00000000 00000556 000002D8 00000000
00000170 0028F0AC 000001BC 00000000 00007F01 00000000 00000001 0000001E
50022080 00000035 00000020 00000001 00000000 000001DD 0E4FE828 09C7B6C0
011F135C 00000000 09C7B724 011F13C8 0000011B 0028F0A0 74D1FBAC 00000010
0028F421 00000027 74D1FBE4 00000001 0091F768 0028EF98 74A8AA42 01221C07
00000000 011F0E04 00000016 7FFFFFFF 00000000 00000000 00000000 74D1FBFC
00000000 00000001 74A8A8C1 01221C07 0091F768 00000016 0028EFB8 7FFFFFFF
00000000 74B12BD0 01221520 012207D0 00000000 0028EFF8 74A8A9C8 01221C07
00000008 00000016 00000008 0122179C 01221C08 74B12BD0 0028F013 00000000
0028F0CC 0028F010 006D91B5 00000008 00000000 0000000A 00000000 00383030
0028F421 0087A544 00000000 0028F02C 74A7A442 FFFFFFFF 006D9092 74A8A490
00000007 74A8A462 9328A960 0028F421 0000007F 0028F180 009E6B40 00000200
0028F1E2 0028F07C 76824D9F 009E6B40 00000000 0028F078 009E6BF6 009E6F40

Operating system:
Name: Windows
Release: 6.1.7600 ()
Compiler: GCC 4.5.2 "4.5.2"

Configuration:
Blitter: 8bpp-optimized
Graphics set: OpenGFX (875)
Language: C:Users[user name]DocumentsOpenTTDsaveBritish RailCargoDist r23672langenglish.lng
Music driver: win32
Music set: OpenMSX (96)
Network: no
Sound driver: win32
Sound set: OpenSFX (87)
Video driver: win32

AI Configuration (local: 0):
0: Human
1: Terron (v203)
2: SynTrans (v6)
3: NoCAB (v498)

Libraries:
FreeType: 2.4.4
LZMA: 5.0.1
LZO: 2.04
PNG: 1.5.1
Zlib: 1.2.5

Module information:
C:Users[user name]DocumentsOpenTTDsaveBritish RailCargoDist r23672openttd.exe handle: 00400000 size: 9879759 crc: EA73EE2E date: 2011-12-26 13:05:18
C:WindowsSysWOW64ntdll.dll handle: 77310000 size: 1292592 crc: 23E857C3 date: 2011-11-17 05:41:38
C:Windowssyswow64kernel32.dll handle: 74e70000 size: 1048576 crc: DCE7E740 date: 2011-07-16 04:30:27
C:Windowssyswow64KERNELBASE.dll handle: 767f0000 size: 272384 crc: 917AC4A9 date: 2011-07-16 04:30:27
C:Windowssyswow64ADVAPI32.DLL handle: 74f70000 size: 640000 crc: 24248FE4 date: 2009-07-14 01:14:53
C:Windowssyswow64msvcrt.dll handle: 74a70000 size: 690688 crc: 554C94A4 date: 2009-07-14 01:15:50
C:WindowsSysWOW64sechost.dll handle: 76910000 size: 92160 crc: B624B29A date: 2009-07-14 01:16:13
C:Windowssyswow64RPCRT4.dll handle: 74b30000 size: 662528 crc: 21A3ED97 date: 2009-07-14 01:11:23
C:Windowssyswow64SspiCli.dll handle: 74a00000 size: 96768 crc: 88D768A6 date: 2010-07-23 13:39:20
C:Windowssyswow64CRYPTBASE.dll handle: 749f0000 size: 36864 crc: 00308E17 date: 2009-07-14 01:15:07
C:Windowssyswow64GDI32.dll handle: 74c20000 size: 310784 crc: D911CA67 date: 2009-07-14 01:11:21
C:Windowssyswow64USER32.dll handle: 74cb0000 size: 833024 crc: E462ECF7 date: 2009-07-14 01:11:24
C:Windowssyswow64LPK.dll handle: 772e0000 size: 25600 crc: 3C6CC57C date: 2009-07-14 01:11:23
C:Windowssyswow64USP10.dll handle: 76980000 size: 627200 crc: 3887C4C8 date: 2009-07-14 01:16:17
C:Windowssyswow64SHELL32.DLL handle: 75320000 size: 12868096 crc: 5DFA9889 date: 2011-08-30 04:28:32
C:Windowssyswow64SHLWAPI.dll handle: 76110000 size: 350208 crc: 8D9B2C39 date: 2009-07-14 01:16:14
C:Windowssystem32WINMM.DLL handle: 70890000 size: 194048 crc: 2FBEB05C date: 2009-07-14 01:16:19
C:Windowssyswow64WS2_32.dll handle: 768d0000 size: 206336 crc: 4C23BF22 date: 2009-07-14 01:16:20
C:Windowssyswow64NSI.dll handle: 75100000 size: 8704 crc: 2ACE9671 date: 2009-07-14 01:16:11
C:Windowssystem32IMM32.DLL handle: 75110000 size: 119808 crc: BC43D00A date: 2009-07-14 01:11:21
C:Windowssyswow64MSCTF.dll handle: 75030000 size: 828928 crc: DFE09EEB date: 2009-07-14 01:15:43
C:Windowssystem32SHFolder.dll handle: 72400000 size: 7168 crc: 683AAC32 date: 2009-07-14 01:16:14
C:Windowssyswow64ole32.dll handle: 76690000 size: 1413632 crc: 082ED659 date: 2010-06-29 05:02:02
C:Windowssystem32uxtheme.dll handle: 70c90000 size: 245760 crc: 60C5C746 date: 2009-07-14 01:11:24
C:Program Files (x86)DigitalPersonaBinDpoFeedb.dll handle: 10000000 size: 644432 crc: F97C4A7C date: 2010-09-15 10:09:32
C:Windowssyswow64OLEAUT32.dll handle: 75170000 size: 571904 crc: 353B7F45 date: 2011-08-27 04:43:07
C:Windowssystem32VERSION.dll handle: 740f0000 size: 21504 crc: 88D9D0F1 date: 2009-07-14 01:16:17
C:Windowssystem32USERENV.dll handle: 70db0000 size: 79360 crc: A3905B80 date: 2009-07-14 01:16:17
C:Windowssystem32profapi.dll handle: 73f60000 size: 31744 crc: E7DBE825 date: 2009-07-14 01:16:12
C:Windowssystem32dwmapi.dll handle: 70dd0000 size: 67072 crc: FC7CA4B8 date: 2009-07-14 01:15:13
C:Windowssystem32mswsock.dll handle: 70e20000 size: 232448 crc: 32400D27 date: 2009-07-14 01:15:51
C:WindowsSystem32wshtcpip.dll handle: 704d0000 size: 9216 crc: BA963A19 date: 2009-07-14 01:16:20
C:Windowssystem32MMDevAPI.DLL handle: 6e050000 size: 213504 crc: 352DF99F date: 2009-07-14 01:15:41
C:Windowssystem32PROPSYS.dll handle: 6ff80000 size: 988160 crc: 0700E8D7 date: 2009-07-14 01:16:12
C:Windowssystem32wdmaud.drv handle: 6e020000 size: 172032 crc: 03BEEBE2 date: 2009-07-14 01:14:08
C:Windowssystem32ksuser.dll handle: 6e010000 size: 4608 crc: EBE07232 date: 2009-07-14 01:15:35
C:Windowssystem32AVRT.dll handle: 6e000000 size: 14336 crc: 9818237B date: 2009-07-14 01:14:58
C:Windowssyswow64SETUPAPI.dll handle: 763d0000 size: 1668608 crc: F909EF01 date: 2009-07-14 01:16:14
C:Windowssyswow64CFGMGR32.dll handle: 763a0000 size: 145920 crc: D52A7806 date: 2011-05-24 10:34:00
C:Windowssyswow64DEVOBJ.dll handle: 75010000 size: 64512 crc: 877BD0A9 date: 2011-05-24 10:34:20
C:Windowssystem32AUDIOSES.DLL handle: 6dfc0000 size: 195584 crc: BC939745 date: 2009-07-14 01:14:57
C:Windowssystem32msacm32.drv handle: 6dfb0000 size: 20992 crc: 73923147 date: 2009-07-14 01:14:08
C:Windowssystem32MSACM32.dll handle: 6df90000 size: 72192 crc: ABA25814 date: 2009-07-14 01:15:42
C:Windowssystem32midimap.dll handle: 6df80000 size: 16896 crc: C000494C date: 2009-07-14 01:15:40
C:Windowssyswow64CLBCatQ.DLL handle: 74de0000 size: 522240 crc: 6C130B8A date: 2009-07-14 01:15:03
C:Program Files (x86)DigitalPersonaBinDpoSet.dll handle: 6fe10000 size: 212304 crc: F5E342D4 date: 2010-09-15 09:01:52
C:Windowssystem32mciseq.dll handle: 6dec0000 size: 23552 crc: BA67A92D date: 2009-07-14 01:15:37
C:Windowssyswow64psapi.dll handle: 74a60000 size: 6144 crc: 25B988F9 date: 2009-07-14 01:16:12

---- gamelog start ----
Tick 0: new game started
Revision text changed to r16889, savegame version 122, not modified, _openttd_newgrf_version = 0x080041f9
New game mode: 2 landscape: 0
Added NewGRF: GRF ID 50430301, checksum 019EC35F3327E5069E68A8AD990C1AAE, unknown GRF
Added NewGRF: GRF ID 6D620601, checksum E5BB55CF0C0FCAFCBC4A402BF5E870BF, filename: newstatsw.grf (matches GRFID only)
Added NewGRF: GRF ID 56430001, checksum 6B3CAAEE94A08F444D9F3429CEA2CB2A, filename: total_town_replacement_set-3.11ttrs3w.grf (matches GRFID only)
Added NewGRF: GRF ID 74677462, checksum A2396FFDCC0F1BA37A2A89EF525CDF21, filename: total_bridge_renewal_set.1.12total_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 46420801, checksum 2D654630F22AA4C78A58710024C514B3, unknown GRF
Added NewGRF: GRF ID 4A430002, checksum 0728ADCB4DF2F1EB9247ABD449296F4E, filename: ottdc_grfpack7_stationsindstatrindstatrw.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum A7EA6FB6732157AEE44627A64EBCDAE6, filename: av8_aviators_aircraft_set.v1.331pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 6D620004, checksum 70649F1AFC954942173B0AA89C1E8B14, filename: ottdc_grfpack8_vehiclesshipsnewshipsnewshipsw.grf (md5sum matches)
Added NewGRF: GRF ID 4D470901, checksum 887847A49FDA37D8C7F61297C26A40F0, filename: oldbridge.grf (matches GRFID only)
Added NewGRF: GRF ID 44440201, checksum DBEE7FED4B51E27E53FB7A14E283BE38, unknown GRF
Added NewGRF: GRF ID 43520001, checksum 93FB56B6B628FFE0FD8A098A01C3E786, unknown GRF
Added NewGRF: GRF ID 27711002, checksum 3E2A2578101FFB3DD8AFC451CC43C8D0, filename: 2cc_trainset.1.0.12cctrainset.grf (md5sum matches)
Added NewGRF: GRF ID 535A1344, checksum EE64CDD6E4600C717B448583026DF24D, filename: temperate_oil_wells_can_increase.v2oilsgoup.grf (md5sum matches)
Added NewGRF: GRF ID 52571201, checksum C1C7D8C53EB7E74EEE2F0EF29638B466, filename: ottdc_grfpack8_vehiclesroad_vehiclesgrvtsegrvts.grf (md5sum matches)
Added NewGRF: GRF ID FBFB9905, checksum F747797A14AAA646402DC4E16DE5E82C, filename: longer_girder__steel_bridge.1longergirdersteelbridge.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0401, checksum E497AFEB67D7501658FFC709C2E474A9, filename: MetroTrackSetW.grf (md5sum matches)
Tick 0: GRF config changed
Removed NewGRF: GRF ID 27711002, filename: 2cc_trainset.1.0.12cctrainset.grf (md5sum matches)
Removed NewGRF: GRF ID 535A1344, filename: temperate_oil_wells_can_increase.v2oilsgoup.grf (md5sum matches)
Added NewGRF: GRF ID 19060801, checksum 6CFC6328D999C140851BFE6514BA277A, unknown GRF
Added NewGRF: GRF ID 45520400, checksum 1D00426064137AA49B6FC4F4BCFF173F, filename: ottdc_grfpack7_stationsbrickfreightbrickfreightw.GRF (md5sum matches)
Added NewGRF: GRF ID 52455400, checksum 1600687C50C5AB1E72EDD487CAD50E2A, filename: ottdc_grfpack7_stationsae_cityae_cityw.GRF (md5sum matches)
Added NewGRF: GRF ID 45520500, checksum 7E30CA79D5A8B3A6CBE873E26096D7D2, filename: ottdc_grfpack7_stationsmodernsuburbanmodernsuburbanw.GRF (md5sum matches)
Added NewGRF: GRF ID 45520600, checksum 346457CB4632554B6A175785236883E4, unknown GRF
Added NewGRF: GRF ID 52455200, checksum 0E5A9C5ACD2BCAF7FA0658C3F905A660, filename: ottdc_grfpack7_stationsae_ruraae_ruraw.GRF (md5sum matches)
Added NewGRF: GRF ID 52455300, checksum 37C0B839B13C4B18051580C81EEDF427, filename: ottdc_grfpack7_stationsae_subuae_subuw.GRF (md5sum matches)
Added NewGRF: GRF ID 44440111, checksum 9B5051E70D60EF2926A249B923AFB0CA, filename: uk_renewal_set.3.04pb_ukrs.grf (md5sum matches)
Added NewGRF: GRF ID 44442202, checksum 3DAC7433C0DA14AD3C5E8C89D73A6A2E, filename: uk_renewal_set_addon_pack.3.04ukrsap1w.grf (md5sum matches)
Removed NewGRF: GRF ID FBFB0401, filename: MetroTrackSetW.grf (md5sum matches)
Tick 0: game loaded
Revision text changed to 1.0.0-beta4, savegame version 138, not modified, _openttd_newgrf_version = 0x10004a40
Missing NewGRF: GRF ID 50430301, unknown GRF
Compatible NewGRF loaded: GRF ID 6D620601, checksum 44EB2F155862E4D4F0AB671D7021AF54, filename: newstatsw.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 56430001, checksum AF3E0A1E6EF0B98DB966594578D1775B, filename: ottdc_grfpack6_town_buildingsttrs3ttrs3w.GRF (md5sum matches)
Missing NewGRF: GRF ID 46420801, unknown GRF
Compatible NewGRF loaded: GRF ID 4D470901, checksum 7A0FB842DAA8A2F7A57857C01C4939FD, filename: oldbridge.grf (md5sum matches)
Missing NewGRF: GRF ID 44440201, unknown GRF
Missing NewGRF: GRF ID 43520001, unknown GRF
Missing NewGRF: GRF ID 19060801, unknown GRF
Missing NewGRF: GRF ID 45520600, unknown GRF
Tick 0: GRF config changed
Removed NewGRF: GRF ID 6D620601, filename: newstatsw.grf (md5sum matches)
Removed NewGRF: GRF ID 74677462, filename: total_bridge_renewal_set.1.12total_bridges.grf (md5sum matches)
Removed NewGRF: GRF ID 4A430002, filename: ottdc_grfpack7_stationsindstatrindstatrw.grf (md5sum matches)
Removed NewGRF: GRF ID 44440A01, filename: av8_aviators_aircraft_set.v1.331pb_av8w.grf (md5sum matches)
Removed NewGRF: GRF ID 6D620004, filename: ottdc_grfpack8_vehiclesshipsnewshipsnewshipsw.grf (md5sum matches)
Removed NewGRF: GRF ID 4D470901, filename: oldbridge.grf (md5sum matches)
Removed NewGRF: GRF ID 52571201, filename: ottdc_grfpack8_vehiclesroad_vehiclesgrvtsegrvts.grf (md5sum matches)
Removed NewGRF: GRF ID FBFB9905, filename: longer_girder__steel_bridge.1longergirdersteelbridge.grf (md5sum matches)
Removed NewGRF: GRF ID 45520400, filename: ottdc_grfpack7_stationsbrickfreightbrickfreightw.GRF (md5sum matches)
Removed NewGRF: GRF ID 52455400, filename: ottdc_grfpack7_stationsae_cityae_cityw.GRF (md5sum matches)
Removed NewGRF: GRF ID 45520500, filename: ottdc_grfpack7_stationsmodernsuburbanmodernsuburbanw.GRF (md5sum matches)
Removed NewGRF: GRF ID 52455200, filename: ottdc_grfpack7_stationsae_ruraae_ruraw.GRF (md5sum matches)
Removed NewGRF: GRF ID 52455300, filename: ottdc_grfpack7_stationsae_subuae_subuw.GRF (md5sum matches)
Removed NewGRF: GRF ID 44440111, filename: uk_renewal_set.3.04pb_ukrs.grf (md5sum matches)
Removed NewGRF: GRF ID 44442202, filename: uk_renewal_set_addon_pack.3.04ukrsap1w.grf (md5sum matches)
Tick 0: game loaded
Revision text changed to 1.1.0, savegame version 160, not modified, _openttd_newgrf_version = 0x1108570a
Tick 0: GRF config changed
Added NewGRF: GRF ID 44440111, checksum 9B5051E70D60EF2926A249B923AFB0CA, filename: uk_renewal_set.3.04pb_ukrs.grf (md5sum matches)
Added NewGRF: GRF ID 05102002, checksum A8B77B8D1F20D43B6FA521B4C3A8FC50, filename: monolev_replacement_set_v0.3.6-0.3.7mrsv037.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum 0BF8636EFEEF4F0617CAE47D77FF4C43, filename: av8_aviators_aircraft_set-1.81pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 414E0101, checksum 1922958963E54992E395CAE86EBF4649, filename: fish_ship_set-0.9.0fish.grf (md5sum matches)
Added NewGRF: GRF ID 52453C00, checksum C5B4EC240B33E2DB8D1EA64C97898B5E, filename: ottdc_grfpack2_landscapestolentreesstolentreesw_162_108.grf (md5sum matches)
Added NewGRF: GRF ID 52571201, checksum C1C7D8C53EB7E74EEE2F0EF29638B466, filename: ottdc_grfpack8_vehiclesroad_vehiclesgrvtsegrvts.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 56430001, checksum 3D04866AA668C450C6838727BAC3791F, filename: total_town_replacement_set-3.11ttrs3w.grf (md5sum matches)
GRF parameter changed: GRF ID 56430001, filename: total_town_replacement_set-3.11ttrs3w.grf (md5sum matches)
Tick 0: game loaded
Revision text changed to r23672M, savegame version 213, modified, _openttd_newgrf_version = 0x12005c78
Tick 0: GRF config changed
Removed NewGRF: GRF ID 44440111, filename: uk_renewal_set.3.04pb_ukrs.grf (md5sum matches)
Removed NewGRF: GRF ID 05102002, filename: monolev_replacement_set_v0.3.6-0.3.7mrsv037.grf (md5sum matches)
GRF order changed: 44440A01 moved 12 places downGRF ID 44440A01, filename: av8_aviators_aircraft_set-1.81pb_av8w.grf (md5sum matches)
GRF order changed: 414E0101 moved 13 places downGRF ID 414E0101, filename: fish_ship_set-0.9.0fish.grf (md5sum matches)
GRF order changed: 52453C00 moved 1 places downGRF ID 52453C00, filename: ottdc_grfpack2_landscapestolentreesstolentreesw_162_108.grf (md5sum matches)
Added NewGRF: GRF ID 52455200, checksum 0E5A9C5ACD2BCAF7FA0658C3F905A660, filename: ottdc_grfpack7_stationsae_ruraae_ruraw.GRF (md5sum matches)
Added NewGRF: GRF ID 52455300, checksum 37C0B839B13C4B18051580C81EEDF427, filename: ottdc_grfpack7_stationsae_subuae_subuw.GRF (md5sum matches)
Added NewGRF: GRF ID 45520500, checksum 7E30CA79D5A8B3A6CBE873E26096D7D2, filename: ottdc_grfpack7_stationsmodernsuburbanmodernsuburbanw.GRF (md5sum matches)
Added NewGRF: GRF ID 52455400, checksum 1600687C50C5AB1E72EDD487CAD50E2A, filename: ottdc_grfpack7_stationsae_cityae_cityw.GRF (md5sum matches)
Added NewGRF: GRF ID 43415463, checksum 422B1603DC1CEDA4E59E715E12EAD332, filename: canstnw.grf (md5sum matches)
Added NewGRF: GRF ID 6D620601, checksum 44EB2F155862E4D4F0AB671D7021AF54, filename: newstatsw.grf (md5sum matches)
Added NewGRF: GRF ID 45530400, checksum 1D13F6976C0C032F3FB8F76B84B6EBA8, filename: japanese_stations.2.0jpstationsw.grf (md5sum matches)
Added NewGRF: GRF ID 41501202, checksum 97F6FC9CF2E46FC9B559A13CB6DB19CE, filename: heqs_heavy_equipment_set-1.1.0heqs.grf (md5sum matches)
Added NewGRF: GRF ID 444A5401, checksum 70955580042DE6758938EA904A2223CA, filename: nutracks-1.1.2nutracks.grf (md5sum matches)
Added NewGRF: GRF ID 27711003, checksum 1DD625FFF9805756C848E19BDDA162C3, filename: 2cctrainset.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum EFB21CFA6828362FDA9B2D629B5EEEB4, filename: industrial_stations_renewal-0.8.1indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 43485053, checksum 80EB009DC3E2CCD5C2C71DDB9A1CFBC3, filename: chips_station_set-0.6.0chips.grf (md5sum matches)
Compatible NewGRF loaded: GRF ID 56430001, checksum 0CB8AD0B5E08C40893EDD63DBF49A192, filename: total_town_replacement_set-3.13ttrs3w.grf (md5sum matches)
Tick 0: game loaded
New game mode: 1 landscape: 0
Tick 23: settings changed
Setting changed: economy.station_noise_level : 0 -> 1
Tick 23: settings changed
Setting changed: vehicle.plane_speed : 4 -> 3
Tick 23: settings changed
Setting changed: vehicle.plane_speed : 3 -> 2
Tick 23: settings changed
Setting changed: vehicle.plane_speed : 2 -> 1
Tick 23: GRF config changed
Removed NewGRF: GRF ID 27711003, filename: 2cctrainset.grf (md5sum matches)
Added NewGRF: GRF ID 44441000, checksum 5CA2EF8EABD9B28B7D9970B2989A5519, filename: ukrs2__the_uk_railway_set-0.82proj1000.grf (md5sum matches)
Tick 23: GRF config changed
GRF parameter changed: GRF ID 444A5401, filename: nutracks-1.1.2nutracks.grf (md5sum matches)
Tick 31046: settings changed
Setting changed: vehicle.never_expire_vehicles : 0 -> 1
Tick 31046: settings changed
Setting changed: vehicle.never_expire_vehicles : 1 -> 0
Tick 55101: GRF config changed
GRF parameter changed: GRF ID 44441000, filename: ukrs2__the_uk_railway_set-0.82proj1000.grf (md5sum matches)
Tick 5440: GRF config changed
GRF parameter changed: GRF ID 44441000, filename: ukrs2__the_uk_railway_set-0.82proj1000.grf (md5sum matches)
Tick 42502: GRF config changed
GRF parameter changed: GRF ID 44441000, filename: ukrs2__the_uk_railway_set-0.82proj1000.grf (md5sum matches)
Tick 45283: GRF config changed

[Hyronymus]

I see quite some missing GRF's:
Missing NewGRF: GRF ID 50430301, unknown GRF
Missing NewGRF: GRF ID 46420801, unknown GRF - Note the warning message there!
Missing NewGRF: GRF ID 44440201, unknown GRF
Missing NewGRF: GRF ID 43520001, unknown GRF
Missing NewGRF: GRF ID 19060801, unknown GRF
Missing NewGRF: GRF ID 45520600, unknown GRF - No match found on GRFCrawler.

Have you removed GRF's after saving or while playing?

[Wasila]

As far as I remember, I changed the newGRFs in the scenario editor, or at least at the start of my game; not recently.

[Alberth]

Yes they were also changed in the running game:

Code: Select all

Tick 23: GRF config changed
Tick 55101: GRF config changed
Tick 5440: GRF config changed
Tick 42502: GRF config changed
Tick 45283: GRF config changed

You should read the red warning window one time, and take its message seriously instead of wasting peoples time.

And as for safety of playing further, you are already way out of the safety zone in the first place.

[Wasila]

Ah yes, I changed certain UKRS parameters which only affect liveries a number of times. I didn't realise that would affect a crash taking place at 'cargopacket.cpp'. Excuse my ignorance.

[Creat]

This is not the first crash I've had, but I thought I better report it this time. Do you think it will be safe to play on with the emergency save?

EDIT: Evidently not. Attached is the save, which consistently crashes on the 4th of Jan.

Yes, there is quite a bit of loading, unloading and parameter changing going on with NewGRFs. That is very likely the cause.

But for the next bug report (I hope you do report it again if another crash occurs) I would have 2 suggestions. First of all, please don't copy paste the entire crash log in the message body, either attach it or zip and attach it. In case .log isn't an allowed extension to upload just rename it to .txt or something. Secondly, there should also be a "crash.dmp" file, this is also very helpful as it allows the developer to reproduce the exact state at which your OpenTTD crashed. It's much more convenient (at least in my opinion) to see what's going on.

[Wasila]

Yes, there is quite a bit of loading, unloading and parameter changing going on with NewGRFs. That is very likely the cause.

But for the next bug report (I hope you do report it again if another crash occurs) I would have 2 suggestions. First of all, please don't copy paste the entire crash log in the message body, either attach it or zip and attach it. In case .log isn't an allowed extension to upload just rename it to .txt or something. Secondly, there should also be a "crash.dmp" file, this is also very helpful as it allows the developer to reproduce the exact state at which your OpenTTD crashed. It's much more convenient (at least in my opinion) to see what's going on.

I forgot you could change the extension of the .log file - will keep that in mind. I also thought that the .dmp was not for error reporting purposes, and have attached it for good measure.

Thanks,
Wasila

[fonso]

I've rewritten the wiki page and the first post and rearranged my git repository. I'm using the same repository style as michi_cc now, with only one significant branch and a commit for each feature. This makes finding out what's going on and maintenance much easier. However, it requires frequent rebasing, so don't try to merge from my repository. Check out the branch "cdd" to see what I'm doing at the moment. Most of the time this will be non-functional, though.

Some deprecated or somehow interesting things (yacd, distyacd, smallmap-zoom-in and the old smallmap-stats) are kept around in my repository. Don't get confused.

I've also dropped the patch space. If you don't have git you can download an archive of the code either from http://bundles.openttdcoop.org/cargodist/releases or from https://github.com/fonsinchen/openttd-cargodist

[Kraks]

Is it possible to add link graph setting which will define distribution of cargoes which affect town growth (instead of express cargoes)? May be it will be less confusing?

[Creat]

Initially I wanted to send this as a PM, but considering others might be interested in this as well I thought I'd as here, even though it's slightly off-topic (at least some parts).

I was hoping you could give me a pointer or two about how you've setup your Git repo. I'm currently planning to do collaborate with AndiK on his patch (slim timetable separation) and since I know you had a nice hierarchy of branches (up until quite recently including the online repo) I'd like to know how you keep those up. Do you have the local branches tracking their local ancestor or their remote equivalent? Do you have a way to easily propagate changes in trunk through the entire tree or do you manually have to pull/merge every branch? Most importantly though, how have you setup your final leaf (branch "cd"), having multiple parents? Is there a way to set that up so that changes in multiple/all parental branches are merged with the least effort possible?

Since I basically never play a game without CD, I usually use a clone of your repo to merge in other patches (like minimum town distance and other trivialities). Can I safely keep local branches in such a repo (tracking local 'master' and local 'cd') without getting into massive trouble if you rebase your GitHub repo, or will I have to do extensive manual merging locally (or worse)? I don't have anything committed to my local cd-branch of course, but I have branches based upon it (basically one for each patch, adapting it from trunk to cd, and one branch merging all those together). Maybe that setup is overkill anyway and a simpler approach would do?
The only hint I've found was in Michi_CC's description of his repo, to run a "git rebase --hard origin" upon an upstream rebase, but I haven't found any reference to which extent this corrects possible issues (or even any reference to that use of rebase in the git documentation at all).

Finally one question as to the savegame version handling. You obviously bump the version quite a bit via SaveLoadVersions, and most other patches also bump the version to something higher (often a value of 200). Generally, when merging patches with CD, I tend to leave your system in place and just ignore any additional version bumps by the other patches, since the version is already bumped. This of course causes me to be unable to load savegames created before I applied that patch. Is there an easy/clean way around that? Especially to allow me loading games created before a simple trunk savegame version bump, which should generally load just fine afterwards if I understand it correctly...