[Patch] Departure boards, 24h clock + binary 25 (r27452)

[Norfolkadam]

When you set a station to "no unloading" it doesn't show on the "Calling at:" section. Can you add an option so that it does?

Done.

I've also updated the patch to current trunk, and handled automatic orders as best I can.

Ah sweet thank you've made my day.

[Norfolkadam]

So I'm new to all this patching malarkee. I've spent the best side of two hours compiling and typing lines of text and I finally get a compiled version of the latest build. I download the Tortoise patching programme and patch it using the latest diff you've put up. However it doesn't seem to have done anything, I have no departure boards yet when I was just using the old version that wasn't a patch it was fine.

Am I missing a step here (I'm sure I am). I've compiled OTTD. I've applied the patch. ...

[Yexo]

You should patch the source code. If you've done that correctly you have to compile the code again. The resulting binary will have the patch you used.

[Norfolkadam]

You should patch the source code. If you've done that correctly you have to compile the code again. The resulting binary will have the patch you used.

I tried to compile it again (I figured that was probably the missing step) and I got an error a la:

Code: Select all

[SRC] Compiling ai/ai_core.cpp
In file included from c:/ottd/src/ai/..window_func.h:15:0,
from c:/ottd/src/ai/ai_core.cpp:18:
c:/ottd/src/ai/../window_type.h:115:2: error: redfinition of 'WC_DEPARTURES_BOARD'
c:ottd/src/ai/..window_type.h:114:2: error: 'WC_DEPARTURES BOARD' previously defined here
make [1]: *** [ai/ai_core.o] Error 1
make [1]: Leaving directory '/c/ottd/objs/release'
make: *** [all] Error 1

And I have no idea what any of that means.

[Yexo]

Have you perhaps applied the patch twice? That could explain it. If so, revert the state (there should be a "revert" button in tortoisesvn) and after that apply the patch again, then compile again.

Other possible explanations why compiling could fail after applying a single patch:
-you applied the patch to another version of openttd than it was made for
-the patch is buggy.
Given the error message you posted neither of these is very likely.

[Eddi]

Have you perhaps applied the patch twice? That could explain it. If so, revert the state (there should be a "revert" button in tortoisesvn) and after that apply the patch again, then compile again.

this is missing a step: "reverting" the checkout only reverts files that are present in trunk. new files added to the repository by the patch must be deleted manually

[Norfolkadam]

Have you perhaps applied the patch twice? That could explain it. If so, revert the state (there should be a "revert" button in tortoisesvn) and after that apply the patch again, then compile again.

Other possible explanations why compiling could fail after applying a single patch:
-you applied the patch to another version of openttd than it was made for
-the patch is buggy.
Given the error message you posted neither of these is very likely.

If you were here right now I would kiss you. It's 3:40 and I think I've finally go this ok. It's compiling as we speak. I'll let you know if it works in about 20 minutes.

[Norfolkadam]

Got as far as compiling departures.cpp and then this:

argh.PNG

(278.74 KiB) Downloaded 3 times

[Eddi]

that's one of the newly added files i talked about. open it in an editor, and remove anything after the first duplicate line

[Norfolkadam]

that's one of the newly added files i talked about. open it in an editor, and remove anything after the first duplicate line

Ah okey doke. Well because that sounds like something I'd muck up I've re-downloaded my source, patched it (just the once this time ) and I'm re-compiling. I'll let you know how this goes.

[Norfolkadam]

So I started doing this at about 11pm and it's now 4:36am and I've finally got it right.

Hooray. Thanks for all your help.

[Aylo]

You did it!

I started a game, built a small network with about 5 lines and SPENT ONE HOUR just watching this Depature board with all the delayed trains !!

GREAT JOB

[maselbe]

I downloaded the win32 binary and tested your patch and it worked like a charm.
But a few day's back I created a scenario and when I started playing it, the game frequently crashed.
Do you still bug fix this patch and if so do I post a savegame here along with my newgrf list?

[hthhs]

Do you still bug fix this patch and if so do I post a savegame here along with my newgrf list?

Yes (assuming the crash is the fault of this patch) and yes.

[maselbe]

Well i'm assuming it has to be something with the patch, because it's the only thing different from my normal games. If not my apologies.
I'm also playing with the streettraffic AI.

[oberhümer]

It doesn't look like it has anything to do with the patch, the game's apparently checking the position of a vehicle on a tile, which is something this should not affect. Try to recreate the same situation with unpatched OpenTTD.

[maselbe]

It doesn't look like it has anything to do with the patch, the game's apparently checking the position of a vehicle on a tile, which is something this should not affect. Try to recreate the same situation with unpatched OpenTTD.

Played the same scenario with the latest stable and same NewGRF files and that game doesn't crash.
I'll try loading the saved game I posted here into the stable and will check if the crash occurs.

[hthhs]

It isn't a fair comparison unless you test it with unpatched r21920, as it may contain bugs that are not present in the latest stable.

The crash does occur with unpatched r21920, so it's not the fault of the patch.

[maselbe]

It isn't a fair comparison unless you test it with unpatched r21920, as it may contain bugs that are not present in the latest stable.

The crash does occur with unpatched r21920, so it's not the fault of the patch.

So if I understand correctly it is the r21920 release of openttd that causes the crash ?
Is it possible to change the offered win32 binary to a newer (more stable) version ?

[hthhs]

Done.