AIRail::BuildNewGRFRailStation

[Kogut]

Why that:

Code: Select all

	local hangar = AIAirport.GetHangarOfAirport(tile_1);

	if (!AIEngine.IsValidEngine(engine)) {
		AILog.Error("Couldn't find a suitable engine");
		return false;
	}
	
	AILog.Error("aircraft " + AIError.GetLastErrorString());
	local vehicle = AIVehicle.BuildVehicle(hangar, engine);
	AILog.Error("aircraft " + AIError.GetLastErrorString());
	if (!AIVehicle.IsValidVehicle(vehicle)) {
		AILog.Error("Couldn't build the aircraft " + AIError.GetLastErrorString());
		AISign.BuildSign(hangar, "HERE "+AIDate.GetCurrentDate());
		return false;
	}

Result in?
What may be cause of UNKNOW error?
Engine is correct, depot place is correct, money is sufficient...

[Yexo]

There are several causes that can result in ERR_UNKOWN, but in the end for all of them the AI has made a wrong choice. (trying to build a non-aircraft at an airport, trying to build on a non-hangar tile, building planes on a heliport, etc.) If you upload an AI that reproduces the problem I'll take a look at it.

[Kogut]

Standard settings, seed 1, problem before 15 January, openttd 1.0.0-RC1.

[Morloth]

Hey Kogut,

I just tried out your version and if I add the following rule to the FindAircaft method the code to this:

Code: Select all

function KWAI::FindAircraft(airport_type, passenger_cargo_id) {
   ...
   assert(engine_list.Count() > 0);
   return engine_list.Begin();
}

I get an assertion error. What you want to do, is not only check for AIEngine.GetCargoType(engineID) == passenger_cargo_id, but also for: AIEngine.CanRefitCargo(engineID, passenger_cargo_id) and make sure you don't return an empty list.

That should fix your problem, good luck with your AI!
Bram

[Kogut]

Thanks!

[Kogut]

What you want to do, is not only check for AIEngine.GetCargoType(engineID) == passenger_cargo_id, but also for: AIEngine.CanRefitCargo(engineID, passenger_cargo_id) and make sure you don't return an empty list.

How to do it using valuators?

How to replace "AIEngine.GetCargoType" in

Code: Select all

engine_list.Valuate(AIEngine.GetCargoType);

with CanRefitCargo(EngineID engine_id, CargoID cargo_id)?

[Zuu]

How to replace "AIEngine.GetCargoType" in
Code:
engine_list.Valuate(AIEngine.GetCargoType);


with CanRefitCargo(EngineID engine_id, CargoID cargo_id)?

engine_list.Valuate(AIEngine.CanRefitCargo, cargo_id);

The first parameter to a valuator function will always be taken from the list to valuate, the next parameters you send to the valuators as argument to the Valuate function.

[Kogut]

Thanks!

New problem: I have:

tileindex pozycja;
industrID industry_list

And I want valuate industry_list according to distance from tile pozycja.
So I want to valuate with AITile.GetDistanceManhattanToTile(AIIndustry.GetLocation( <HERE ENTRY FROM INDUSTRY LIST> ), pozycja);

How to do it?

[Zuu]

For that you need to write your own function that take am industry id and return the distance using the code you wrote. Pass this function to the valuate function.

[Zutty]

That is a good way of doing it, however in this particular case AIIndustry has a handy dandy function to do this for you...

Code: Select all

industry_list.Valuate(AIIndustry.GetDistanceManhattanToTile, pozycja);

[Kogut]

Thanks!

Now I have problems with cargo catchment. In noai api there is function

Code: Select all

AIStation::GetCoverageRadius(AIStation::StationType station_type)  	

As argument it need station type. Unfortunatelly it is broken confused me, because various airports have various coverage (see picture, straight part of roar/canal/rail is size of catchment), and I need fuction that can tell me is (constructed) airport in one of loading tiles of industry.

http://noai.openttd.org/api/trunk/class ... d96eba1275

EDIT: I have workaround, but that function is broken may confuse sb.

[Yexo]

For airports you can use AIAirport::GetAirportCoverageRadius

[PikkaBird]

As argument it need station type. Unfortunatelly it is broken,
EDIT: I have workaround, but that function is broken.

I realise English isn't your first language Kogut, but be careful telling devs that functions are "broken" when it's more likely you're just not using them correctly. It's a little bit rude...

[Kogut]

I changed to sth else, and I have next problem: is it possible to get refit cost of vehicle?

[Zuu]

If you have the vehicle in a depot then you can use AITestMode and AIAccounting mode togeather to get the price of a refit without actually executing it. If you want information about a vehicle before it is built then it is not a vehicle, but an engine. Engine information you get by using AIEngine. Have a look there if refit cost can be obtained. If not, that is probably because of a limitation with respect to how the NewGRF system was designed.

[Kogut]

Is it counted as sloped tile?

[fanioz]

It should only flat (grass) tiles there. Look here

[Kogut]

Thanks!

Why it is impossible to execute Sleep command in non static function outside start function? Is it possible to remove that limitation?

[Yexo]

Why it is impossible to execute Sleep command in non static function outside start function?

That is possible.

[Kogut]

So why it happened?