Cargo Distribution

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Cargo Distribution

Post by 2007Alain2007 »

What do all the setings do becuse i dont get it.

This what i want to have all cargos routed and not tons off cargo

Can some help i read wika and i am more lost then i was befor
For Community Integrated Version http://code.google.com/p/civopenttd/
MJS
Director
Director
Posts: 540
Joined: 28 Jul 2005 09:31

Re: Cargo Distribution

Post by MJS »

MJS wrote:The new overviews of passenger flows at a station in the Station GUI - which look wonderful, by the way - seem not to be sticky. It might be nice to either make a patch setting for the preferred view (in my case, Via-Destination-Source, but of course others will prefer other views) or (in addition?) a station-by-station stickiness.

Also, the patch settings for cargodist are still under 'link graph', aren't they? That seems slightly inappropriate; having 'cargo distribution' under 'vehicles', 'stations' or a 'routing' category sounds more suitable.
Sorry, with the latest version I now see the first point has been solved.
Luckz
Engineer
Engineer
Posts: 20
Joined: 02 Aug 2006 03:48
Location: CGN / VLN

Re: Cargo Distribution

Post by Luckz »

bokkie wrote:[..] go to a predetermined destination ánd if you didn't have a connection to that destination the passenger just wouldn't show up. So, it wasn't too hard to make a profit in the beginning as it would be in if this principe would be adhered to for all passengers (which I heard is in Simutrans), it was rewarded to connect more cities (as in more passengers) and there weren't any passengers piling up / showing up for destinations which weren't available.
I'd absolutely love that feature, personally.
MartinL
Engineer
Engineer
Posts: 1
Joined: 11 May 2009 20:12

Re: Cargo Distribution

Post by MartinL »

Hi, just reporting a bug. I'm running a78a93b1 on Linux.

I had just started a game and set up a few bus routes, using shared orders on groups of buses. I had the orders window open and was inserting an extra stop between the existing two. I had selected the last order, clicked go to, but when I clicked on the station the game crashed on the following assertion:

openttd: /home/martin/packages/cargodist/src/vehicle.cpp:1537: void Vehicle::LeaveStation(): Assertion `ls.frozen >= v->cargo_cap' failed.

I reloaded the game from the latest autosave and tried again, and wasn't able to reproduce the bug. Since the error is in LeaveStation(), I guess maybe it's dependent on the precise timing of adding the order as a vehicle is leaving or something.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

MartinL wrote:Hi, just reporting a bug. I'm running a78a93b1 on Linux.

I had just started a game and set up a few bus routes, using shared orders on groups of buses. I had the orders window open and was inserting an extra stop between the existing two. I had selected the last order, clicked go to, but when I clicked on the station the game crashed on the following assertion:

openttd: /home/martin/packages/cargodist/src/vehicle.cpp:1537: void Vehicle::LeaveStation(): Assertion `ls.frozen >= v->cargo_cap' failed.

I reloaded the game from the latest autosave and tried again, and wasn't able to reproduce the bug. Since the error is in LeaveStation(), I guess maybe it's dependent on the precise timing of adding the order as a vehicle is leaving or something.
This is the same problem as the one ftk has detected. I already have a resolution for it. I hope I'll find the time to publish a new version tomorrow.
The guy on the picture is not me, it's Alonso.
Luckz
Engineer
Engineer
Posts: 20
Joined: 02 Aug 2006 03:48
Location: CGN / VLN

Re: Cargo Distribution

Post by Luckz »

I had that crash at least 25 times. Very reproducible. Changing the orders of any vehicle that's currently loading to instead load stuff for another station generally does the trick.
(looking at stations which just got new destinations to send goods to is also a good way to cause crashes - especially if you click things that say "unknown station")
takas
Engineer
Engineer
Posts: 11
Joined: 02 Jul 2006 11:42

Re: Cargo Distribution

Post by takas »

I am not sure if it is a bug.
My metro network has originally stations A and B. Now a station C is added in between. All my trains stops at C now, but my pax at A refused to get on the train, and instead waiting for the train that goes directly to B, causing big jam at A.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

I have posted a new patch with the "frozen" problem resolved. It occasionally recalculates the frozen values for a station now. It shouldn't crash anymore, but it isn't very elegant like this.
takas wrote:I am not sure if it is a bug.
My metro network has originally stations A and B. Now a station C is added in between. All my trains stops at C now, but my pax at A refused to get on the train, and instead waiting for the train that goes directly to B, causing big jam at A.
Most likely you have too high values for the average unit and interval. I'll reduce the default values in the next release.

I'm still fairly busy so you'll have to live with a somewhat slow progress for some weeks (except if someone decides to help me ...). Thanks for all the bug reports. Each of them will eventually be resolved.
The guy on the picture is not me, it's Alonso.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

el koeno wrote:Bug report:

Clicking Gossau-Zug station (or Meyrin, or Prilly) crashes the game.

I know fonso's currently away, but perhaps he'd like to have something to do when he gets back. :D
Could you please post the version string you see in the title of the main menu. I can't find out how you produced that savegame. I have tried to load it with various combinations of trunk and cargodist versions, but I keep getting broken chunks.

Also for others who give me save games: If it isn't obvious which versions of trunk and cargodist you were using to produce them, please make that explicit.
The guy on the picture is not me, it's Alonso.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

Luckz wrote: (looking at stations which just got new destinations to send goods to is also a good way to cause crashes - especially if you click things that say "unknown station")
Can I get a savegame (plus version information) of that please?
The guy on the picture is not me, it's Alonso.
el koeno
Route Supervisor
Route Supervisor
Posts: 454
Joined: 24 Sep 2004 15:47

Re: Cargo Distribution

Post by el koeno »

fonso wrote:Could you please post the version string you see in the title of the main menu. I can't find out how you produced that savegame. I have tried to load it with various combinations of trunk and cargodist versions, but I keep getting broken chunks.

Also for others who give me save games: If it isn't obvious which versions of trunk and cargodist you were using to produce them, please make that explicit.
I'm sorry, it was a game I had posted a bug report on earlier, so I assumed the version was clear. Of course this was some time ago, so this isn't obvious anymore. Apologies for the inconvenience.

I'm pretty sure I used a binary ChillCore posted a few pages back. Main menu says: "OpenTTD r16119M"
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

el koeno wrote:I'm sorry, it was a game I had posted a bug report on earlier, so I assumed the version was clear. Of course this was some time ago, so this isn't obvious anymore. Apologies for the inconvenience.

I'm pretty sure I used a binary ChillCore posted a few pages back. Main menu says: "OpenTTD r16119M"
This is the bug with circular routes. It has been resolved in newer versions.
The guy on the picture is not me, it's Alonso.
User avatar
ChillCore
Tycoon
Tycoon
Posts: 2858
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: Cargo Distribution

Post by ChillCore »

Here's a new build from the patch as found on first page.
I only converted it to svn.

Not very much tested yet ...

@fonso:

When i load my favorite savegame i experience slowdowns after about a year of ff.
I have not tested with a new game and i did not play with the settings, yet.
Attachments
cargodist_r16249_svn.patch
(173.11 KiB) Downloaded 140 times
cargodist_r16249.7z
(2.93 MiB) Downloaded 161 times
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

ChillCore wrote: When i load my favorite savegame i experience slowdowns after about a year of ff.
I have not tested with a new game and i did not play with the settings, yet.
Please post the save game and elaborate a bit. Does the speed go down slowly or suddenly at a specific date? Are there any specific combinations of actions that provoke the slowdown? Am I right to assume the problem occurs with the patch/binary you have just posted?

I already noticed some slowdown myself. I suspect this is because of the rewrite of the loading code. The more flows are available at a station the longer the loading can take. The fact that cargo packets in a cargo list can't be quickly accessed by source station or next hop is most likely becoming a problem. I'll create a new branch "optimization" to conduct some experiments when the other problem reports have been resolved.
The guy on the picture is not me, it's Alonso.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

Toni Babelony wrote:Something strange in my games when compiling with the latest patch... Numbers seem to be missing. I have attached a screenshot of a game and you'll see. The towns, map-size, etc. also don't have numbers, but zeroes. In previous compilations this wasn't the case.
I compiled the latest version with mac os 10.4/xcode 2.0 on an IBook G4 and don't see the problem. This is probably as near as I can get to your platform. However you have loads of grfs some of which I have never seen in that savegame. Some get disabled when I load it, for others it can't find the correct version and another one is loaded. I'd suspect a bug either in OpenTTDs grf loading or in those grfs.
The guy on the picture is not me, it's Alonso.
Rubidium
OpenTTD Developer
OpenTTD Developer
Posts: 3815
Joined: 09 Feb 2006 19:15

Re: Cargo Distribution

Post by Rubidium »

fonso wrote:I compiled the latest version with mac os 10.4/xcode 2.0 on an IBook G4 and don't see the problem.
To reproduce it you need a trunk revision between 16124 (inclusive) and 16188 (exclusive).
User avatar
ChillCore
Tycoon
Tycoon
Posts: 2858
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: Cargo Distribution

Post by ChillCore »

fonso wrote: Does the speed go down slowly or suddenly at a specific date?
Slowdowns do not happen all of as sudden.
It happens in small steps.
Untill it grinds to a halt.
I should add to this that i did not wait to see if the game unfreezes after some time.
Also i did not yet test with other savegames.

It looks / feels like memory not being freed.
It could also be my available memory (1024 mb) running out.
fonso wrote: Are there any specific combinations of actions that provoke the slowdown?
No i just load my game and observe the smallmap and station gui.
I did not build new trains, or extend the network nor did i change orders on existing trains.
fonso wrote: Am I right to assume the problem occurs with the patch/binary you have just posted?
yes, i do not have linux.
It also happens with previous builds i made.
I did not however reduce accuracy or any other settings this time
doing so in a previous test postponed the slowdowns to a later date but did not make it go away.

Attached is my savegame.
I used quite some newgrf.(George's ECS vectors 5 with parameters and lots of eyecandy.)
Just ask if you need the list.
Attachments
chicop eerste 07.sav
(147.87 KiB) Downloaded 123 times
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

edit: question obsolete, see http://bugs.openttd.org/task/2874
The guy on the picture is not me, it's Alonso.
User avatar
ChillCore
Tycoon
Tycoon
Posts: 2858
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: Cargo Distribution

Post by ChillCore »

Strange, when i use a clean config file i get an assert after a few seconds:
(loading any savegame.)

Assertion failed!
file : .../src/linkgraph/mcf.cpp
line: 64
Expression: edge.capacity > 0 && edge.distance <UINT MAX


When i use my shared openttd.cfg it does not happen.

I have been browsing the forums a bit and i think my mingw install needs updating.
I do not know if it is related.

ps:
The slowdown (noticable) with my savegame happens in september 2149.
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: Cargo Distribution

Post by fonso »

ChillCore wrote:Strange, when i use a clean config file i get an assert after a few seconds:
(loading any savegame.)

Assertion failed!
file : .../src/linkgraph/mcf.cpp
line: 64
Expression: edge.capacity > 0 && edge.distance <UINT MAX


When i use my shared openttd.cfg it does not happen.

I have been browsing the forums a bit and i think my mingw install needs updating.
I do not know if it is related.

ps:
The slowdown (noticable) with my savegame happens in september 2149.
Nice to know you see that assertion too. I was suspecting my incompatible grf set was causing it. What does "any savegame" mean? Are those savegames from before cargodist or ones you created with a previous version of cargodist? Can you post the openttd.cfg where it doesn't happen?
The guy on the picture is not me, it's Alonso.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 12 guests