Patch: Found a town

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

removed newer patch below
Last edited by 2007Alain2007 on 25 Apr 2009 00:38, edited 1 time in total.
For Community Integrated Version http://code.google.com/p/civopenttd/
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

Heres a nice update from me hope you like it
fund_town_r16138.patch
fund_town_r16138.7z
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
NekoMaster
Tycoon
Tycoon
Posts: 4001
Joined: 16 Aug 2008 22:26
Skype: neko-master
Location: Oshawa, Ontario, CANADA

Re: Patch: Found a town

Post by NekoMaster »

Ok, Im not on windows anymore, so how do i apply this to the Ubuntu64 binary?
Yexo
Tycoon
Tycoon
Posts: 3663
Joined: 20 Dec 2007 12:49

Re: Patch: Found a town

Post by Yexo »

NekoMaster wrote:Ok, Im not on windows anymore, so how do i apply this to the Ubuntu64 binary?
You don't apply patches to the binaries, but to the source. See the sticky for how to do that. The windows build is useless for you if you don't use windows.
User avatar
belugas
OpenTTD Developer
OpenTTD Developer
Posts: 1507
Joined: 05 Apr 2005 01:48
Location: Deep down the deepest blue
Contact:

Re: Patch: Found a town

Post by belugas »

A shame... All those pages of nothing but updates.
No improvements, no comments, nothing.
Looks like the feature was not so desired after all...
If you are not ready to work a bit for your ideas, it means they don't count much for you.
OpenTTD and Realism? Well... Here are a few thoughs on the matter.
He he he he
------------------------------------------------------------
Music from the Bloody Time Zones
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

I wanted it and i think this patch is done that why were only been updateing it
For Community Integrated Version http://code.google.com/p/civopenttd/
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Found a town

Post by dihedral »

that is quite amusing, to see you consider a patch to be "done"... ^^
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

why do you say that it works dose not it and dose what it was made to do so what is your meaning of done then
For Community Integrated Version http://code.google.com/p/civopenttd/
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Found a town

Post by dihedral »

Code: Select all

printf("%s%s%s%s%s %s%s%s%s%s\n", "h", "e", "l", "l", "o", "w", "o", "r", "l", "d");
this also works and does what it is supposed to do - however, i doubt anybody would consider it "done" if the aim is to print "hello world"!

implementation, and coding style are also part of the thought behind "done"

besides, hearing "it is done" (wrt to coding) from a person who has no (or if then barely any) coding skills is quite cute ^^
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

to me the meaning of done is when you get what you want out the patch dose this patch give you found a town have you seen any bug in it becuse i have not for one

so how is it not done
For Community Integrated Version http://code.google.com/p/civopenttd/
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: Patch: Found a town

Post by Roujin »

What patch is that you guys have been updating all the time? It's not my version (of page 7)... hopefully it's not the initial one without belugas' and my improvements. :roll:

Oh and Alain, that's exactly why the devs are deciding if something goes in trunk and not the users. From a users point of view a patch may be acceptable, but from a developers point of view unacceptable.
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Found a town

Post by dihedral »

Image

DONE*!!

* according to Alain ^^
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

please delete this post
Last edited by 2007Alain2007 on 30 Apr 2009 14:28, edited 1 time in total.
For Community Integrated Version http://code.google.com/p/civopenttd/
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Found a town

Post by dihedral »

last time i checked the definition of "help" was not "doing all the work of the person asking for it!"
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

please delete this post
Last edited by 2007Alain2007 on 30 Apr 2009 14:28, edited 1 time in total.
For Community Integrated Version http://code.google.com/p/civopenttd/
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Found a town

Post by dihedral »

patch -p0 < file.diff && svn up (up to the r to which the process shows no conflicts!)

that's something everybody can do to be honest, and as soon as you hit a conflict or coding is involved in any way, you start asking others to do the work! (e.g. "does your patch with this other patch" /me points at cargodest + IS)

in that case it is not just patching the sources with 2 patch files, you will have to do some coding in order to get that to work!!
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

please delete this post
Last edited by 2007Alain2007 on 30 Apr 2009 14:28, edited 1 time in total.
For Community Integrated Version http://code.google.com/p/civopenttd/
dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: Patch: Found a town

Post by dihedral »

yes - true - has nothing to do with this thread, has to do with you saying stupid stuff all the time or needing help with YOUR patch pack all the time - these are no baby sitter forums!

but as this is off topic - perhaps one of the mods can split this part of into another thread: "Alain vs dih" ^^
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Patch: Found a town

Post by 2007Alain2007 »

please delete this post
Last edited by 2007Alain2007 on 30 Apr 2009 14:28, edited 1 time in total.
For Community Integrated Version http://code.google.com/p/civopenttd/
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 1 guest