resurrection of diagonal level and clear patch

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
RSpeed tycoonfreak
Transport Coordinator
Transport Coordinator
Posts: 349
Joined: 02 Feb 2006 13:17
Location: Azewijn The netherlands
Contact:

Re: resurrection of diagonal level and clear patch

Post by RSpeed tycoonfreak »

nice! I like it:D
Visit The Fake Airport Website
Image
Hobbys: being 18 years old, soccer, go karting, and transport tycoon.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: resurrection of diagonal level and clear patch

Post by Terkhen »

What is the status for this patch?. I used to include the version posted at Flyspray in all of my builds (correcting rejections manually) but with recent changes in trunk it has become impossible...
aepurniet
Engineer
Engineer
Posts: 9
Joined: 13 Nov 2007 14:42

Re: resurrection of diagonal level and clear patch

Post by aepurniet »

this is my favorite feature that is not in the trunk. i dont get the arguements against it (using the ctrl key for it), especially if one makes drag and draw the default behavior. (maybe through one of those fancy advanced options). i almost dont use diagonal tracks anymore since this is not available.
Aali
Traffic Manager
Traffic Manager
Posts: 144
Joined: 01 Oct 2008 00:04
Location: Sweden

Re: resurrection of diagonal level and clear patch

Post by Aali »

why would you need this patch to use diagonal tracks..?
aepurniet
Engineer
Engineer
Posts: 9
Joined: 13 Nov 2007 14:42

Re: resurrection of diagonal level and clear patch

Post by aepurniet »

diagonal tracks cannot have inclines, so you have to clear a way for long stretches. its annoying to do with the standard tools, and i just wind up making right angle style tracks (with a decent turn radius of course). this takes away from profit since, the nondirect route can be close to twice as long.
User avatar
Torben DH
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 31 Dec 2004 09:09
Location: Denmark

Re: resurrection of diagonal level and clear patch

Post by Torben DH »

hmm this is interesting and iit sounds really stupid that its on trunk because you have to use Ctrl when dragging since you dont use that now when leveling or clearing ground...

also i was thinking is it possible to make a patch that would only clear ground in a pattern? ex if you are struggling with a town using trees it would be really usefull if you could mak a patch that makes it possible to demolish only 2x2 tiles between the town roads... and the same for 3x3tiles or 3x2 or 4x2 etc. etc.
TDH
Eddi
Tycoon
Tycoon
Posts: 8289
Joined: 17 Jan 2007 00:14

Re: resurrection of diagonal level and clear patch

Post by Eddi »

aepurniet wrote:diagonal tracks cannot have inclines, so you have to clear a way for long stretches. its annoying to do with the standard tools, and i just wind up making right angle style tracks (with a decent turn radius of course). this takes away from profit since, the nondirect route can be close to twice as long.
actually, this only takes away profit you shouldn't have had in the first place, because distance is calculated by the Manhattan metric.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: resurrection of diagonal level and clear patch

Post by Terkhen »

Eddi wrote:actually, this only takes away profit you shouldn't have had in the first place, because distance is calculated by the Manhattan metric.
Then why do we have diagonal tracks in the first place?.
aepurniet
Engineer
Engineer
Posts: 9
Joined: 13 Nov 2007 14:42

Re: resurrection of diagonal level and clear patch

Post by aepurniet »

"shouldnt have had" is a funny way to put it, diagonal tracks were in the original game by sawyer. anyways, sounds like its just us out here, the developers and commiters have de facto found this patch unworthy of trunk, regardless of how it is written. players, anyone else find this useful? developers, is this patch just too hard to maintain? committers, is this patch not gonna wind up in the trunk? (meaning, the idea is judged untrunkworthy regardless of how it is writtern)

also is this patch client side only (meaning, you can play on unpatched servers, with other unpatched clients)? i ussually play single player.
Agent_N
Engineer
Engineer
Posts: 4
Joined: 18 Aug 2008 15:17

Re: resurrection of diagonal level and clear patch

Post by Agent_N »

I just made an update the the current revision.
Attachments
diaglvl_java_r15599.patch
(17.93 KiB) Downloaded 120 times
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: resurrection of diagonal level and clear patch

Post by fonso »

If I knew what the devs don't like about this patch or which version they prefer, I'd fix it.
The guy on the picture is not me, it's Alonso.
User avatar
NukeBuster
Traffic Manager
Traffic Manager
Posts: 222
Joined: 04 Jan 2006 18:16
Location: Alphen aan den Rijn, The Netherlands
Contact:

Re: resurrection of diagonal level and clear patch

Post by NukeBuster »

Well, the patch I have maintained for a while had some nasty recurrencies in it. And that was something left unsolved...
NukeBuster

Transport Empire: The Transport Empire Linux effort
Join the Transport Empire IRC channel: [url]irc://irc.oftc.net/transportempire[/url] !

OpenTTD patch(es): Password at join
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: resurrection of diagonal level and clear patch

Post by fonso »

NukeBuster wrote:Well, the patch I have maintained for a while had some nasty recurrencies in it. And that was something left unsolved...
Did you have a look at my patches? I took yours and improved it. I believe I found and corrected all the obvious problems. But if you find anything still missing you might want to tell me. I know the patches are a little outdated at the moment. I'm somewhat tired of maintaining three versions in parallel and I'm also working on cargo distribution, so have some patience with me.
The guy on the picture is not me, it's Alonso.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: resurrection of diagonal level and clear patch

Post by fonso »

I updated both variants and posted them here.
The guy on the picture is not me, it's Alonso.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: resurrection of diagonal level and clear patch

Post by Terkhen »

Thank you, fonso! :D
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: resurrection of diagonal level and clear patch

Post by Terkhen »

I found a strange bug compiling current trunk with the java version of the patch. If you try to lower land at a water tile, the whole game freezes. I was going to try it with the C version too, but flyspray is very laggy today and I can't download it.
Ruudjah
Engineer
Engineer
Posts: 46
Joined: 12 Nov 2007 11:09

Re: resurrection of diagonal level and clear patch

Post by Ruudjah »

I would absolutely love to see this in trunk. However, I must agree with the devvers that pressing ctrl to use this is nonsense. Why not just combine orthogonal and diagonal leveling? If you are close to diagonal, show that, and when you are lose to orthogonal, show that. I do not see the problem? Why use ctrl for it?
Yexo
Tycoon
Tycoon
Posts: 3663
Joined: 20 Dec 2007 12:49

Re: resurrection of diagonal level and clear patch

Post by Yexo »

Ruudjah wrote:I would absolutely love to see this in trunk. However, I must agree with the devvers that pressing ctrl to use this is nonsense. [q/uote]You agree with someone? I don't see anyone before saying that pressing ctrl for it is nonsense.
Why not just combine orthogonal and diagonal leveling? If you are close to diagonal, show that, and when you are lose to orthogonal, show that. I do not see the problem? Why use ctrl for it?
Like when? When I move my mouse in a diagonal line, how does the game determine whether or not I want to level diagonal? Exactly, it can't, therefor some modifier (or a seperate button) is needed.
User avatar
fonso
President
President
Posts: 948
Joined: 13 Oct 2007 08:28

Re: resurrection of diagonal level and clear patch

Post by fonso »

The problem with the "java" style version was that I had accidentally removed a range check. Here's an update. In the C++ style version the problem isn't present.
Attachments
diaglvl_java_r15883.diff
(18.29 KiB) Downloaded 118 times
The guy on the picture is not me, it's Alonso.
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: resurrection of diagonal level and clear patch

Post by Terkhen »

Thank you, fonso :)
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 15 guests