Infrastructure Sharing

[Aali]

Confirmed and fixed.

Updated patches in the original post.

[Roest]

Confirmed and fixed.

Updated patches in the original post.

Maybe it's better to post updates in the current post if you're not the thread owner.

[Tvel]

"Here is win binary with last fix "

edit: new version, old removed.

[fabca2]

Confirmed and fixed.

Updated patches in the original post.

So fast ! you rocks !

Here is win binary with last fix

and it works perfectly.

thanks

[deepblue2k8]

I tested your binary, but I still can't see the income or costs for tracksharing in the financial window. I compiled the patch myself, but it seems, that it is still the old version for openttd revision 15416 in Aali's post

[el koeno]

Here is win binary with last fix

Even though I had the same problem Deepblue had, I'd very much like to say: Thanks for that! It worked very well, though I did not test extensively. Would it be impolite to request a version including ITiM and passenger reduction? Perhaps that would lead to conflicts, I don't know.

On a gameplay related note: I played around a bit on a small map, against AdmiralAI, and it was a fun experience. However, the only real interaction I could have with it was through airports (it hadn't built RVs yet). There's was no way to connect to a train station, and connecting a local bus network to one of their airports was also impossible. I'd say connecting your own loading bay to one of their stations/airports should be possible. It should still count as an opponent's station, him/her being the one who's able to destroy it etc.

[Tvel]

deepblue2k8, Aali only fixed the bug, he didn't tweak the finance window. I support your request too, but It may be not too easy to do. Aali is just updating the old patch to the new nightlies and we can't force him to do the finance improvement.

el koeno, I was thinking the same, this patches with ITiM and passenger reduction will be great. I will see what i can do, but I have little free time these weeks.

[Aali]

I've decided to drop the non-cargodest version of this patch to make it easier for me to make updates.

Most of my work should be on the new IS patch after all

The finances window has been fixed to include IS, both standard and grouped version.
For some reason road stop and harbour fees were not copied to the company-specific settings but deliberately set to 0, this has also been fixed.

[Jans]

wich source I have to use to compile the patch from Aali. I`m very interested in the new finance window.

[Tvel]

Nice work Aali

[deepblue2k8]

First of all, thanks for the awesome work of maintaining the old patch Aali .
I think IS is one of the most useful features that should be added to OpenTTD.

@Tvel, of cause we can't force him . But the shared infrastructure income line was already in the old patch, so I missed it a bit

I tried to apply the current nightly 15447 with the cargodest_patch Aali attached in his last post, but TortoiseMerge (Windows) aborts with an error message, that "The patch seeems outdated" on various files..
I dont know if I did it correctly. Is cargodest already included in your patch, Aali, or do I have to apply the cargodest patch before for this patch to work?
OK, i just tried it on my own . Applied first cargodest_patch and it worked...
So nevermind

But I still can't compile, because the file <boost/graph/adjacency_list.hpp> is missing in my source folder.?

Again, thanks for the work and @Tvel, thanks for the binary

[Tvel]

@deepblue2k8,
Aali uses "boost library" to make cargodest work, so you need to download them and put them into the library directories
you need only some header files, you don't have to compile boost.


@Aali
got a crash, tried to repeat it but no luck, still here is some info:
i was checking an airport with other company plane landing and got a crash

openttd.exe!GetTileOwner(unsigned int tile=40807744) Line 136 + 0x30 bytes
openttd.exe!OnSharedClose(Owner old_company=1, unsigned int close_bits=0) Line 984 + 0x26 bytes
openttd.exe!SharedSettingDelay() Line 382

[Aali]

got a crash, tried to repeat it but no luck, still here is some info:
i was checking an airport with other company plane landing and got a crash

openttd.exe!GetTileOwner(unsigned int tile=40807744) Line 136 + 0x30 bytes
openttd.exe!OnSharedClose(Owner old_company=1, unsigned int close_bits=0) Line 984 + 0x26 bytes
openttd.exe!SharedSettingDelay() Line 382

Yet another bad assumption about aircraft that doesn't hold with freeform map edges
The patch has been updated.

[Tvel]

New binary with the fix:

[retroip]

Hi guys,

Last Changed Author: peter1138
Last Changed Rev: 15447
Last Changed Date: 2009-02-11 08:17:39 +0100 (Wed, 11 Feb 2009)

I have problem with compiling
I have clean 15447 just with this patch (infrastructure_sharing_cargodest_r15447.patch) ,compilling on FreeBSD 7.0-STABLE Sun Jun 1 02:30:04 CEST 2008 i have this error:

Code: Select all

[SRC] Compiling aircraft_cmd.cpp
/usr/home/retro/openttd/src/aircraft_cmd.cpp: In function 'StationID FindNearestHangar(const Vehicle*)':
/usr/home/retro/openttd/src/aircraft_cmd.cpp:108: error: 'SharedAirports' was not declared in this scope
/usr/home/retro/openttd/src/aircraft_cmd.cpp: In function 'CommandCost CmdBuildAircraft(TileIndex,
 DoCommandFlag, uint32, uint32, const char*)':
/usr/home/retro/openttd/src/aircraft_cmd.cpp:260: error: 'SharedAirports' was not declared in this scope
/usr/home/retro/openttd/src/aircraft_cmd.cpp:441: error: 'SharedDepotProvision' was not declared in this scope
/usr/home/retro/openttd/src/aircraft_cmd.cpp: In function 'void AircraftEventHandler_Flying(Vehicle*, 
const AirportFTAClass*)':
/usr/home/retro/openttd/src/aircraft_cmd.cpp:1639: error: 'SharedAirports' was not declared in this scope
/usr/home/retro/openttd/src/aircraft_cmd.cpp:1656: error: 'SharedStationFee' was not declared in this scope
gmake[1]: *** [aircraft_cmd.o] Error 1
gmake[1]: Leaving directory `/usr/home/retro/openttd/objs/release'
gmake: *** [all] Error 2

Any experience someone else ?

[Aali]

First of all, that patch doesn't apply to clean r15447, it needs the cargodest patch (the name of the patch is a less than subtle hint)

But your errors suggest you didn't fix all those rejects you got when applying the _incompatible_ patch, ignored all the warnings and just went ahead and compiled it anyway.

[retroip]

o man, im lama, sorry I did not red it carefully , uh..

[Chico008]

It's a standalone patch you released Aali ?
or do i need to put another patch before this one ?

i tried to patch with r15447 from trunk, but patch failed.

Thanks for continuing this patch ^^

[Eddi]

"it failed" is not a problem report.

is it so hard to copy-paste the error message in here?

[Aali]

Well, he didn't even have time to read the other posts in this thread to find his answer so obviously he's in some kind of hurry.