[Patch] Improved Timetable Management [V2.31tr SVN15778]

[hinkelstein]

Hi Tekky,

I've just downloaded your binary. Thanks for providing it.
Unfortunately the game crashes right after startup. Anybody else having this problem?
V 1.54 worked without a problem.

Jan

[PhilSophus]

Unfortunately the game crashes right after startup. Anybody else having this problem?
V 1.54 worked without a problem.

Just to clarify: This happens when just the title screen is loaded and without loading any "real" game?

Could you please start it from a command line and post the error it gives (if any). I can't see from the crash log whether this is a failed assertion, or a bad memory access (aka segmentation fault in Linux).

Anyone knows what exception C0000005 is? And does anyone have the possibility to find out, what function or even source line address 0044CC9A is at (i.e 4CC9A from the start of openttd.exe).

Anybody else having this problem?

I second that.

[Rubidium]

Anyone knows what exception C0000005 is? And does anyone have the possibility to find out, what function or even source line address 0044CC9A is at (i.e 4CC9A from the start of openttd.exe).

That's a segmentation fault. I know there's a tool to give you some information about that source address, but I don't know what it's called nor where to find it.

[PhilSophus]

I just retried and get a assert fail when loading the title screen. I assume that is a problem with very old save games (like the title screen is). I think I only tested it with loading a relatively new game from the command line with -g. That is why I didn't discover it before publishing

I'll have a look at the problem.

Edit: Fixed the problem (one should not access the routing network before it is properly initialized). The fixed version is attached to the top post.

Note: The problem existed only in the cargodest version, thus no update to the trunk version.

[Tekky]

I have compiled a Win32 binary of realistic timetables version 1.551 with cargodest. It can be downloaded from this link:

http://rapidshare.com/files/146342374/r ... _1_551.zip
EDIT: This binary is now out of date. Also, this version is known to create INVALID SAVEGAMES. A more recent binary of a version, in which this bug has been fixed, is available later in this thread.

Disclaimer: Please note that I merely compiled the patched source code and checked the binary for viruses using VirusTotal. I have not audited the source code itself. Therefore, I cannot provide any warranty that this binary contains no harmful code.

This disclaimer is only provided for legal reasons and I have no reason to believe that this binary contains harmful code, as I have been using this binary myself.

[Erik1984]

It (1.55) crashed when I loaded my newest savegame. Older saves of the same game load well, but this is the save I made with realistic tt 1.55

Reason: Assertion failed at ..\src\order_cmd.cpp:357: first->prev == NULL

edit: The previous saves were made in 0.6.1, not only without realistic tt but also without cargodest. So it might be a cargodest problem?

[PhilSophus]

You are using the cargodest variant? Then please try V1.551. If the the problem remains with 1.551 please upload your savegame.

Edit: Never mind, I can reproduce it with V1.551. I'm working at a fix.

Edit2: Please do not use V1.55x (trunk or cargodest) as it produces invalid savegames.

I removed the patches and I am working at a solution.

[rbn2903]

@Tekky, thanks for your help. I finally got the sourcecode, but neither Mingw32 nor Visual C++ 2008 worked for me. Lets face it, I'll stay put with my VB.Net 2008 skills

Given that you share orders by ctrl-clicking on another vehicle, wouldn't it be quite annoying if a pop-up would ask for confirmation?

Well, ähm, no. I didn't even think about a popup. Maybe its just, that I build very slowly and like to know exactly what happens to my network. But if there'd be an automatically updated separation, I wouldn't cry

[PhilSophus]

Okay, I fixed the issue with saving. V1.56 is attached to top post.

Please do not use V1.55 or V1.551 as it is producing invalid savegames.

Unfortunately, there is no automatic way of fixing the savegames produced by V1.55 and V1.551 as the mapping between an order list and the shared vehicle chain is lost. I apologize for the loss of the affected savegames and hope you didn't lose to much. If that is the case I can only offer to provide a version that assigns the order lists to arbitrary vehicle chains, so that only orders would need manual reworking.

[Wibblebutt]

I have noticed that in many of my timetables, an extra minute or two gets added each trip.

For example in the attached savegame the whole round trip is 4 hours. The first trip leaves Highland Park East at 20:30, but by the time it comes to leave for the third trip it is now scheduled to leave at 04:31, when it should be 04:30 (20:30 + 8 hours)

I am using Tekky's binary with V1.54 and cargodest.

timetablestart.png (167.62 KiB) Viewed 1506 times

Timetablestart.sav

(360.9 KiB) Downloaded 118 times

timetableafter2trips.png (173.67 KiB) Viewed 1495 times

[Tekky]

I have compiled a new Win32 binary of realistic timetables version 1.56 with cargodest. It can be downloaded from this link:

http://rapidshare.com/files/146428780/r ... s_1_56.zip
EDIT: This binary is now out of date. A more recent binary is available later in the thread.

Disclaimer: Please note that I merely compiled the patched source code and checked the binary for viruses using VirusTotal. I have not audited the source code itself. Therefore, I cannot provide any warranty that this binary contains no harmful code.

This disclaimer is only provided for legal reasons and I have no reason to believe that this binary contains harmful code, as I have been using this binary myself.

[PhilSophus]

I have noticed that in many of my timetables, an extra minute or two gets added each trip.

For example in the attached savegame the whole round trip is 4 hours. The first trip leaves Highland Park East at 20:30, but by the time it comes to leave for the third trip it is now scheduled to leave at 04:31, when it should be 04:30 (20:30 + 8 hours)

If you turn on display of seconds you will notice that the travel time from first to second order is not exactly 20 minutes but 20 min. 58 sec. These 58 seconds soon add up to minutes. Probably this odd time was created by autofill. If you set the time manually to 20 or 21 minutes the effect should be gone. Given that you can switch between days and virtual time any time there is no unit autofill could sensibly round to. So, I don't consider this a bug.

[Wibblebutt]

I have compiled a new Win32 binary of realistic timetables version 1.56 with cargodest. It can be downloaded from this link:

http://rapidshare.com/files/146428780/r ... s_1_56.zip

Once a vehicle is bought and you click on 'display company vehicles' the game crashes. Error report:

*** OpenTTD Crash Report ***
Date: 2008-09-19 10:20:51
Build: h2d7ff353M built on Sep 18 2008 23:26:47
Reason: Assertion failed at ..\src\gfx.cpp width > 0
Language: english.lng
Exception C0000005 at 0042715D
Registers:
EAX: 01FC6B80 EBX: 0000001F ECX: 01FC6B80 EDX: 01FC6BB3
ESI: 0012FB70 EDI: 0012F2B4 EBP: FFFFFFF8 ESP: 0012F26C
EIP: 0042715D EFLAGS: 00010206

Bytes at CS:EIP:
C6 05 00 00 00 00 00 33 D2 39 54 24 18 7F 25 68 4C AD 60 00 68 9A 05 00

Stack trace:
FFFFFFF7 00000000 01E0D540 004BAF90 000000DB 00C8B8F8 0000000E 00000000
00000020 0000001A 023EDA60 00000006 00000000 00000082 00000000 01432180
00000400 004260BB 00000062 00000000 00426190 023EDA60 0000B133 00000029
00000000 004BDC7F 00000020 0000FFFF FFFFFFF7 01E0D540 004BE2FA 023EDA60
0000000F 00000000 004256F2 000000DD 00000000 00000001 00000000 72676E55
6570756F 72742064 736E6961 00000000 00E35498 00000008 00C80178 0012F36C
005348FE 00E354A0 0012F628 0012F48C 005348FE 00E354A0 0012F5C8 0012F49C
0012F560 0012F6B8 0012F574 00466A75 00000006 0012F68C 0012F588 0012F6B8
6E756C50 6C6C6968 00466600 0000072F 0000001E 00E35F60 00C80178 00000211
0012F5BC 7C911538 7C911596 7C9106EB 7C9105D4 00000ABE 00000ABE 0012F3EC
005348FE 00E354A0 005348FE 00000001 0012F640 0012F514 00000060 01FC71E8
0012F5F4 000000FB 00000013 01FC71E8 00464A5D 000000FB 01FC8000 0000000A
01FC71E0 0012F444 00000000 00000000 01FC71E0 01FC79C0 01FC71E8 00000000
00C80178 000007D8 000071E8 00C80000 0012F214 000007D8 0012F464 02000000
7C9106F0 FFFFFFFF 7C9106EB 0059D4CC 00C80000 00000008 0059D525 00C80000
00E35498 0000036A 0012F478 7C911BFF 00C80000 00E35498 00E35498 00C80000
00E36000 00D60000 01000000 0012F4C0 7C911E2E 0000036A 00E35498 00000000
00C80000 00E35498 00000000 00000FE8 00E36000 0012F4BC 00D60000 00000000
00000000 00000000 0000016D 00000000 000001FD 0012F590 7C910ECA 7C910E91
00C80608 7C91056D 01A603AC 00E354A0 00000004 02000000 D7018FD7 00C80000
01FC71E0 01FC79B8 0012F510 7C910F46 000000C9 01FC79B8 00C80000 01FC71E0
00C80000 00C80000 00C80178 0012F5E4 7C910E91 00C80608 7C91056D 00000000
01FC71E8 000013A2 02000000 4343453C 01FC71E0 00C80178 D7A2A4D7 01FC71E8
43434343 00E354A0 A4D7D702 00C80178 41453CD7 00E35498 02913C40 00000000

Module information:
C:\Program Files\OpenTTD\openttd.exe handle: 00400000 size: 2422784 crc: 213DB857 date: 2008-09-18 11:28:50
C:\WINDOWS\system32\ntdll.dll handle: 7C900000 size: 708096 crc: A5A50370 date: 2004-08-04 07:56:36
C:\WINDOWS\system32\kernel32.dll handle: 7C800000 size: 984576 crc: 2CCFBF2B date: 2007-04-16 15:52:53
C:\WINDOWS\system32\WINMM.dll handle: 76B40000 size: 176128 crc: 123646FA date: 2004-08-04 07:56:46
C:\WINDOWS\system32\USER32.dll handle: 7E410000 size: 577536 crc: DF3237C6 date: 2007-03-08 15:36:28
C:\WINDOWS\system32\GDI32.dll handle: 77F10000 size: 282624 crc: 18201B20 date: 2008-02-20 06:51:05
C:\WINDOWS\system32\ADVAPI32.dll handle: 77DD0000 size: 616960 crc: 5E7A2F0A date: 2004-08-04 07:56:41
C:\WINDOWS\system32\RPCRT4.dll handle: 77E70000 size: 584192 crc: B1CE66F6 date: 2007-07-09 13:09:42
C:\WINDOWS\system32\Secur32.dll handle: 77FE0000 size: 55808 crc: 5A32C057 date: 2004-08-04 07:56:44
C:\WINDOWS\system32\WS2_32.dll handle: 71AB0000 size: 82944 crc: 9738CC56 date: 2004-08-04 07:56:46
C:\WINDOWS\system32\msvcrt.dll handle: 77C10000 size: 343040 crc: 5298C0C5 date: 2004-08-04 07:56:43
C:\WINDOWS\system32\WS2HELP.dll handle: 71AA0000 size: 19968 crc: F5DD5AB6 date: 2004-08-04 07:56:46
C:\WINDOWS\system32\IMM32.DLL handle: 76390000 size: 110080 crc: FD65A0DD date: 2004-08-04 07:56:42
C:\WINDOWS\system32\LPK.DLL handle: 629C0000 size: 22016 crc: 3AC484CC date: 2004-08-04 07:56:42
C:\WINDOWS\system32\USP10.dll handle: 74D90000 size: 406528 crc: 826D7E56 date: 2004-08-04 07:56:46
C:\WINDOWS\system32\serwvdrv.dll handle: 5CD70000 size: 14848 crc: F5919143 date: 2001-08-18 12:00:00
C:\WINDOWS\system32\umdmxfrm.dll handle: 5B0A0000 size: 13312 crc: DAFF19A8 date: 2001-08-18 12:00:00
C:\WINDOWS\system32\SHFolder.dll handle: 76780000 size: 25088 crc: 2EC7582B date: 2004-08-04 07:56:45
C:\WINDOWS\system32\SHLWAPI.dll handle: 77F60000 size: 474112 crc: 9628C42B date: 2007-08-22 12:55:41
C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.2600.2982_x-ww_ac3f9c03\comctl32.dll handle: 773D0000 size: 1054208 crc: 58D6578C date: 2006-08-25 15:45:55
C:\WINDOWS\system32\comctl32.dll handle: 5D090000 size: 617472 crc: 232F6674 date: 2006-08-25 15:45:58
C:\WINDOWS\system32\wdmaud.drv handle: 72D20000 size: 23552 crc: 982E84EE date: 2004-08-04 07:56:57
C:\WINDOWS\system32\WINTRUST.dll handle: 76C30000 size: 176640 crc: 88D208BD date: 2004-08-04 07:56:46
C:\WINDOWS\system32\CRYPT32.dll handle: 77A80000 size: 597504 crc: 971ECFAA date: 2004-08-04 07:56:41
C:\WINDOWS\system32\MSASN1.dll handle: 77B20000 size: 57344 crc: D5127637 date: 2004-08-04 07:56:42
C:\WINDOWS\system32\IMAGEHLP.dll handle: 76C90000 size: 144384 crc: 714A70BC date: 2004-08-04 07:56:42
C:\WINDOWS\system32\msacm32.drv handle: 72D10000 size: 20480 crc: D5406BAE date: 2001-08-18 12:00:00
C:\WINDOWS\system32\MSACM32.dll handle: 77BE0000 size: 71680 crc: 6A21891E date: 2004-08-04 07:56:42
C:\WINDOWS\system32\midimap.dll handle: 77BD0000 size: 18944 crc: 502B5282 date: 2004-08-04 07:56:42
C:\WINDOWS\system32\ole32.dll handle: 774E0000 size: 1285120 crc: AD325A7F date: 2005-07-26 04:39:48
C:\WINDOWS\system32\uxtheme.dll handle: 5AD70000 size: 218624 crc: 5AA98F22 date: 2004-08-04 07:56:46
C:\WINDOWS\system32\MSCTF.dll handle: 74720000 size: 294912 crc: 5B427982 date: 2008-02-26 11:59:50
C:\WINDOWS\system32\CLBCATQ.DLL handle: 76FD0000 size: 498688 crc: 9DED030F date: 2005-07-26 04:39:43
C:\WINDOWS\system32\COMRes.dll handle: 77050000 size: 792064 crc: 5A12B4A2 date: 2004-08-04 07:56:41
C:\WINDOWS\system32\OLEAUT32.dll handle: 77120000 size: 550912 crc: 18657280 date: 2007-12-04 18:38:13
C:\WINDOWS\system32\VERSION.dll handle: 77C00000 size: 18944 crc: CFE439BB date: 2004-08-04 07:56:46
C:\WINDOWS\System32\dmime.dll handle: 5C570000 size: 181248 crc: F18E50F8 date: 2004-08-04 07:56:42
C:\WINDOWS\System32\DSOUND.dll handle: 73F10000 size: 367616 crc: F0EFB582 date: 2004-08-04 07:56:42
C:\WINDOWS\System32\dmusic.dll handle: 6C980000 size: 104448 crc: 0C1C73CE date: 2004-08-04 07:56:42
C:\WINDOWS\system32\KsUser.dll handle: 73EE0000 size: 4096 crc: 519CF22C date: 2004-08-04 07:56:42
C:\WINDOWS\System32\dmsynth.dll handle: 6C9A0000 size: 103424 crc: ECEFF055 date: 2004-08-04 07:56:42
C:\WINDOWS\System32\dmloader.dll handle: 6CA10000 size: 35840 crc: CCCBFD58 date: 2004-08-04 07:56:42
C:\WINDOWS\system32\msctfime.ime handle: 755C0000 size: 177152 crc: 6A712F98 date: 2004-08-04 07:56:13
C:\WINDOWS\system32\mswsock.dll handle: 71A50000 size: 245248 crc: CE1B185F date: 2008-06-20 17:41:10
C:\WINDOWS\system32\hnetcfg.dll handle: 662B0000 size: 344064 crc: 6CF15ACF date: 2004-08-04 07:56:42
C:\WINDOWS\System32\wshtcpip.dll handle: 71A90000 size: 19968 crc: B88CC0E5 date: 2004-08-04 07:56:46
C:\WINDOWS\system32\psapi.dll handle: 76BF0000 size: 23040 crc: 97A44A88 date: 2004-08-04 07:56:44

System information:
Windows version 5.1 2600 S

[Tekky]

I also get this assertion error when I buy a train and then click on the "display list of company's trains" button immediately afterwards.

This assert is NOT triggered in the unpatched cargodest version and also NOT in realistic timetables 1.54 (cargodest version), but it is triggered in 1.55 (cargodest version). Therefore, I believe this is a bug introduced in realistic timetables version 1.55 (cargodest version). I have not tested how the non-cargodest version of the realistic timetables patch behaves.

[PhilSophus]

This time it was not the OrderList rewrite but the unification of vehicle list and group GUI in trunk. That made it a bad idea to insert a new widget in only one of them (thus in the group GUI the scrollbar instead of the vehicle matrix was referenced, which was a bit small for the display of trains , triggering the assert).

The fixed version V1.57 is attached to the top post. Both trunk and cargodest version 1.56 were affected by the bug.

I apologize again for inconvenience and hope that real timetables is stabilized again, so that I can tackle new features (I've already a nice headway view in mind).

[Tekky]

I have compiled a new Win32 binary of realistic timetables version 1.57 with cargodest. It can be downloaded from this link:

http://rapidshare.com/files/146570006/r ... godest.zip
EDIT: This binary is now out of date. A more recent binary is available later in the thread.

Disclaimer: Please note that I merely compiled the patched source code and checked the binary for viruses using VirusTotal. I have not audited the source code itself. Therefore, I cannot provide any warranty that this binary contains no harmful code.

This disclaimer is only provided for legal reasons and I have no reason to believe that this binary contains harmful code. I have been using this binary myself and have a very good opinion of OpenTTD and the cargodest and realistic timetables patches.

[Erik1984]

I played 1.57 and now cargodest doesn't work at all. I've put "passengers can be delivered to" on "chosen destinations" and I made a small train network but no passengers at the stations. When I view the graph on the map only the nodes are shown and no connections between the nodes.

edit: strange, it seems to work now so no problem at the moment (after saving and loading my game again).

[PhilSophus]

I played 1.57 and now cargodest doesn't work at all. I've put "passengers can be delivered to" on "chosen destinations" and I made a small train network but no passengers at the stations. When I view the graph on the map only the nodes are shown and no connections between the nodes.

edit: strange, it seems to work now so no problem at the moment (after saving and loading my game again).

So, it doesn't work in a newly started game, but it does on loaded games? Seems I should have another look at the order processing system of cargodest to see if I missed something.

Edit: Sigh, I can confirm this behavior. Strange, the code looks good, so time for the debugger again

[Sacro]

I have compiled a new Win32 binary of realistic timetables version 1.57 with cargodest. It can be downloaded from this link:

http://rapidshare.com/files/146570006/r ... godest.zip

Disclaimer: Please note that I merely compiled the patched source code and checked the binary for viruses using VirusTotal. I have not audited the source code itself. Therefore, I cannot provide any warranty that this binary contains no harmful code.

This disclaimer is only provided for legal reasons and I have no reason to believe that this binary contains harmful code. I have been using this binary myself and have a very good opinion of OpenTTD and the cargodest and realistic timetables patches.

You do not need to provide a disclaimer and in most countries it is probably void anyway. You do however need to include a copy of the GPL and a written offer for source.

[PhilSophus]

Umm, Tekky, I hope you like compiling and RapidShare won't kill you for spamming their server with binaries

Anyway, the fixed version V1.571 for cargodest is attached to the top post. Connections are now properly updated when inserting orders (it sometimes helps to update the pointer to the previous order )

Only cargodest was affected.