Patch: Better Map Borders (r13631)

[CommanderZ]

This patch changes the way how the TGP calculates map borders to make them smoother fit with the terrain and look more natural.

Most functions in tgp.cpp had to be altered to make this possible. The file now in my opinion much better follows the coding style. The alternations to other files are minimal (only one integer changed in unmovable_cmd.cpp).

The patch works for all map sizes and settings (the 64*64 maps are very similiar to those created with TGP though).

EDIT:

I'm no longer posting new versions here as they usually contain only coding style improvements and little bug fixes, please see my BugSpray thread for the latest version.

[Mchl]

Very nice

[Zutty]

Beautiful! That first one in particular is stunning!

[CommanderZ]

Thanks guys!

Here is the patch and an executable. I tried to clean the code up as much as possible.

[LordAzamath]

Build failed with BuildOTTD..

Code: Select all

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: tgp.cpp
|===================================================================
|--- tgp.cpp	(Revision 13191)
|+++ tgp.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
15 out of 15 hunks ignored

I just loaded the patch and put force revision to patch option and compiled

EDIT: Used the binary provided here.. Game crashes every time I try to change random seed, the "Random" button works though and it makes a map
I'll test more..

Yet Another Edit:
I think that your patch somehow screws the random seed.. I took the official trunk and put the same seed in the generator as your patch gave me.. And the maps differ completely

patched.png

Very nice borders, I admit

(96.09 KiB) Downloaded 365 times

unpatched.png

r13374 with the same settings as the patched screenshot

(118.8 KiB) Downloaded 301 times

[CommanderZ]

Game crashes every time I try to change random seed

Thanks for reporting. That's strange...I have no clue why. I will try to compile pure SVN source with my MSVC...maybe it screws it.

I think that your patch somehow screws the random seed.. I took the official trunk and put the same seed in the generator as your patch gave me.. And the maps differ completely

This is expected. I did a lot of changes to noise generation functions (none of them should affect the result though) and - what is more important - the seed is used to generate second set of random numbers for a second height map, which is then substracted from the original one (only in map border areas, of course).

[CommanderZ]

Update time!

News:
- updated to r13631
- improved appearance of very small maps. Performance of this patch is now at least very similiar to unpatched TerraGenesis, but in most cases is vastky better.
- fixed the "lighthouse bug"
- the bug with random seed crash is also solved (not by me thoughy, it was fixed in r13508 by developers)

Patch and win32 executable attached (built with MSVC++ 2008 Express).

I hope the patch file as alright this time.

[CommanderZ]

I'm no longer posting new versions here as they usually contain only coding style improvements and little bug fixes, please see my BugSpray thread for the latest version.

[Octopuss]

Can you explain what exactly this patch does? I can't seem to understand the point and the attached screens don't explain anything either

[PhilSophus]

I had the same problem when reading this topic. However, the flyspray entry is much clearer.

[CommanderZ]

attached screens don't explain anything either

They do, just compare them with maps generated by unmodded TGP

Phil: Okay, I replaced the post with the flyspray text

[Octopuss]

I still don't get it
Perhaps two screens "with" and "without".
Also, what exactly is meant by map borders? The shore?

[CommanderZ]

Map outer shoreline. In unmodded TGP the shoreline is very craggy and unnatural, my patch improves it.