Patch: Signal GUI (Lastest: r5435)

[Bilbo]

It may be due to the devs concentrating on NewIndustries at the moment. I've read a post by a dev in some other thread (don't know exactly where atm) along the lines of "I don't know about the other devs, but I personally decided to devote myself fully at NewIndustries above all other tasks, even looking at patches."

so don't worry, it might just be they are really busy at the time, and will look at your stuff later. :)

It was belugas who said this, though I do not remember which thread either.

[dasy2k1]

ive just downloaded the pach (r10439) and tried to pach my clean copy of openttd r11029

the pach operation works fine but when i compile i get thease errors...

Code: Select all

[SRC] Compiling rail.cpp
[SRC] Compiling road_cmd.cpp
[SRC] Compiling rail_gui.cpp
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp:1308: warning: converting to non-pointer type ‘uint16’ from NULL
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp:1316: error: invalid conversion from ‘int’ to ‘WindowClass’
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp:1316: error: cannot convert ‘const Widget*’ to ‘WindowClass’ in initialization
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp:1316: error: invalid conversion from ‘void (*)(Window*, WindowEvent*)’ to ‘uint32’
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp:1316: warning: missing initializer for member ‘WindowDesc::widgets’
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp:1316: warning: missing initializer for member ‘WindowDesc::proc’
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp: In function ‘void ShowSignalBuilder()’:
/usr/local/games/openttd_trunk/experimental/r11029/src/rail_gui.cpp:1322: warning: unused variable ‘w’
make[1]: *** [rail_gui.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/usr/local/games/openttd_trunk/experimental/r11029/objs/release'
make: *** [all] Error 2
dan@dan-ubuntu:/usr/local/games/openttd_trunk/experimental/r11029$    

any idea what im doing wrong?

[chrissicom]

You might want to check how Signal GUI is implemented in ChrisIN, it doesn't have this compilation error.

[XeryusTC]

Maybe you should try to apply it to the revision the patch has been made for, there can be loads of differences in the meanwhile which can lead to errors.

[PhilSophus]

Maybe you should try to apply it to the revision the patch has been made for, there can be loads of differences in the meanwhile which can lead to errors.

Or if you know a bit of C++ and really want to understand, what happens you could use

Code: Select all

svn diff -r10439:11029 src/rail_gui.cpp

to find out what has been changed.

My guess is, that it might be the unification of the vehicle view window, which changed a lot of text, because all related code of this window was moved/merged from the vehicle-specific files to vehicle_gui.cpp.

[dasy2k1]

i currently have other pactches that require other revisions that are working fine,

i can live without signal GUI untill there is a version for a more recent nightly

[chrissicom]

My guess is, that it might be the unification of the vehicle view window, which changed a lot of text, because all related code of this window was moved/merged from the vehicle-specific files to vehicle_gui.cpp.

Nope, that did not influence the Signal GUI stuff when I updated ChrisIN to the latest trunk code. I never came across this error anyway so maybe you just used the wrong version from this thread. There is one that is made to work together with signal auto complete which is obsolete since Peter has written a sig auto complete for trunk and doesn't require an extra patch anymore. Otherwise just look at the patch lines in the ChrisIN .diff those will compile fine