Patch: Signal GUI (Lastest: r5435)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

The last splited version is very old. I will split it in the next days, atm I have no time.
Red.xiii
Engineer
Engineer
Posts: 93
Joined: 11 Jan 2005 13:33

Post by Red.xiii »

current version in trunk has bug. See http://www.tt-forums.net/viewtopic.php?t=32082
Image
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Answer in the thread you posted. A update will come tomorrow but splitted.
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Okay a few days later but here is it:

I've cleaned the code a litle bit like deleting the signal type arrows which are don't used.

The toolbar overlap fix patch is a version to work together the signal GUI patch.

BamBam

Edit 19. June 2007: update to r10215

Edit 21. June 2007: update to r10239 and make the code and GUI smaller.

Edit 04. July 2007: update to r10419

Edit 04. July 2007:
- removed all downloads from v2 (the version with support for autocompletion from this thread) because since r10437 is the patch obsolete
- update to r10439
- little code modifications
Attachments
toolbar_overlap_fix_r10215_signalGUI.patch
toolbar overlap fix for the signal GUI
(664 Bytes) Downloaded 193 times
signalGUI_r10439.7z
Win32 executable
(916.31 KiB) Downloaded 214 times
signalGUI_r10439.patch
(15.49 KiB) Downloaded 222 times
Last edited by BamBam on 04 Jul 2007 21:11, edited 10 times in total.
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Edit 04. July 2007: removed downloads
Last edited by BamBam on 04 Jul 2007 21:12, edited 4 times in total.
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Edit 19. June 2007: download removed, new one see my posts above
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

An other update (only v1). Send the patch (v1) to flyspray, hope it get into trunk.

Regards,
BamBam

Edit: link to flyspray task
Attachments
The new look of v1 since 10239.
The new look of v1 since 10239.
signalGUI.png (2.43 KiB) Viewed 5652 times
doghousedean
Traffic Manager
Traffic Manager
Posts: 141
Joined: 30 Apr 2007 10:26

Post by doghousedean »

just downloaded v2, there was a line missing from the _Patches declaration,

I hope this is right anyway

Code: Select all

bool sig_autocomplete;    // Signal Autocompletion
Correct me if im way off!
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

BamBam wrote: v2 is the same how v1 but with support for autocompletion from this thread
So it will only work if you use both patches.
User avatar
BeSt-Com
Traffic Manager
Traffic Manager
Posts: 181
Joined: 25 May 2005 18:19
Location: Berlin/Germany
Contact:

Post by BeSt-Com »

nice work.
want to see it in the trunk ;)
User avatar
bobingabout
Tycoon
Tycoon
Posts: 1850
Joined: 21 May 2005 15:10
Location: Hull, England

Post by bobingabout »

support means it'll work with it, not that it requires it.
JPG SUX!!! USE PNG!!!
There are times when JPG is useful, TTD screenshots is not one of them. Please use PNG instead.

[/url]
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Updated (only v1) to r10419 (see my post above).

This Patch exist very long. The first version were posted on Apr. 28 2005 by Hackykid. So my question is to the devs: there are any chance to get this patch into trunk? And when yes, what must be change?

This is my favourite patch from the MiniIN and the only reason why I played this and not the nightly (I didn't used PBS till now).

I hope a dev will answer and raise my hopes.


Hopefully,
BamBam
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

A little update, download see my post above.
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Post by Bilbo »

BamBam wrote: I hope a dev will answer and raise my hopes.
I hope too, this is one of the most useful patches not yet accepted in trunk, as building lots of presignals around huge stations or other constructions is made much easier with this ... you need less clicks for the same result :)
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Post by BamBam »

Thank you Bilbo.

I don't know why there is no answer in this thread or the one opnened by Hackykid. Maybe the devs only answer in IRC?

I will change everythink you say me. :D
User avatar
FooBar
Tycoon
Tycoon
Posts: 6553
Joined: 21 May 2007 11:47
Location: The Netherlands
Contact:

Post by FooBar »

Submit the patch to flyspray (http://bugs.openttd.org/), you'll get an answer there :mrgreen:
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Post by Bilbo »

FooBar wrote:Submit the patch to flyspray (http://bugs.openttd.org/), you'll get an answer there :mrgreen:
Well, the patch was already submitted there - http://bugs.openttd.org/task/902
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
User avatar
Bilbo
Tycoon
Tycoon
Posts: 1710
Joined: 06 Jun 2007 21:07
Location: Czech Republic

Re: Patch: Signal GUI (Lastest: r5435)

Post by Bilbo »

I have modified the patch so that settings of signal GUI is not stored in savegame but instead stored in user preferences (so saving and loading the game will not interfere with it and it won't bump the savegame version)

I've uploaded the modified patch to FS (http://bugs.openttd.org/task/902).
If you need something, do it yourself or it will be never done.

My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility

Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
BamBam
Engineer
Engineer
Posts: 34
Joined: 06 May 2007 17:49

Re: Patch: Signal GUI (Lastest: r5435)

Post by BamBam »

I personally like it to save the setting in savegame, but okay.

I can't update the attachments since the forum is phpBB v3, so I can not put your patch in my post above.
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re:

Post by Roujin »

BamBam wrote:Thank you Bilbo.

I don't know why there is no answer in this thread or the one opnened by Hackykid. Maybe the devs only answer in IRC?

I will change everythink you say me. :D

It may be due to the devs concentrating on NewIndustries at the moment. I've read a post by a dev in some other thread (don't know exactly where atm) along the lines of "I don't know about the other devs, but I personally decided to devote myself fully at NewIndustries above all other tasks, even looking at patches."

so don't worry, it might just be they are really busy at the time, and will look at your stuff later. :)
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 17 guests