Passengers/Mail with Specific Destinations

paijm021 · Post by **paijm021** » 14 Jan 2007 10:03

prissi wrote:Update to r8104, fixed bug with 0 passengers, did rub stable over night

Very nice work Prissi. Passenger lists are all right now.

Fragothic · Post by **Fragothic** » 16 Jan 2007 15:42

The 'crash' bug still exist in my game. I compiled the game with the 8104-diff using cygwin, but the game crashes still randomly.

prissi · Post by **prissi** » 16 Jan 2007 16:07

Did you start a game without destinations and switched them on later? Then this might happen (just press ignore some times will fix this). Otherwise this can pointing to a bug, however, I need a savegame to find out.

(This is an assertion, meaning some internal check has failed. The game can continue anyway, this is just for debugging.)

Fragothic · Post by **Fragothic** » 16 Jan 2007 16:28

I've started a brand new game from scratch using this build. It doesn't crash immediately, but when you let run it for a while, it will crash. After pressing 'ignore' twice, the game quitted. I also tried to use your precompiled version, and also with that version, crashes occured. I've attached my savegame and config

paijm021 · Post by **paijm021** » 16 Jan 2007 17:47

Fragothic wrote:I've started a brand new game from scratch using this build. It doesn't crash immediately, but when you let run it for a while, it will crash. After pressing 'ignore' twice, the game quitted. I also tried to use your precompiled version, and also with that version, crashes occured. I've attached my savegame and config

Hey Fragothic, I analyzed your savegame a little so prissi can spend more time with his wife

.

The game crashes when train 4 arrives at "Lower Little Orentfingyway". The sum of the separate amounts of passengers per destination waiting in this station is lower than the 'total amount' of waiting passengers.

In train 18 the total amount en the sum of the separate amounts don't equal either. When this train enters a station the game will crash.

prissi · Post by **prissi** » 16 Jan 2007 21:17

Running beyond these two errors I could extend the game for quite some time without any error. Hmm, I could not really find out how this error occurred.

paijm021 · Post by **paijm021** » 16 Jan 2007 22:45

prissi wrote:Running beyond these two errors I could extend the game for quite some time without any error. Hmm, I could not really find out how this error occurred.

This error often occurs a while after you build a lot of new stations and trains at once. Maybe it has something to do with the extension of the 'destination network'?

prissi · Post by **prissi** » 16 Jan 2007 23:42

I found an error, the passenger weight were memcpy with wrong size and could overwrite other things

Hope this was the only error.

Updated to 8169, another savegame step up => no old games loadable

Fragothic · Post by **Fragothic** » 17 Jan 2007 16:33

Nice work, Prissi!
I'm going to compile and test it now

Fragothic · Post by **Fragothic** » 17 Jan 2007 18:07

The game is still crashing, producing the same kind of error, but now in vehicle.cpp

bokkie · Post by **bokkie** » 19 Jan 2007 19:37

I've registered just to tell you how much I love this patch!

One of the best patches IMO, it adds a whole lot of fun!!!

Just tried it with Quark's multipatch-build (which doesn't use your last version btw) with long vehicles newgrf, and after a while there were a few busses that suddenly had 1000+ passengers and couldn't drive anymore because of their weight. I forgot to save the game to show it, if I encounter it again I will.

Thanks for your efforts!

Fragothic · Post by **Fragothic** » 20 Jan 2007 09:51

I've made 2 screenshots of the error messages appearing during the crash.

PhilSophus · Post by **PhilSophus** » 20 Jan 2007 12:45

I really love this patch, it makes building passenger networks a lot more fun.

Two minor GUI issues:
- Often, the station windows show a full row of people waiting, even if the number says, that there are only a few people or even no-one waiting.
- Sometimes, there are already passengers waiting to specific destinations, but the the total waiting number still says zero and updates notable (a few seconds later). It might just be minor a GUI issue, but if its really the data that is inconsistent that might explain the failed assertions.

Maybe these issues are already fixed? I am still playing with destination_r8104 applied to trunk r8124 as I want to continue with my saved game.

BTW: How complicated would it be to apply this approach to mail? IMHO it would really make sense there, too. Usually, people care where their mail goes to

prissi · Post by **prissi** » 20 Jan 2007 15:01

Apllication to mail is easily possible, but the current vehicles are not really fit for mail, like the airplanes. This and for the people who prefer the traditional OTTD approach I left the pasengers only with destinations.

By the way, the wrong behaviour is most likely cause by the error I fixed in the lastest release.

paijm021 · Post by **paijm021** » 20 Jan 2007 15:49

prissi wrote:By the way, the wrong behaviour is most likely cause by the error I fixed in the lastest release.

I'm afraid that ain't true yet (Screenshot).

I made some test maps and I can't find situations anymore where I know for certain that the game is gonna crash (particular train entering station). Only 'random' crashes occur with the change of such a crash dramatically increasing with the amount of destinations.

PhilSophus · Post by **PhilSophus** » 20 Jan 2007 15:51

Okay, thank you.

I will start a new game soon anyway as I want to test a game with a few nice patches. (One of them signal auto-complete I just operated out of MiniIN to apply to the trunk. So, if anyone is interested: http://www.tt-forums.net/viewtopic.php?p=544048#544048

I just noticed, you are also from Berlin. What a coincidence

prissi · Post by **prissi** » 20 Jan 2007 16:43

If you look at my homepage, you may found out, that I even hold a PhD for physics ...

Concerning the bugs, I still suspect some memcpy wrong, especially after I found one of them. I will have a look at those.

bokkie · Post by **bokkie** » 22 Jan 2007 17:17

What determines the sorting order of the destinations? Maybe it's convenient to sort it on no. of passengers/destination; this is the easiest way to see where to add busses etc. Is that possible (and: easy to do)? It's not exactly high-priority but it would be a nice touch. Smashing bugs is more important, even though I haven't noticed any in the last few hours.

prissi · Post by **prissi** » 23 Jan 2007 10:27

The sorting order is the station index; this is very important, because is can reduce the search times by a factor of two or more. However, for the display the order could be shown different, although since I even have not time enough to debug, I will not code this in the next three months for sure.

Volny · Post by **Volny** » 26 Jan 2007 12:43

i am playing with exe which was poste like one page ago (so I dont have the latest version), but because I see that there are still some crashes I am posting my savegame - I am not sure if it is of any good tho. (I just want to help a bit.
The game crashes always on 14th feb. Most people here say that they crashes appears quite random so I was thinking that having something reproducable might help?
btw.
this is absolutely GREAT patch, makes the game much more fun!

Transport Tycoon Forums

Passengers/Mail with Specific Destinations

bug

Who is online