Makefile (rewrite) question/suggestion

[skidd13]

At first the rewrite is awesome! But I've to say that looks a bit weird to me. No ctitisism, just wonderd about!

If I execute configure the script generates this in the Makefile:

Code: Select all

INSTALL_DIR = /
INSTALL_BINARY_DIR = "$(INSTALL_DIR)/"/usr/local/games
INSTALL_ICON_DIR = "$(INSTALL_DIR)/"/usr/local/share/pixmaps
INSTALL_DATA_DIR = "$(INSTALL_DIR)/"/usr/local/share/games/openttd

This looks strange to me cause the values of the var's are now:

Code: Select all

INSTALL_BINARY_DIR = "//"/usr/local/games
INSTALL_ICON_DIR = "//"/usr/local/share/pixmaps
INSTALL_DATA_DIR = "//"/usr/local/share/games/openttd

I think it should look like this, cause it looks more linux/unix-like
Or is there any reason why not?

Code: Select all

INSTALL_PREFIX = /
INSTALL_BINARY_DIR = "$(INSTALL_PREFIX)usr/local/games"
INSTALL_ICON_DIR = "$(INSTALL_PREFIX)usr/local/share/pixmaps"
INSTALL_DATA_DIR = "$(INSTALL_PREFIX)usr/local/share/games/openttd"

The bundle function is great, but why you call it bundle?
I'd like the way the Makefile of the linux-kernel use: pkg-bz2 for example?
Just more linux like.
And why copy the files to the bundle-dir instead of linking it (just to save space)?

[Rubidium]

Hmm, the first is a good one; have to check that INSTALL_DIR is always set, though as I'm not certain that happens now.

Bundle was named after application bundle for OSX. Linking is not cross-platform compatible, for example in Windows linking does not always work.

The naming of a lot of things in makefile rewrite seems to become under discussion. Maybe they should be discussed here first, and when there is a nice and *consistent* new naming policy, I'll see what I can do to implement them.

[skidd13]

Thanks for reply.

I found another thing:

Code: Select all

OS = UNIX

shoudn't this be linux or is it a general thing? (I'm using linux)

[Rubidium]

Thanks for reply.

I found another thing:

Code: Select all

OS = UNIX

shoudn't this be linux or is it a general thing? ;) (I'm using linux)

It's general; linux is usually regarded as being a unix too.

[skidd13]

There is the code for the OSX bundles, but what about some code for rpm, deb and all the other packages?

[Rubidium]

If somebody comes up with the code/files needed to make an rpm, I could add it (as for any other 'type' of packaging needed.

For debian the files are already there, only no make directive.

The only 'problem' is that before you can make the package, you have to run configure, which might not be wanted. This (at the moment) hard to solve. Can look into some solution when I've got more time to spare.