Patch: Drive-Through Road Vehicle Stops

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

There's another new update (in the first post) against r7152.

Drive-through road stops can now be removed using the remove tool. This removes the road stop and leaves the road in place. The dynamite tool can still be used to clear the tile completely.
Image
Nickel_Plate
Traffic Manager
Traffic Manager
Posts: 146
Joined: 27 Dec 2004 19:37
Location: Home of the Big Cat

Post by Nickel_Plate »

Have downloaded and compiled patch ran program got error which said could not find roadstop.grf, when looking at data file it seems grf file downloaded in not called roadstop.grf but roadstop_991.grf. So is patch incorrect or grf file.
User avatar
Maedhros
OpenTTD Developer
OpenTTD Developer
Posts: 603
Joined: 30 Mar 2006 18:24
Location: Durham, UK

Post by Maedhros »

The forums automatically add numbers at the end of filenames to stop conflicts. Just rename the grf file and it'll be fine. :wink:
No-one's more important than the earthworm.
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Thanks for answering this one Maedhros. But please note Nickel_Plate, the grf file should be named roadstops.grf (not roadstop.grf).
Image
Nickel_Plate
Traffic Manager
Traffic Manager
Posts: 146
Joined: 27 Dec 2004 19:37
Location: Home of the Big Cat

Post by Nickel_Plate »

Forgot to type the "s" when writing
goalie
Route Supervisor
Route Supervisor
Posts: 406
Joined: 28 Aug 2003 14:54
Location: Düsseldorf
Contact:

Post by goalie »

i dont konw how to compile with drive through and destinations can somone compile and send such a version to AGraewer@gmx.net
sorry for my bad english
User avatar
DirtY iCE
Engineer
Engineer
Posts: 25
Joined: 12 Aug 2006 15:29
Location: *unknown*
Contact:

Hungarian Translation (but only if you need it)

Post by DirtY iCE »

mart3p: Well, I don't know do you need that, but I've translated that 2 string that you added to english.txt. I've attached the diff file, so if you want to internationalize your patch you can add it to them.
Attachments
drive_thru_hun.diff
Hungarian translation
(805 Bytes) Downloaded 127 times
Last edited by DirtY iCE on Boomtime, the 65th day of The Aftermath in the YOLD 3173, edited 782,469,123.3691 times in total.
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Thanks Dirty ICE. :) I will add the stings next time I do an update.
Image
User avatar
CMircea
Chairman
Chairman
Posts: 887
Joined: 29 Dec 2006 14:05

Post by CMircea »

How about making this for the latest RC?
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Desolator wrote:How about making this for the latest RC?
Do you mean you would like a patch that can be applied against the 0.5.0-RC4 source code? If so, then it is possible, let me know.

Or, do you mean you would like a binary with the patch included built from 0.5.0-RC4 source code? I am planning to post a new win 32 exe with the patch included. This will be built from the trunk code, that way you get everything in 0.5.0 with the addition of new trunk features like 'bridges over everything'.


Back in September last year:
mart3p wrote:
Slace wrote:I found an issue with this patch, if you line up the stops end to end the buses only go to the 1st stop, then never go through to the next one.
Yes, this is a known issue, due to the existing multistop code preferring the nearest stop unless it is full.
hertogjan wrote:Isn't it possible to make a patch option which allows you to choose between either the current behaviour, or vehicles that will automatically choose the farthest free slot?
This may be possible, I already have a few ideas... ;)
Well, finally I’ve added this feature. :) Drive-through road stops can now work effectively built in-line. A vehicle about to stop will now move forward to use the next stop in-line, if it is free. It will keep moving forward until it reaches the furthest free stop, allowing other vehicles to fill the stops behind.

Also added, thanks to Dirty ICE, Hungarian translations.

The new patch against r8425 is in the first post.

Edit: A win32 exe built at r8435 with drive-through road stops is in the 2nd post.
Attachments
DT Freight Stops.png
DT Freight Stops.png (22.58 KiB) Viewed 3396 times
DT Bus Stops.png
DT Bus Stops.png (20 KiB) Viewed 3396 times
Image
Chicago Rail Authority
Traffic Manager
Traffic Manager
Posts: 134
Joined: 09 Nov 2006 23:38

Post by Chicago Rail Authority »

This is fantastic. I was re-reading the post in hopes that the *.exe would be available 'soon' and somehow had missed that you edited your last msg and actually posted it awhile ago...

Great job!
Many thanks to those who make OTTD and TTDP possible.
jungle
Engineer
Engineer
Posts: 76
Joined: 17 Dec 2004 23:40
Location: UK

Post by jungle »

Fantastic patch - it seems to have everything nicely worked out now that it works properly with multiple stops.

Does anyone know how close this is to going into the trunk?
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Chicago Rail Authority wrote:Great job!
jungle wrote:Fantastic patch - it seems to have everything nicely worked out now that it works properly with multiple stops.
Thanks :D

There are still a few improvements I’m working on. I have building drive-through stops over town-owned roads working (and the road reverts to town-ownership if the road stop is removed). It will be a patch option.
Image
Chicago Rail Authority
Traffic Manager
Traffic Manager
Posts: 134
Joined: 09 Nov 2006 23:38

Post by Chicago Rail Authority »

Question...
If you have two consecutive bus stops, [A]->, and three vehicles approaching {3}{2}{1}... Vehicle {1} will go to the last stop to load/unload, and vehicle {2} will go to the next open stop, [A]. When vehicle {1} finishes loading/unloading, it departs... leaving vehicle {2} at stop [A] and vehicle {3} sitting idle on the road tile waiting for vehicle {2} to move.

Is it possible to have vehicle {3} "see" that stop is open after vehicle {1} leaves, and simply drive around the still loading vehicle {2}?

If this is too confusing, I could try to put together a screenshot and post/PM it...

Thanks!
Many thanks to those who make OTTD and TTDP possible.
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Chicago Rail Authority: I understand what you mean, you are asking if vehicles can be made to overtake others that are loading/unloading.

I don’t think this could be done without considerable changes and additions to the patch. I won’t say it’s impossible, but I can’t see me doing it. But maybe I’ll have a look at the existing overtaking code and see how that works... ;)
Image
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

mart3p: there have been several changes to the variables in the RoadStops section of the savegame in trunk. Various supposedly "unused" variables have been NULLed. I think these may affect your patch.
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
User avatar
mart3p
Tycoon
Tycoon
Posts: 1030
Joined: 31 Oct 2005 21:00
Location: UK

Post by mart3p »

Thanks richk67, I had seen those changes in the trunk but my patch doesn't use those variables.

The latest version of my patch (at r8425) can be applied without conflicts to the latest trunk. At least, it did when I last checked yesterday evening at r8485. :)
Image
User avatar
Born Acorn
Tycoon
Tycoon
Posts: 7596
Joined: 10 Dec 2002 20:36
Skype: bornacorn
Location: Wrexham, Wales
Contact:

Post by Born Acorn »

All we need now is this *in* trunk. :p
Image
Chicago Rail Authority
Traffic Manager
Traffic Manager
Posts: 134
Joined: 09 Nov 2006 23:38

Post by Chicago Rail Authority »

Agreed!! :)

Do any of the Devs reading this have any constructive thoughts/opinions/criticisms on if it would be possible to have waiting vehicles overtake loading vehicles to reach otherwise-obstructed loading stops?

mart3p - the above is not in reference to your willingness/ability to figure it out on your own - I'm just in hopes that we can get some visibility to this great patch and get any/all necessary 'final' tweaks to get it in trunk ASAP :)

Great work!
Many thanks to those who make OTTD and TTDP possible.
Tomsomethingcon
Engineer
Engineer
Posts: 123
Joined: 16 Nov 2006 16:52

Post by Tomsomethingcon »

Chicago Rail Authority wrote:Agreed!! :)mart3p - the above is not in reference to your willingness/ability to figure it out on your own - I'm just in hopes that we can get some visibility to this great patch and get any/all necessary 'final' tweaks to get it in trunk ASAP :)

Great work!
This patch is Awesome, love using buses now..

Well done !!!
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 25 guests