Loop wrote:Secondly, I completely don't understand the devs. If the idea of the patch isn't welcome - why did you help him clean up the code in the first place?
The idea isn't welcome. The idea is just accepted. By some devs it is accepted without big problems, by some others it is hardly accepted. We all understand that for some sort of users it can be funny to play with faces. But the game is about something else. So even if it will meet all technical requirements to be accepted as a patch, it will stay a very low priority task.
And why i helped him to cleanup the code? It will be bit longer reading:
1. Jez was loud enough on IRC and talking about "community" that wants this patch. When we started to talk about it i had no idea what it does.
2. I looked at the face customization dialog screenshots and understood what it is about. And even i don't like this idea at all, i tried to help him as i know how painful the acceptance process could be.
3. When i looked into code (his original patch) i told me "oh my god! why i wasn't rather silent. why i offered him the help without looking into code first!"
4. So i explained Jez that there is no way how to get this cryptic code into trunk. It needed to be rewritten from the scratch. So we simply started - two weekends we worked together (VNC + Skype). Each round was like: 10 minutes when Jez explained me what some piece of code is supposed to do, 5 minutes of me fixing it, then 20-40 minutes of hard arguing why it needs to be fixed and then 5 minutes me having nicotine break. Uff. Terrible work. Alone I would have it done in few hours, but i wasn't able to understand the original code.
5. When finished, I started discussion with devs what more we need to do before it can be committed.
6. After fixing of few overlooked formatting issues (to be coding guidelines compliant) i needed to explain how it works, what was changed from original ottd code, and so on.
7. Then devs realized that it breaks the savegame compatibility and we started discussions what we can do with it. The result is that such feature is definitely not so important that we need it also at the cost of broken savegame compatibility. It was already told, that 0.5.0 will keep 100% backward compatibility as it continuously requested by large number of users.
8. There is also another issue. Many users would like to keep the face dialog as simple as possible, they like the randomizer and they don't ask us for more comprehensive face customization. Therefore the idea about hiding right side of dialog on default.
Loop wrote:It looks very, very strange. He starts his work. You help him with it, work on it together. It is obvious, that when the devs interfere with mortal-patches, they want them IN the trunk.
Hehehe. Totally wrong assumptions. You are bit demagogic in your way of explanation.
1) He started his work long time before we started any interactions. No devs asked him to do it. Nobody promised that it will go into trunk.
2) The only what was obvious was that the code can't be committed as it was. Nobody except Jez and few others here have expressed that he wants it IN trunk. No. I tried to help Jez to get the patch accepted. Then the commit would be just few seconds task.
Loop wrote:So jez is cleaning the code, following the guidelines, and when he finishes his work... you say suddenly: no, we don't want this patch!
Again totally wrong.
1) Jez is not cleaning the code. Jez heavily defended each part of his original cryptic code against cleanup. I did the cleanup. He helped me to don't break the functionality (explained how it works, checked all my changes and tested it, helped to hunt all my errors).
2) No, the work is not yet finished. period.
3) No, nobody told "No". It just passed the first round of iteration process and it passed it well. Few minor changes are needed and if done properly, the next round can be the last one and then commit.
4) Jez has problems to accept it. Not we.
