Face customization patch - TESTING requested!

Bot_40 · Post by **Bot_40** » 25 Sep 2006 00:01

White looks the best, the ones with many colours seem a bit 'random'. If this gets into the trunk I'll be well chuffed, this is a feature I always thought was greatly needed.

jez · Post by **jez** » 25 Sep 2006 11:06

I've updated my original post, now it contains v2 of the patch.

The GUI has been rearranged, the attribute numbers are white, all now start at 1 instead of 0 and increment contiguously.

jez · Post by **jez** » 25 Sep 2006 12:45

I think these 2 face variable structure files may be useful to code reviewers too. One's my interpretation of what the old (32 bit uint) structure was, and the other's how my new code interprets it.

Loop · Post by **Loop** » 25 Sep 2006 12:55

Great job on this!

Can't wait to see it in the MiniIN or in the trunk. Excellent!

I have only one, little idea: why not turn around the Load and Save buttons, so save is on the left, and load on the right. Dunno why, it seems more natural to me like this.

jez · Post by **jez** » 25 Sep 2006 14:45

In many GUI toolbars, 'open' (similar to Load) is to the left of 'save', so I think this way is more intuative.

Bjarni · Post by **Bjarni** » 29 Sep 2006 22:06

I wonder if we will see a version 3 of this patch with the coding changes applied to it. After giving feedback on the code, I haven't heard anything

Will this patch be finished or is it one of those that will only make it half way. It can't be added to the trunk in it's current form because the code is really messy. For one, who knows what goes on where, it should not be hard to fix though.

jez · Post by **jez** » 15 Oct 2006 16:00

Have edited the original post, which now contains v3 of the face customization patch.

It utilises the new widgets code and doesn't have to fake widgets any more, as well as having a plethora of code changes that make it more consistent with the OpenTTD coding style. The screenshot is unchanged from v2 as the GUI is virtually identical.

Loop · Post by **Loop** » 15 Oct 2006 18:25

Cool!

Will it be tested and included in the trunk?

DaleStan · Post by **DaleStan** » 15 Oct 2006 18:50

Well, only you can control whether or not you test it.

jez · Post by **jez** » 18 Oct 2006 11:17

Uploaded v4 of the patch. Fixed a minor argument type issue.

jez · Post by **jez** » 18 Oct 2006 18:19

Uploaded v5 of the patch. Conforms better to OpenTTD coding conventions.

glx · Post by **glx** » 18 Oct 2006 20:03

/* Eyes */ switch is not needed

Code: Select all

if (FC_GETEYES > face_limits[FC_GENDER_ETH_COUNT][FC_EYES])
  FC_SETEYES(face_limits[FC_GENDER_ETH_COUNT][FC_EYES]);

does the same

/* Suit / Collar */ switch is not needed

Code: Select all

/* eg. (x % 4 - 2) limits x to the 3rd value in any block of 4. */
if (thisval % 4 > 2) {thisval -= (thisval % 4 - 2);}
break;

is enough

jez · Post by **jez** » 19 Oct 2006 09:15

Posted v6 of the patch, incorporated glx's comments.

skidd13 · Post by **skidd13** » 22 Oct 2006 18:34

Nice patch.

Attatched the german translation for the patch.
But STR_FACE_GENDERETH fits in german not in the widget.

Maybe anyone has a better translation?

glx · Post by **glx** » 22 Oct 2006 19:24

Never do translations for a patch, if the patch is added to trunk you'll need to redo it with WT2

jez · Post by **jez** » 22 Oct 2006 19:50

glx: no idea what you meant by that, but I've incorporated the German translation into v7 of my patch anyway.

v7 also widens the face window so that nasty long German language can fit in there

, and slightly modifies DrawFaceStringLabel() so that the labels' draw location is completely based on their associated widget.

jez · Post by **jez** » 22 Oct 2006 20:02

skidd13: As an aside, I had to muck around a with with that .patch file before I could get it to work. What's up with it? It seems to be slightly corrupted; this is the second time I've had trouble getting someone's patch on here to work. What tool are you using to create it? TortoiseSVN certainly didn't like it. I initially got the error, "The chunk size did not match the number of added/removed lines!".

skidd13 · Post by **skidd13** » 22 Oct 2006 20:06

jez wrote:skidd13: As an aside, I had to muck around a with with that .patch file before I could get it to work. What's up with it? It seems to be slightly corrupted; this is the second time I've had trouble getting someone's patch on here to work. What tool are you using to create it? TortoiseSVN certainly didn't like it. I initially got the error, "The chunk size did not match the number of added/removed lines!".

sorry, I removed a dubbled line with an editor. Just my fault!

Bjarni · Post by **Bjarni** » 22 Oct 2006 20:15

skidd13 wrote:sorry, I removed a dubbled line with an editor. Just my fault!

Never do that. Each time I tried to do that, I broke the diff, so after a few times, I completely stopped doing it. Using svn to make the diff will ensure that it will live up to the standard so it can be merged

jez · Post by **jez** » 22 Oct 2006 21:08

skidd13: Why did you hyphenate Gesichts-Nummerncode?

Transport Tycoon Forums

Face customization patch - TESTING requested!

Who is online