Build Templates (Copy&Paste) (r13911 + 0.6.3 + 0.6.2)

gkirilov · Post by **gkirilov** » 20 Jun 2006 20:06

I think the more complicated the patch is, the harder it will be to include it in the trunk.

gigajum · Post by **gigajum** » 20 Jun 2006 20:15

gkirilov wrote:I think the more complicated the patch is, the harder it will be to include it in the trunk.

if you look at the code you will recognize it will hardly get into trunk

Frostregen · Post by **Frostregen** » 20 Jun 2006 20:27

hey, i told you it's not finished

gigajum · Post by **gigajum** » 20 Jun 2006 21:22

Frostregen wrote:hey, i told you it's not finished

then hurry up with coding

Frostregen · Post by **Frostregen** » 24 Jun 2006 02:24

Ok, new version out.
But I still did not split up the code into nice pieces.

Maybe next time

skidd13 · Post by **skidd13** » 24 Jun 2006 10:14

Attached Linux binary + langfiles

Edit: now V8419

skidd13 · Post by **skidd13** » 03 Jul 2006 17:24

Hi, after rewriting my autocompile & install script, i noticed, that the patch throws some rejects:

Code: Select all

...
Hunk #2 FAILED at 380.
1 out of 2 hunks FAILED -- saving rejects to file unix.c.rej
...
Hunk #2 FAILED at 981.
1 out of 2 hunks FAILED -- saving rejects to file win32.c.rej

And there are some warnings regarding pointer usage.

But i didn't noticed any bug's.

compile rev: 5451

Frostregen · Post by **Frostregen** » 03 Jul 2006 20:16

It's only a small merge problem.
Look at the lines which determine the savegame/template extension.
(.tmpl .sav .scn)

The trunk version modified it, but did not change its functionality, so it is safe to keep the lines from my patch.

I'll update the diff files tonight

Note: Bugs should occur, when you try to load/save a template.

skidd13 · Post by **skidd13** » 03 Jul 2006 21:45

Bug in the patch-file:
The copy_paste.c is missing in the patch file.
(nobody's perfect)

Frostregen · Post by **Frostregen** » 03 Jul 2006 22:57

Thx, forgot to remove the line from the makefile

This file is not needed currently.
(.patch updated)

Currently I'm splitting the code into nice *hopefully* human readable pieces.

Salvo_guy · Post by **Salvo_guy** » 07 Jul 2006 11:36

okay... call me stupid... but i can't seem to get it working... i'm using the correct rev... i have the 3kb file (in the data folder and extracted) but it doesn't seem to work...

Salvo_guy · Post by **Salvo_guy** » 07 Jul 2006 11:41

okay... call me stupid... but i got it working...

but can i use the nightlies still or not???

gigajum · Post by **gigajum** » 07 Jul 2006 11:46

You can use it with the nightlys but you have to compile the source yourself and not putting the file into the data folder.

skidd13 · Post by **skidd13** » 07 Jul 2006 11:49

Here is a guide for usage:

(case you loaded the binary files)
1. Download the normal nightly with the same revision as the actual patch revision and extract or install them. (Of cause you'll need the data-files of TTD)
2. Download the patched binary (first post) and lang files and overwrite the normal nightly files with them.
3. Download the grf-file (first post) and copy it to the data folder of openttd.
4. ready

(case you loaded the source version)
1. Check out the matching revision
2. Patch the sources with the patch-file (first post)
3. Compile it
4. Add the copy_paste grf-file (first post) and the data-files of TTD
5. ready

Thats all.

Frostregen · Post by **Frostregen** » 07 Jul 2006 17:11

It should work with higher revisions too.

I'm trying to keep the .patch up to date with trunk.

nicfer · Post by **nicfer** » 07 Jul 2006 19:57

Frostregen: I have a bug report:

if you copy/paste something and you don't have enough money for all only will be builded a part of the pasted thing instead of sayng not enough cash and don't pop up errors messages (the not enough cash one). I am using MiniIN when it happen so I haven't tested this patch alone.

Frostregen · Post by **Frostregen** » 07 Jul 2006 23:10

Compare it with the Level-land tool.
It tries to level as much land as possible, when you don't have the money to level the area completely.

This is because you would have to simulate the terrain being raised/lowered, and calculate the costs according to this simulation. (Which is far to complex, for too little gain.)
Just use copy&paste it if you have enough cash. (you could use shift+paste to estimate the costs roughly)

skidd13 · Post by **skidd13** » 03 Aug 2006 13:19

just a little bug report:
patch does not work against svn 5731 (i think since 5722 -> 5723)

Code: Select all

Hunk #1 FAILED at 48.
1 out of 2 hunks FAILED -- saving rejects to file functions.h.rej

Frostregen · Post by **Frostregen** » 03 Aug 2006 21:02

Thx for reporting.
Was nothing serious;)

Patchfile updated.

skidd13 · Post by **skidd13** » 03 Aug 2006 22:12

Again a little bug. Non needed entry of copy_paste.c in Makefile.
Nobody's perfect.

Linux binary's compiled without the entry.

Transport Tycoon Forums

Build Templates (Copy&Paste) (r13911 + 0.6.3 + 0.6.2)

wtf???

Who is online