Bug in TrackdirBitsToTrackBits()

[Hazelrah]

Currently TrackdirBitsToTrackBits() is defined as follows:

Code: Select all

static inline TrackBits TrackdirBitsToTrackBits(TrackdirBits bits) { return (TrackBits)(bits | (bits >> 8)); }

This algorithm puts the right trackbits in the lower 8 bits, but then fails to remove the upper 8 bits, actually making it an invalid TrackBits. I believe it should be:

Code: Select all

static inline TrackBits TrackdirBitsToTrackBits(TrackdirBits bits) { return (TrackBits)((bits | (bits >> 8)) & TRACK_BIT_MASK); }

Or was this done on purpose for some reason?

-Hazelrah