New music system for OpenTTD

egladil · Post by **egladil** » 13 Feb 2006 22:20

I don't know about that. It's more a question about what you write and how well written it is.
As for the devs having it easier to get something into trunk, that is quite natural as they are the ones responsible for maintaining the code.

Tron · Post by **Tron** » 14 Feb 2006 06:14

webfreakz.nl wrote:Because it's very hard to get some code in /trunk/ if you're not a OpenTTD developer...

Go somewhere else if you want to flame people who spend their free time to write a game you can play for free.

This patch is based on a hack i did to the sound mixer of ottd. I will not allow this hack gets into the official source, period.

Post by **orudge** » 15 Feb 2006 15:03

Would you, or someone, like to rewrite the mixer then? I personally do not have the time to do that, but I would be a bit miffed if the many hours I've spent working on this go to waste.

In addition, I'm quite aware that parts of the code in my patch aren't too tidy, but I'd like to think for the most part, it is pretty logical. Besides, we have the code correctness police for that too, surely?

richk67 · Post by **richk67** » 10 Apr 2006 02:01

orudge wrote:Would you, or someone, like to rewrite the mixer then? I personally do not have the time to do that, but I would be a bit miffed if the many hours I've spent working on this go to waste.

In addition, I'm quite aware that parts of the code in my patch aren't too tidy, but I'd like to think for the most part, it is pretty logical. Besides, we have the code correctness police for that too, surely?

Owen, could you update your patch to the current SVN (r4341+), as I have a request to add your patch to the mini IN. I cannot get the system to compile (the diff was difficult to say the least - multiple copies of some files in there!) and I know nothing whatsoever about the music system. Many thanks.

Post by **orudge** » 11 Apr 2006 16:06

Hmm, just replied in the other topic:

I wrote: Indeed, it'll probably need updating to work with the latest SVN. I may or may not do this sometime, depends if I have enough time and energy. As nobody seems to be interested in it now after all that work, I'm not sure if I can be bothered at the moment... perhaps later in the year when I have more time.

Not sure how multiple copies of some of those files got into the diff, it was generated by TortoiseSVN so presumably something got confused there. Anyway, the main stuff shouldn't be too hard to tweak to get working with the latest SVN, I just don't have the time just now.

Also, Tron has said that he won't accept the music patch as it is with the current mixer hack - so basically, somebody will have to rewrite the mixer to work a bit more cleanly before he'll let this go anywhere near the trunk, so I'm not sure how inclined I am to do that either, or to work on it in its current state. We'll see, I'm sure.

LKRaider · Post by **LKRaider** » 12 Apr 2006 02:22

Why not implement the SDL mixer as default ?

It has support for Vorbis and MP3, along with Midi and Mod.

Post by **orudge** » 17 Apr 2006 13:19

Silly question, but does SDL_mixer require SDL? (Indeed, just checked, and it does). If so, that's a no-go, OpenTTD only uses SDL on certainly platforms, it uses OS-specific systems where available (specifically, Windows and Mac OS X at the moment, possibly some other systems).

Besides, I've already written the code, it just needs some debugging and tidying up...

LKRaider · Post by **LKRaider** » 18 Apr 2006 00:46

Well, SDL is cross-platform. Works great for me here on Windows. Also, it could be a compilation option to use SDL (as it already is), and it could fallback to platform-specific solutions if SDL was not compiled in (ie: something like it happens with libpng and zlib now, the game works, you just loose the extra functionality).

But anyways, I'll be trying your patch. Seems cool

Post by **orudge** » 20 Apr 2006 00:35

Yes, SDL works on most platforms, but not all. OpenTTD has been ported to architectures SDL doesn't currently work on, and the native solutions are often much better than the SDL versions (eg, on Windows, and on OS X SDL is a cause of many problems, particularly with the new Intel Macs). I personally am not keen on making SDL a compulsory requirement for the game.

The way my patch works, it pipes everything through the existing sound drivers (whether they're SDL, Win32 sound, OS X CoreAudio or anything else). It uses libvorbis and libmad to decode Vorbis and MP3 files itself, both of which should compile on many different systems, and if not, the features disable themselves, just like libpng and zlib.

UltraNub · Post by **UltraNub** » 05 Jan 2008 08:58

How do u use this?

LordAzamath · Post by **LordAzamath** » 05 Jan 2008 09:17

Probably by compiling r3317 with this and change the playlist...A worthy bump...NOOOT. I fail to see why you dug that up..This patch probably doesn't work anyways with current trunk

2007Alain2007 · Post by **2007Alain2007** » 03 Jul 2009 11:39

can music be changed in openttd and how do i get music in my games

like mp3 wma files to work or is it just the old ttd ones that work can some one help me

Roujin · Post by **Roujin** » 03 Jul 2009 11:43

How about reading the initial post? It clearly states what is possible and what not with this patch.

Good luck updating btw, if you plan to do so. Three and a half years of changes in trunk to merge...

Yexo · Post by **Yexo** » 03 Jul 2009 11:43

Probably by compiling r3317 with this and change the playlist...A worthy bump...NOOOT. I fail to see why you dug that up..This patch probably doesn't work anyways with current trunk

LordAzamath: I hope you don't mind me copying your post, it's equally applicable this time.

Transport Tycoon Forums

New music system for OpenTTD

Re: New music system for OpenTTD

Re: New music system for OpenTTD

Re: New music system for OpenTTD

Re: New music system for OpenTTD

Re: New music system for OpenTTD

Who is online