Subsidiaries management (latest build: r7213)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
Thief^
Route Supervisor
Route Supervisor
Posts: 469
Joined: 10 Oct 2004 00:11

Post by Thief^ »

Init wrote:I tried this patch against a fresh checkout of rev 3778, and while the patch applies cleanly, the build fails miserably, with many complaints that it cannot find subsidiaries.h.
gagarin: That would be because svn's diff command doesn't include extra files (like all the subs code) unless you ask it to...
Melt with the Shadows,
Embrace your destiny...
gagarin
Engineer
Engineer
Posts: 57
Joined: 26 Feb 2006 18:52
Location: Berlin, Germany

Post by gagarin »

I know., I just forgot to add them ...

Here is a new diff file.
It's done to r3795, but this release doesn't work (assert error).
r794 is working and the patch ist ok for that version, too.
Attachments
subsidiaries.r3795.diff
(142.29 KiB) Downloaded 277 times
init
Engineer
Engineer
Posts: 93
Joined: 07 Apr 2005 10:01

Post by init »

I discovered a bug yesterday when I was playing with subsidiaries. Playing as a subsidiary to the mother company, I could remove the mother company's train stations but not its train depots. A message that I was not the owner of the depot was displayed when I tried this.
User avatar
bobingabout
Tycoon
Tycoon
Posts: 1850
Joined: 21 May 2005 15:10
Location: Hull, England

Post by bobingabout »

I've also noticed that you can change and remove signals on a subsidiaries tracks, but not place them.
JPG SUX!!! USE PNG!!!
There are times when JPG is useful, TTD screenshots is not one of them. Please use PNG instead.

[/url]
init
Engineer
Engineer
Posts: 93
Joined: 07 Apr 2005 10:01

Post by init »

I have other issues too, one that bugged me a lot yesterday when I played was that different subsidiaries do not have access to the same vehicles. If I accept a prototype offer as company A, it is not available to company B, even though company B is a subsidiary of company A or vice versa. I find this really annoying.
User avatar
CharlyHRO
Traffic Manager
Traffic Manager
Posts: 186
Joined: 13 Mar 2006 11:03
Location: ::1

Post by CharlyHRO »

I found another bug when returning from subsidiaries patch (based on nightly r3755) to latest nightly r3833. The AI controlled ALL my road vehicles, but there was NO AI in the game. The computer stopped my trucks and when the facility was free again, it re-started the trucks. Very annoying. But it's still a GREAT patch.

EDIT: savegame attached
Attachments
Internetspiel (vor dem restart).sav
This is the savegame where the error occours
(499.84 KiB) Downloaded 204 times
moe moe pipebomb
User avatar
bobingabout
Tycoon
Tycoon
Posts: 1850
Joined: 21 May 2005 15:10
Location: Hull, England

Post by bobingabout »

subsidiary save games are not suposed to be loadable by a non-subsidiary version of the game. if you load it, all your subsidiaries will most likely turn into seperate AI players.
JPG SUX!!! USE PNG!!!
There are times when JPG is useful, TTD screenshots is not one of them. Please use PNG instead.

[/url]
User avatar
CharlyHRO
Traffic Manager
Traffic Manager
Posts: 186
Joined: 13 Mar 2006 11:03
Location: ::1

Post by CharlyHRO »

NARF :twisted:

If you would have loaded the savegame you would see the all subsidiaries where merged to the mothers company BEFORE saving with subsidiary patch and reloading in latest nightly w/o the patch. so, when thinking LOGICAL (one of my strenghts) the is NO subsidiary and so there is NO COMPANY TURNED INTO AI. or am I wrong :?:

Image

as you may see, the first truck was stopped (BY THE AI) and all following line up behind... when I restart it the AI stops it again INSTANTLY. but it is MY truck...
moe moe pipebomb
peter1138
OpenTTD Developer
OpenTTD Developer
Posts: 1791
Joined: 30 Mar 2005 09:43

Post by peter1138 »

Hello. This is nothing to do with subsidiaries, or the AI.

What you are experiencing is the multistop code stopping the vehicles so that the roadstop they are destined for does not become clogged up.

This is still a work in progress.
He's like, some kind of OpenTTD developer.
User avatar
CharlyHRO
Traffic Manager
Traffic Manager
Posts: 186
Joined: 13 Mar 2006 11:03
Location: ::1

Post by CharlyHRO »

multistop? /me thinks /me has to check the wiki? but I kind of "load-balanced" my amount of trucks. there will at max be 2 trucks waiting in front of the facility. /me is annoyed... is there any way to disable this multistop-feature?

EDIT: I kind of worked around by extending the involved truck station by another 3 facilities. seems multistop works fantastic now :) before it didn't (2 facilities in another savegame and all trucks lined up up in front of facility A while B was empty...)

EDIT2: @bobingabout
sorry when I said something that could have sounded angry about you. I was just a bit angry about your answer because you didn't take a look at the savegame. but it's my fault, too. I could have told in my first posting, that all companies where merged into one BEFORE i got back to latest nightly w/o subsidiaries patch... BIG SORRY
moe moe pipebomb
User avatar
bobingabout
Tycoon
Tycoon
Posts: 1850
Joined: 21 May 2005 15:10
Location: Hull, England

Post by bobingabout »

its ok, i'm kind of at work, i can browse the forums most of the time, but it is very rare i get an opertunity to run the game to try out savegames...
JPG SUX!!! USE PNG!!!
There are times when JPG is useful, TTD screenshots is not one of them. Please use PNG instead.

[/url]
User avatar
CharlyHRO
Traffic Manager
Traffic Manager
Posts: 186
Joined: 13 Mar 2006 11:03
Location: ::1

Post by CharlyHRO »

erm, okay... /me is unemployed and sits in front of my COMPAQ 1520 flat screen all the time (exept* when on toilet or making some meal :)

* is exept the right word for "but not if" ?? (/me is native german)
moe moe pipebomb
User avatar
bobingabout
Tycoon
Tycoon
Posts: 1850
Joined: 21 May 2005 15:10
Location: Hull, England

Post by bobingabout »

right word, but i think it is spelled wrong(i can't spell good, maybe its dyslexia?). i think its spelled except. btw, I'm at home sat in front of my laptop(1024x768), the screen is crap compared to my samsung 204r. its a 20.1" TFT LCD, with a resolution of 1600x1200.
Last edited by bobingabout on 21 Mar 2006 08:54, edited 1 time in total.
JPG SUX!!! USE PNG!!!
There are times when JPG is useful, TTD screenshots is not one of them. Please use PNG instead.

[/url]
User avatar
CharlyHRO
Traffic Manager
Traffic Manager
Posts: 186
Joined: 13 Mar 2006 11:03
Location: ::1

Post by CharlyHRO »

Mine is max 1024x768
Laptop has a poor LCD!!! max 800x600

Hey, we're going off-topic *gg* :lol:
moe moe pipebomb
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

CharlyHRO wrote:erm, okay... /me is unemployed and sits in front of my COMPAQ 1520 flat screen all the time (exept* when on toilet or making some meal :)

* is exept the right word for "but not if" ?? (/me is native german)
Yeah, except is fine, probably "apart from" is better english. But we all knew what you meant! :)
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
Wenihal
Engineer
Engineer
Posts: 9
Joined: 10 Jan 2005 20:53

Post by Wenihal »

Are there going to be patch for 0.4.7? I'm looking forward...
Nappe1
Traffic Manager
Traffic Manager
Posts: 175
Joined: 19 Jan 2004 17:25
Location: kotka or Savitaipale, Finland
Contact:

Post by Nappe1 »

Wenihal wrote:Are there going to be patch for 0.4.7? I'm looking forward...
me too. even more for diff with Elect. Railways support. :)
richk67
Tycoon
Tycoon
Posts: 2363
Joined: 05 Jun 2003 16:21
Location: Up North
Contact:

Post by richk67 »

Nappe1 wrote:
Wenihal wrote:Are there going to be patch for 0.4.7? I'm looking forward...
me too. even more for diff with Elect. Railways support. :)
Electric is in the nightlies... download it today!
OTTD NewGRF_ports. Add an airport design via newgrf.Superceded by Yexo's NewGrf Airports 2
Want to organise your trains? Try Routemarkers.
--- ==== --- === --- === ---
Firework Photography
Nappe1
Traffic Manager
Traffic Manager
Posts: 175
Joined: 19 Jan 2004 17:25
Location: kotka or Savitaipale, Finland
Contact:

Post by Nappe1 »

richk67 wrote:
Nappe1 wrote:
Wenihal wrote:Are there going to be patch for 0.4.7? I'm looking forward...
me too. even more for diff with Elect. Railways support. :)
Electric is in the nightlies... download it today!
yeah, but the latest subsidies diff ain't that easy to apply to latest nightly. ;)

sorry if I wasn't clear enough what I ment in first post...
User avatar
Thief^
Route Supervisor
Route Supervisor
Posts: 469
Joined: 10 Oct 2004 00:11

Post by Thief^ »

New subs build, no fixes (I think), but made to patch against newest nightly/svn. Dunno how well its integrated with elrails, I'd appreciate some testing about that.

EDIT: replace diff with one that includes the subs files in the .vcproj. Doesn't affect the pre-compiled version.

EDIT2: Note that the vc7 version of the project included in this diff is set so in debug mode it builds only the english lang file. Feel free to change it if you speak one of the other languages. The release mode is set to build all subs languages, but not ones with no subs stuff (and not hungarian because it's one line short).

If you speak one of the other languages in openttd but not subs just open the english.txt and translate the subsidiaries section near the end to your language, then post it back here and someone will sort it out.
Attachments
subsidiaries.r4287b.diff
New diff
(167.51 KiB) Downloaded 238 times
subsidiaries.r4287.zip
New win32 exe
(637.17 KiB) Downloaded 280 times
Melt with the Shadows,
Embrace your destiny...
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Bing [Bot] and 13 guests