persistentengines

[Szappy]

to patchman:
Please look into the persistentengines code.
Every time I load a new graphics set (press the apply button), use cht:resetvehicles, or cht:graphics, my vehicles lose reliability.
This happens because those codes do not take into consideration the setting of the persistenengines switch, and calculate reliabilities according to model life.
This would doubly importatnt, since the new engine expire code.

[Patchman]

Can you verify whether the reliabilities go back up one month later?

[Szappy]

I will, but that will be for tomorrow.
IIRC I tested this in a39, and they didn't. (George's longvehicles with 80~90% and they all dropped to about 45~55% reliabilities in 2070, when I applied a new grf file, I noticed this at least 2 years later, when randomly checking profits, and those broke down too often).
OTOH why would the reliabilities go up? Those vehicles were already in phase3, were it not for the persistentengines switch.

[Patchman]

Persistentengines should put them back into phase2 at the next month. However, there is no vehicle processing from 2050 on, so I guess that isn't being taken into account properly. Because there is no vehicle processing, the persistentengines code isn't called either.

It should be the way that the "apply" button or ResetVehicles sets the vehicles to their 2050 stats after 2050, but perhaps that isn't working correctly.